From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6340FC07E9D for ; Mon, 26 Sep 2022 08:28:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 03B2F8E002E; Mon, 26 Sep 2022 04:28:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2D4D8E0007; Mon, 26 Sep 2022 04:28:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E278B8E002E; Mon, 26 Sep 2022 04:28:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D3F6B8E0007 for ; Mon, 26 Sep 2022 04:28:31 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id AB2B51205D3 for ; Mon, 26 Sep 2022 08:28:31 +0000 (UTC) X-FDA: 79953560022.13.5A2905C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 47D874000C for ; Mon, 26 Sep 2022 08:28:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664180910; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HqsG+MVHFIIYUXh9jWxIMmssIKFxTC2Q+EMTX/72P4E=; b=JNYjtZ386ZGMLopPhcC2KQp3nOV1Ry/zIWYKH8W/bniXjVklSnnBAs/0kDnpEK0XXF6nfQ GP01I8Q6mVDSw1I3tlKE7zpYgW+rtpX3atcG/n49jdRgAIgp16TPCDaPAMwG/h8y7DpXZx TUv9htU3DNvYkhEw27VyBVyC7yDND2c= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-629-htOO07VlNtygwQTzo-rATA-1; Mon, 26 Sep 2022 04:28:29 -0400 X-MC-Unique: htOO07VlNtygwQTzo-rATA-1 Received: by mail-wm1-f70.google.com with SMTP id c2-20020a1c3502000000b003b535aacc0bso1892200wma.2 for ; Mon, 26 Sep 2022 01:28:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=HqsG+MVHFIIYUXh9jWxIMmssIKFxTC2Q+EMTX/72P4E=; b=UwV3YwyNVErQf/P0TPnDbNeMd/faNrYXna5VIlqE69AnvRVZhi6ipGUbLtKfQ8+Fv5 WgghBhJnbcQlJWvxIyUflTWTeIvFLLBgUl/C2LoO00uhwPxVy/A7R/KCu7kYmydaSgLG xDNAYkLe7EyfkVFmo5VOG3eLL2Bw7k66aKqd61acf19dpe2PIMjuVfFyApWfuGoWM+u+ 9rM3dSL0AReD8bedmdd7hTUa1hHZyNTrTFHzIi9ZMnGJOiX+exur0b9Iyz5GYiieOcmM naJTKgqWWLxdUZbblHBX8lq1hZSBocL8yJ1ZAKeA9Jxxq96YSA/UXlmM+1nk4Xv+tfCB uoTQ== X-Gm-Message-State: ACrzQf26wrsYX/auLDt76VdtAizFyDqEAuyHBZZmCXv71kXeReQ/gElQ bXUjOZz8Ri7+veiJwPMdhl61uHIVHOlcPjLfxZoHZwqQ7AHWWS4+Lyw4fmTyrxm8kxJnQjzefZU +m78awhbV8wg= X-Received: by 2002:adf:ee89:0:b0:228:7bdf:47d with SMTP id b9-20020adfee89000000b002287bdf047dmr12331983wro.641.1664180908454; Mon, 26 Sep 2022 01:28:28 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7Bl/WEHU2vEBAzJ2u0mYVj47cUqiOCermg8qPqGs7Ef8aijleyg7ahis7ThaGwb8JRoRHffQ== X-Received: by 2002:adf:ee89:0:b0:228:7bdf:47d with SMTP id b9-20020adfee89000000b002287bdf047dmr12331970wro.641.1664180908227; Mon, 26 Sep 2022 01:28:28 -0700 (PDT) Received: from ?IPV6:2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7? (p200300cbc7034b00e0907fa6b7d6d4a7.dip0.t-ipconnect.de. [2003:cb:c703:4b00:e090:7fa6:b7d6:d4a7]) by smtp.gmail.com with ESMTPSA id y5-20020a5d6145000000b00226dedf1ab7sm13413277wrt.76.2022.09.26.01.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 01:28:27 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 10:28:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH 2/3] mm/page_table_check: Do WARN_ON instead of BUG_ON by default To: Matthew Wilcox , Pasha Tatashin Cc: akpm@linux-foundation.org, corbet@lwn.net, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, rick.p.edgecombe@intel.com References: <20220911095923.3614387-1-pasha.tatashin@soleen.com> <20220911095923.3614387-3-pasha.tatashin@soleen.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664180911; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HqsG+MVHFIIYUXh9jWxIMmssIKFxTC2Q+EMTX/72P4E=; b=UNGZQ+skjXxJCOX3HiFetDxCD9MLtlzwGCcZ9H133MMTeHo4BdWinZ2cEQEmz5fMlGEEEr NZ4H/VkYJ0ib2ilgsAamxSSpoSktI+lgivqwSpjYbVHlhknc5ADOoohfPuNDDnCmRwqqeK yLq3lxlubI2npal1PZiBG/qZBwmZwMs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JNYjtZ38; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664180911; a=rsa-sha256; cv=none; b=8bGgUhrRX0HYSCJMaHd7ISperVzE/1egvIxkcJiZkblj9BzFVkCkMpkGJGHg1u0KFCCkLE v3cMGoS7HHR74A4LOcLL6r/3hALqq1pAsY7INGcviSn6IjjzUEW4eSggUywA/Fo4+GTOig Fz/Tt19j+a+wKlpwSTCSx88Hz8T40RA= X-Rspam-User: X-Rspamd-Queue-Id: 47D874000C X-Rspamd-Server: rspam01 X-Stat-Signature: f9r9nktt388szj93qjush7416n4tg36u Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JNYjtZ38; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com X-HE-Tag: 1664180911-266800 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11.09.22 18:08, Matthew Wilcox wrote: > On Sun, Sep 11, 2022 at 09:59:22AM +0000, Pasha Tatashin wrote: >> Currently, page_table_check when detects errors panics kernel. Instead, >> print a warning, and panic only when specifically requested via kernel >> parameter: >> >> page_table_check=panic > > Why are the page table checks so special that they deserve their own > command line parameter? Why shouldn't this be controlled by the usual > panic_on_warn option? > I agree. https://lkml.kernel.org/r/20220923113426.52871-2-david@redhat.com Use of WARN_ON_ONCE is the way to go nowadays. -- Thanks, David / dhildenb