From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EC00C001DF for ; Thu, 3 Aug 2023 13:08:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA06628024A; Thu, 3 Aug 2023 09:08:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C507828022C; Thu, 3 Aug 2023 09:08:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF17328024A; Thu, 3 Aug 2023 09:08:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9F95E28022C for ; Thu, 3 Aug 2023 09:08:14 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CA10881139 for ; Thu, 3 Aug 2023 13:08:13 +0000 (UTC) X-FDA: 81082821666.03.AE22928 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf04.hostedemail.com (Postfix) with ESMTP id 4F70E40181 for ; Thu, 3 Aug 2023 13:06:57 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SUGygoQf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691068017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/X+DFXZI3c5T+A21PwEqjv45M6yj5eSQTka8SMGUnOU=; b=XsW/ACyBtLTOQ0WaHJTEvPtbHdVv4OmDv48OrwF5Ka6t+qb0HaciG3WZS30RXGwVeM+CU/ rc2K6aOSnA0ba3bATj+wIstREZq+6tUclVKen9MTXSJmuPA/8j2NvRHd3AbHAF9OmlfaXp qPtuhzu/lyOKgJC+Cr5n27uSGVlHfFE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SUGygoQf; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf04.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691068017; a=rsa-sha256; cv=none; b=NqiY/5dHVxRebA+ps4h4PaYqg51xnmQb26rYgGlbH9MgGQHo/2UjDu1nME8KBORl+jPkbH G9GpDBgTjPcVlUtiPlaIrFfhAQ04MHIx1U2E0vVoT1Nm66Ohva+kZpmZNyx5HlC3xcusLq yjDGuJBAo0OasCO25ZbFy7Lvgm8ygeM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691068016; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/X+DFXZI3c5T+A21PwEqjv45M6yj5eSQTka8SMGUnOU=; b=SUGygoQfOKWgOr4Uf4NE5zCbOKGHUdNwDOV0Bz1n+qvxNobNJTcvrjApM6ayKgo8byjSvQ 2EEhOZBHgQhxuoptNXsB0EJU8O7K9BOT8uPZ4t4lgoyRU0TAyM3r6kNz4bavBWRQoic/Sa 5M8BCajrK5J/A7r5M4ybasIhP+ZYY9Q= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-F-DbQLKnNt-nghleXjdHSA-1; Thu, 03 Aug 2023 09:06:55 -0400 X-MC-Unique: F-DbQLKnNt-nghleXjdHSA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3fe1521678fso6194335e9.1 for ; Thu, 03 Aug 2023 06:06:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691068014; x=1691672814; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/X+DFXZI3c5T+A21PwEqjv45M6yj5eSQTka8SMGUnOU=; b=VvUS0apTsBjaRnWMaYVSOCFSEuuqE8KWij9wR32w4jgjUBpGI3AiCsCmx6B+FOJyvo sc49NerhaHUJ5qIjFG0lDTgu76U6g/GMB+3n2bB/ejzmoZKo6mCkiEULOveU4t9W7OOq M72YWATShMkCGpEKZudYmEFeHzZ0qgnZD6nRCIFqQhCcVp/kMY8zeIbwwD+DyjDOTPpj HZJkSSUqFAH1PXTHOfjY4gTIprdbU5l8Cmh3mLR92x4GD47YB/dLTZBOivdySXgRSIny qpJz7xqDf6Ez8MxGPWm5QIXFXOTj3z18rzt+wONA8gJ/88X0fORdDFCtKoXEjxX60CX9 qJGQ== X-Gm-Message-State: ABy/qLa0V0nLHMFIdzCtdlSILEseS0oeHXrNvDzo2JaU4+r1VwMIfcIp MPOxyh/8oXpoS2sfz01YPvhTJ9AqULs78P7Ln/YT9qGd8mY4JlqNlkJc1s6GJfoQxfr8wn1v/Z8 c0FIJNPhjuhk= X-Received: by 2002:a05:600c:44a:b0:3fe:f45:772d with SMTP id s10-20020a05600c044a00b003fe0f45772dmr7532485wmb.28.1691068014020; Thu, 03 Aug 2023 06:06:54 -0700 (PDT) X-Google-Smtp-Source: APBJJlE1UKGmGsiyUttcagcoxQKOvGk5NuIrq9DGgC0oKmlYxpXxmqzZxNmfCOSe8sDh4Q3BGAAwEg== X-Received: by 2002:a05:600c:44a:b0:3fe:f45:772d with SMTP id s10-20020a05600c044a00b003fe0f45772dmr7532466wmb.28.1691068013671; Thu, 03 Aug 2023 06:06:53 -0700 (PDT) Received: from ?IPV6:2003:cb:c718:9a00:a5f5:5315:b9fa:64df? (p200300cbc7189a00a5f55315b9fa64df.dip0.t-ipconnect.de. [2003:cb:c718:9a00:a5f5:5315:b9fa:64df]) by smtp.gmail.com with ESMTPSA id t18-20020adfdc12000000b003143c9beeaesm21857099wri.44.2023.08.03.06.06.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Aug 2023 06:06:53 -0700 (PDT) Message-ID: Date: Thu, 3 Aug 2023 15:06:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH -next] mm: use helper function put_resv_map() To: Matthew Wilcox , Ruan Jinjie Cc: linux-mm@kvack.org, Mike Kravetz , Muchun Song , Andrew Morton References: <20230803120312.945774-1-ruanjinjie@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4F70E40181 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: qn7epfc1s4dwf1tdtig1mam5tjp8ibqb X-HE-Tag: 1691068016-871898 X-HE-Meta: U2FsdGVkX1+vfHjTr4cbvFGVFu/psyfJn709FlzX4nbzAaYGur0Q00rlbkQRsotq/IYFVacKOe7OUmt5fv+o2H2qUQ4K4ikximDr3mpRCEP1BkxBXG7zfhJ+7uZhMZ7Hgy5O/Ed5GtLGg/D0SpJNVD2KbwuvjgCAEI9k6KlxMbiNcOeJQDWzGnXQ6ILv7/rASkBz+QUYwFAodzT3UWuiLofT1IIBhtKnf80pi8opMLWQIoNZ4pQ5FBsGG8ZPbIYGIfqZ1g2cT+oh1ugvKkBXHhqKT8hhbEVsT1EBqAfoC934fqCXbDkdCgN6abadopBoieGoAmRQgUR8J64gic/AulKP2RHeLIHEn0EvjDsemLhG7D7mJFn75NNPpGJEwZnVaPG7fZ0ARTSAC1SzvQEXnt0qFH1WWXNT/9/gMODLCveyqtrFy6bgRZDjk3yXvYuTO4bDr+v5Ed7z+PfHcN5EVCxW802dFV1q96y2i1xgCnXdkHZLgQEmA09YfzRZ+Z837I3XZerwHlU2Gc8s+4Y/zHhcUcEovByFp6H0PpdrpnrkM9DNPvs3MK1CvtUkxilibGDtmAEvW5T/N7K4oaGJ7gxFMBa0b5I94rIZ8iil/2nocEpBcwfFqojlniqrTHlhgoZteiskxmelefKc75JbyawtErudrMM++PKnmu6cJHnbIJH5g8CrPWcHk4L6XQGwANruIYypOasZ0jwaZrd+PbSLrIxneW/KPglodGIWbKes/M57RozXbUerZLdyVonyzItaDsDKq0kPUQfGY39+UxbEW6WMvEhM5qHsv4erMlBhDcYXFLij4WOofC6F3UnBBBzL9iP+YNswrtSzjIbGt4wBN0IWwif+hIIuE3i2YzzLryg3jfm3f0TDbHnkaXEladh7r5naCEoz7nVgm9ltZjQaFuQb0aXKFNyaOrXtyEbRqxPZiwySvsS2bIxww5UO17JB6V8mwMmwUZA6qDU Rqiwt8ot Fa6MCsTSjJSIZHUmjx6pSgaGD8KLBy1d6Fs0gUdhu3OR1vrabbYc2dTVVZrhg8pYKJA2Z8coL7v6RwLLEw/ur9b9vuqYzC0/1Bg1h5GsVz1KoIo21dQ0Jw9zRJSqu4Dyq055SeRFAyLUMw47cZJid6u+ueZ237xEPdcyvJLX1LhlGydhIYPylrBmioUZRccJasAz31W1scq9suWxUdw981kTsOluYSXiFIwGnYx+OSian2EWozvxfQvAntKb9qibRnKUX8CE97SHXQ2DjP5QCb/q1UeprtYw3SbDfWw7I4Henv5BfZW7wSbsE8/BbZTyEaHV4uJmguaa6vZbhv/TW95i0cLEtNYfinH7EH6k2qDFdHhVBbqEa2mjKD8l/EJzkJAUuonFZfI/KMbE3Qr+Lj4dJ1k+vGpMwFx2A9y5zN+H9pHE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.08.23 14:31, Matthew Wilcox wrote: > On Thu, Aug 03, 2023 at 08:03:12PM +0800, Ruan Jinjie wrote: >> This code is already duplicated 3 times, use helper function >> put_resv_map() to release reserved and allocated regions instead of >> open code it to help improve code readability a bit. > > I do not think this is an improvement. Agreed. -- Cheers, David / dhildenb