From: David Hildenbrand <david@redhat.com>
To: Matthew Wilcox <willy@infradead.org>,
Ruan Jinjie <ruanjinjie@huawei.com>
Cc: linux-mm@kvack.org, Mike Kravetz <mike.kravetz@oracle.com>,
Muchun Song <muchun.song@linux.dev>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH -next] mm: use helper function put_resv_map()
Date: Thu, 3 Aug 2023 15:06:52 +0200 [thread overview]
Message-ID: <f8fec90e-6c28-e9b2-c808-ad023fcfb191@redhat.com> (raw)
In-Reply-To: <ZMueFzzfTbvfhkzn@casper.infradead.org>
On 03.08.23 14:31, Matthew Wilcox wrote:
> On Thu, Aug 03, 2023 at 08:03:12PM +0800, Ruan Jinjie wrote:
>> This code is already duplicated 3 times, use helper function
>> put_resv_map() to release reserved and allocated regions instead of
>> open code it to help improve code readability a bit.
>
> I do not think this is an improvement.
Agreed.
--
Cheers,
David / dhildenb
prev parent reply other threads:[~2023-08-03 13:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 12:03 Ruan Jinjie
2023-08-03 12:31 ` Matthew Wilcox
2023-08-03 13:06 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8fec90e-6c28-e9b2-c808-ad023fcfb191@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=ruanjinjie@huawei.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox