linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Leonardo Bras <leonardo@linux.ibm.com>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
	<kvm-ppc@vger.kernel.org>, <linux-arch@vger.kernel.org>,
	<linux-mm@kvack.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Paul Mackerras <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	Arnd Bergmann <arnd@arndb.de>,
	Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com>,
	"Christophe Leroy" <christophe.leroy@c-s.fr>,
	Andrew Morton <akpm@linux-foundation.org>,
	Dan Williams <dan.j.williams@intel.com>,
	Nicholas Piggin <npiggin@gmail.com>,
	Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
	Allison Randal <allison@lohutok.net>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ganesh Goudar <ganeshgr@linux.ibm.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	YueHaibing <yuehaibing@huawei.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Ira Weiny" <ira.weiny@intel.com>, Jason Gunthorpe <jgg@ziepe.ca>,
	Keith Busch <keith.busch@intel.com>
Subject: Re: [PATCH v4 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks
Date: Sun, 29 Sep 2019 16:17:20 -0700	[thread overview]
Message-ID: <f8fca251-e31a-1d50-49e9-e69a893d9059@nvidia.com> (raw)
In-Reply-To: <4ff1e8e8-929b-9cfc-9bf8-ee88e34de888@nvidia.com>

On 9/29/19 3:40 PM, John Hubbard wrote:
> On 9/27/19 4:39 PM, Leonardo Bras wrote:
...
> +config LOCKLESS_PAGE_TABLE_WALK_TRACKING
> +    bool "Tracking (and optimization) of lockless page table walkers"
> +    default n
> +
> +    help
> +      Maintain a reference count of active lockless page table
> +      walkers. This adds 4 bytes to struct mm size, and two atomic
> +      operations to calls such as get_user_pages_fast(). Some
> +      architectures can optimize page table operations if this
> +      is enabled.
> +
>   endmenu

Actually, the above should be an internal-only config option (PPC arch can
auto-select it), so just:

+config LOCKLESS_PAGE_TABLE_WALK_TRACKING
+	bool

...because it's entirely up to other code (as opposed to other people)
as to whether this should be selected.

I got carried away. :)

thanks,
-- 
John Hubbard
NVIDIA


  reply	other threads:[~2019-09-29 23:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-27 23:39 [PATCH v4 00/11] Introduces new count-based method for monitoring lockless pagetable walks Leonardo Bras
2019-09-27 23:39 ` [PATCH v4 01/11] powerpc/mm: Adds counting method to monitor lockless pgtable walks Leonardo Bras
2019-09-29 22:40   ` John Hubbard
2019-09-29 23:17     ` John Hubbard [this message]
2019-09-30 15:14     ` Leonardo Bras
2019-09-30 17:57       ` John Hubbard
2019-09-30 18:42         ` Leonardo Bras
2019-09-30 21:47           ` John Hubbard
2019-10-01 18:39             ` Leonardo Bras
2019-10-01 18:52               ` John Hubbard
2019-09-27 23:39 ` [PATCH v4 02/11] asm-generic/pgtable: Adds dummy functions " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 03/11] mm/gup: Applies counting method to monitor gup_pgd_range Leonardo Bras
2019-09-30 11:09   ` Kirill A. Shutemov
2019-09-30 14:27     ` Leonardo Bras
2019-09-30 21:51   ` John Hubbard
2019-10-01 17:56     ` Leonardo Bras
2019-10-01 19:04       ` John Hubbard
2019-10-01 19:40         ` Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 04/11] powerpc/mce_power: Applies counting method to monitor lockless pgtbl walks Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 05/11] powerpc/perf: " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 06/11] powerpc/mm/book3s64/hash: " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 07/11] powerpc/kvm/e500: " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 08/11] powerpc/kvm/book3s_hv: " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 09/11] powerpc/kvm/book3s_64: " Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 10/11] powerpc/book3s_64: Enables counting method to monitor lockless pgtbl walk Leonardo Bras
2019-09-27 23:40 ` [PATCH v4 11/11] powerpc/mm/book3s64/pgtable: Uses counting method to skip serializing Leonardo Bras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f8fca251-e31a-1d50-49e9-e69a893d9059@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=allison@lohutok.net \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=christophe.leroy@c-s.fr \
    --cc=dan.j.williams@intel.com \
    --cc=ganeshgr@linux.ibm.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ira.weiny@intel.com \
    --cc=jgg@ziepe.ca \
    --cc=keith.busch@intel.com \
    --cc=kvm-ppc@vger.kernel.org \
    --cc=leonardo@linux.ibm.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=mahesh@linux.vnet.ibm.com \
    --cc=mpe@ellerman.id.au \
    --cc=npiggin@gmail.com \
    --cc=paulus@samba.org \
    --cc=rppt@linux.ibm.com \
    --cc=tglx@linutronix.de \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox