From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CB57CF6497 for ; Mon, 30 Sep 2024 09:34:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 97D9C80022; Mon, 30 Sep 2024 05:34:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 904E480017; Mon, 30 Sep 2024 05:34:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7091D80022; Mon, 30 Sep 2024 05:34:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4E45B80017 for ; Mon, 30 Sep 2024 05:34:19 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id F40F81C6E8C for ; Mon, 30 Sep 2024 09:34:18 +0000 (UTC) X-FDA: 82620893796.01.ECA41F7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf12.hostedemail.com (Postfix) with ESMTP id ABA6540006 for ; Mon, 30 Sep 2024 09:34:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EmrzaqJR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727688754; a=rsa-sha256; cv=none; b=5WHT091ok2F81lNrJz7Qm/8MqOvrNcmw8y9NEkPksVjpiPOBW32Z6daaMWjgU372nCXqVg QXH3WFjufwFrCSItWbgp71VRRcmvkklCa9u4IPypD+hU0DtNEEjAUHZFeDSNKP1Ximedw/ 1hUoqENB6I8o2Wv2xf0norB9Ht+n848= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EmrzaqJR; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf12.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727688754; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BZVthEUNPIwlM6FtjNXOfho4rXdOAOuOvTnuN3Ett20=; b=Gy2EMiwN/A5h9bRA5SKAvGosfv3dVjmujT4ntZWoviU49SXt6p6q1O9B5a3h8QUZwkJMpv DCIRq5KHyowSf9WfSsMfm8oKab76aPjH045crHvkAK63/CjocFVp6SEVV/UNryTb0Vk7bQ oefqMV98PsEDT7Ty6rzewri2We8/RCE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727688856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=BZVthEUNPIwlM6FtjNXOfho4rXdOAOuOvTnuN3Ett20=; b=EmrzaqJRrKaBAcRGQ/nEwv/VBFuHyrutA856RePBZTa2LHOY6KMOTCF4QH84OSXHk1KuIf ChHUPv1fJEjFOe3Ee85IRd9QrUxBrUjzQhpsngl0eVfda7kP7gPZfoYXSINVpjXGUN0S9D vyvhBZalVDVYBT2NmS8yezg28u2cehg= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-689-oXytT4saMOqsaNCOV0ufHg-1; Mon, 30 Sep 2024 05:34:12 -0400 X-MC-Unique: oXytT4saMOqsaNCOV0ufHg-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-42cbadcbb6eso31810475e9.2 for ; Mon, 30 Sep 2024 02:34:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727688851; x=1728293651; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BZVthEUNPIwlM6FtjNXOfho4rXdOAOuOvTnuN3Ett20=; b=AmElPiqotn51esVAgcNZMkaIo5jg59TE9Cdup/ygreLf+Fv4BFsxguDpcCF489+2pn LBO/eF/5pFMcnj6fSiEMnhXHQk6lyW9YOWSCFms+GvPnjpDfprxoHj4B202vKj620HKk HzM0uzioWvNeP9mRQCwJ+ovTEsJ5Rroouww6EHno7vw29+6auLtwYTdfEanApYoLOQHI 7iUdwUJMJUbVuzez9xXr7A66z1xElIDtUsPoQmwyeTOWjbU2O+Ah6gfK7+6cCnCINuTe b5gVCU6SLeKwGuU854UI7qRdZjE0hJpuzkDNkAByx/WHseyY2tnnttPeTztxKTj9tcjd NoUw== X-Gm-Message-State: AOJu0YzJiIpwPqatIZCWKs0O8b6FUOkrPMXKLfgl6KSlZGjgkK7/9E2U Oc+IXnJZlTQJ+ep4rCLTssw9qaQR1ZyfgYfRX+isQVBLcdfNP5JhsIWbwc5IN54Fh/Bm7nBTN5R aHmKkgHZfKj8IZ7DthgGSxQYBz3KiviqTpoi3jiytz+kaP3VreMvpqgD5rvQ= X-Received: by 2002:a05:600c:1d20:b0:426:61e8:fb3b with SMTP id 5b1f17b1804b1-42f58497f3emr75046765e9.27.1727688850667; Mon, 30 Sep 2024 02:34:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE9564xoWIXAwNWACxO0PL3zRCHxnAkBlODzEk3tsz/hgC2LVEkzK7dp2NTczi6+euZoUHS3g== X-Received: by 2002:a05:600c:1d20:b0:426:61e8:fb3b with SMTP id 5b1f17b1804b1-42f58497f3emr75046565e9.27.1727688850279; Mon, 30 Sep 2024 02:34:10 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42f57de11aasm97132975e9.16.2024.09.30.02.34.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Sep 2024 02:34:09 -0700 (PDT) Message-ID: Date: Mon, 30 Sep 2024 11:34:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm/cma: print total and used count in cma_alloc() To: Xiang Gao , akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, gaoxiang17 References: <20240929032757.404707-1-gxxa03070307@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240929032757.404707-1-gxxa03070307@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: ABA6540006 X-Stat-Signature: 4obredzzj6j3ciiprwoh915oau9gsx19 X-Rspam-User: X-HE-Tag: 1727688856-222931 X-HE-Meta: U2FsdGVkX18cq6wkPj7oBobOeCr8NURDjdcfxVDC1QiwMtP/bZzdIMH90vKxGq4PH5mSkT6R80riyXf+kPcB6N5pNKakowGE/qqMa1Cl0Tc/rz8NJ4Tb3yfSwFErh4CBgSnEmmDixjDGhljvL4Dp28bejLnfoe0L9X5N22JAtFiWEE+9kIZ7wj5ecvEDvEgFPDjgv4XD38GoX/rEGQTqqX96/JT6SOnlkh6/uxT6JvBInkceL3ls8Nhug1ZG+Plj6vRkL7bcqnF9W9BUfQMz+2gFn9nmu3/AH7TRTJGjXFDh44PWqrgYSDQLcLjXUcPH536NaSHGCvb5TO5Q3k4S1SdrjH+bQd3/tiAd0XKb2ey7DqmO9VKSkptyn0WIFk1xqT/kVgJDSUfpAtY8HZU/rDzI8v+7Iln+jjSn4bbMU/knTIV8YUoGF8YneAXtwOwOSoEM7LLHa9zM0IoQeGH8WoA8JVD7EFulAiZWKFsOst+6BT/+8Zm42s0BSnbaGW6YWbJX91CclUU4zt7z2CPExbTPvh8VzmAjyKaSKF96oIsHQPaSE9rJnuPDhmVVGhplPWFh4RWXwRKsG6EFclWXqJ/SWmfMuj9PPNozhAfC2BWeSdeT0kfKFDF+AwPp0silEykduZjtf19vBVpE5Rb6FM93MWvnljx6MJzo0hDl13jhIC4m764P/OJ7WOrJA/xWg+Ep1YV6bDtz6zMi4ZAdVualzT2NIyifsz9NZ3DNjqHfY6PCw6EKEqDnTGXrMXhBVhDXd0/G62nQLhnWdYwva/NR3t0s/dC4TQ/DHPAyKemUxwu8ZhzgpFZlyqhCvGKir/35dN7O/cdxUMKxeAjpudTgfEi9l9jQ66zkQioqzwoYYkyEiqrmW9BB39MHNPKerQK3HQm1ITtPvwD9oIeLwIIKIZlGS8nYhSAW2J2dkR2WOKp27z7kgmAUZFwAzdKdN5K/uZm5b4XmPNdtt+4 sKqI/C+s M2OPeBdkXU1otBhNdO2aGG22noBNNB0e1XDzEJ3xedX8n51no5gdEya4olDfYQKf4ZJ2gbhsrhEgIjaSkPWIl/LcfQndAo112rRPqnou/3jQ7QtnjqpyE3EHfuc4geGVE/JinA7pTU9WoEyksEASnoYeetvFYsj7LxKzCg4gK0UIXLjGMW8VHDiuJpqrgrMnbCIUPE/AYraAYnqYbMhndaQfDI5hKzQZsubIGcb83g1xH/6f9waw6pEYpuS+2U3wxMhN91dgVrBFNwKsq+FVanb7lUPF3AkYbw+9Cl+V28aJ7/CyK0uKUd9TgbSAtjrzbZP5CNAINW9vAkad1QfxRTZzMiQbxYjQEhyUtpqd7Wp44phgguMACcTFXjRUq/Qni+eDV2r+sNwm2elpQ28bYmawJCRaWstEHIm90TwBaHnUZ8e8ZKDAPJP8S7VoCKAivefwwJUeJmmj2DGgWzf77InB2EJ5G9BpB50+/PRAV/i6bVo4Lduvn5lVzs7ckprma/amQrPqKZZ/JpUMgJvd+tgZPLQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 29.09.24 05:27, Xiang Gao wrote: > From: gaoxiang17 > We should add here "To debug CMA allocations (especially failing ones), it is valuable to know the state of CMA: how many pages out of the total ones are allocated, and how many were requested to be allocated. Let's print some more information." I assume Andrew can fix that up when applying. > before: > [ 24.407814] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.413397] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > [ 24.415886] cma: cma_alloc(cma (____ptrval____), name: reserved, count 1, align 0) > > after: > [ 24.069738] cma: cma_alloc(cma (____ptrval____), name: reserved, total pages: 16384, used pages: 64, request pages: 1, align 0) > [ 24.075317] cma: cma_alloc(cma (____ptrval____), name: reserved, total pages: 16384, used pages: 65, request pages: 1, align 0) > [ 24.078455] cma: cma_alloc(cma (____ptrval____), name: reserved, total pages: 16384, used pages: 66, request pages: 1, align 0) > > Signed-off-by: gaoxiang17 > --- > mm/cma.c | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 2d9fae939283..90b3fdbac19c 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -403,6 +403,17 @@ static void cma_debug_show_areas(struct cma *cma) > spin_unlock_irq(&cma->lock); > } > > +static unsigned long cma_get_used_pages(struct cma *cma) > +{ > + unsigned long used; > + > + spin_lock_irq(&cma->lock); > + used = bitmap_weight(cma->bitmap, (int)cma_bitmap_maxno(cma)); > + spin_unlock_irq(&cma->lock); This adds overhead to each allocation, even if debug outputs are ignored I assume? I wonder if we'd want to print these details only when our allocation failed? Alternatively, we could actually track how many pages are allocated in the cma, so we don't have to traverse the complete bitmap on every allocation. -- Cheers, David / dhildenb