From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38514C61CE8 for ; Tue, 10 Jun 2025 01:52:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF3286B007B; Mon, 9 Jun 2025 21:52:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7EF56B0088; Mon, 9 Jun 2025 21:52:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9473A6B0089; Mon, 9 Jun 2025 21:52:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6EF8C6B007B for ; Mon, 9 Jun 2025 21:52:24 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id D2D73120ABD for ; Tue, 10 Jun 2025 01:52:23 +0000 (UTC) X-FDA: 83537816166.01.4E8E5F3 Received: from out-180.mta1.migadu.com (out-180.mta1.migadu.com [95.215.58.180]) by imf29.hostedemail.com (Postfix) with ESMTP id E058512000D for ; Tue, 10 Jun 2025 01:52:21 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jQ6bWXKr; spf=pass (imf29.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749520342; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=txTKTVbjb1Tcro1zaVUKXsDZFFkm5+kxAZnE4eguYL4=; b=N+efSBAvj8qCiMByGJ84mi+fhrCt8anOTGdO9LMmOAKn1NuFzH74+gQHvnFGvtITMvrC8m 5UBRtsZMJ7vm890/jhO0vRZdb5hjaNM8MXAwxf4jAje6GM7sWxXP32CNPF2mBAGOCQ/tbp EgtY8bHiU38nLElxxHZrdZdCJJJZdh4= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=jQ6bWXKr; spf=pass (imf29.hostedemail.com: domain of ye.liu@linux.dev designates 95.215.58.180 as permitted sender) smtp.mailfrom=ye.liu@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749520342; a=rsa-sha256; cv=none; b=TqzBnePsqtJ2Zzm0cbHzw4sDuRAc599cn/GOhJ0Z5GVpyIuYeREF1Nv1e0w4HwCb8I6ovY 7pzjJuBNWVHZci7Zi8Dd/l2bmLO5Neabv84LHaJVK77kLkYxq0UrC3o3Fb1RM1vzKuz1AQ ruwfGJv4coC48OYt2PmcLmcNjngRlqs= Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1749520339; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=txTKTVbjb1Tcro1zaVUKXsDZFFkm5+kxAZnE4eguYL4=; b=jQ6bWXKrvpYQX6ruyOxhS3SgK3yIHWX6uZtvI6yIkZqIXHA8pADCGoyIK+CIEGhgpSuBNe HKVOAiqkMnsTzsuIT/ZACfjrbHSyysCLEsqKY8TCnQ3vPd3wGTFDumZBdz4SiWpm4PguQf 7K9+z0riZBcZsmjh9ymkZvqNMxPBrKw= Date: Tue, 10 Jun 2025 09:51:30 +0800 MIME-Version: 1.0 Subject: Re: [PATCH] mm/memfd: Rename error labels for clarity To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Ye Liu References: <20250609031858.73415-1-ye.liu@linux.dev> <20250609172654.a99c06d8ad90a6a994545e5f@linux-foundation.org> Content-Language: en-US X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Ye Liu In-Reply-To: <20250609172654.a99c06d8ad90a6a994545e5f@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: E058512000D X-Rspamd-Server: rspam09 X-Stat-Signature: ewrh9sysoohfm5tgq8i6sujiz5j5njbz X-HE-Tag: 1749520341-715881 X-HE-Meta: U2FsdGVkX1+STM6T5KjzqleLVzfVHNglM2lgTslHsh/IWeo915+JWYXSfQ/Z6xi7zmig9JsOFg9p69i0O884c1/1X3pZHkm0YS5/MK1tIwbKB0H1QpTqpuVPuCQyct09MCxskx+8hNMRk8ZeKPWYEulLmU/KA9eF3cvhtXW3fX8T22dOjHUoTD3j2V8K7LDM95kvwjOTEwS+RAB3S0yEV9F3KSR0Z1tdFczBxeDcrjTp03O4LZCVf3+JxARnEzHV8s6uqnyoB8Lv4YekK23hg1EEcd0Z867E3w6eg4PpokLSErJyCzf/2k/TtYxjlCpfMVD9C6EvrysipZHRfu1usa3MR/JINKW+l82Q+TgCIO2nfNy0ZJQ+qY9KlGqbxDquJLjo9uX4X6eCRd3giGV38MCtrHToua4stjzUMsEfX+NOFq2xdVHjO86s1dShkUFF9K1mqCZE49uv2oVH8yhbCdKXBElV3tKoMSOXKgE4cWlw8htntCoPjIqkU37DbXbYoMFEPdpAentkPW3LfgMlemj3VP7YblJly6hTrs9GKhGLfZAfH4Ep5gfan+T6rV9530TpCuP/V6CO5MimULt+dzr9DhuRkrTDPyLctV5qzzFtLn4+P73cU8Yeu68rmLj23BH/cimw225q3LIgMLiL3iexVrSp59qZAU/NWZgCyzLCioyPPmlzJLTAjpcE9rIAocsprW5d4FHnFQbiQ2sv9iRAzbPtdwpJGcm6uBSUl/Q63/ALB3FJNuoG4ieIrpro7Iu7u/r4qfIGBG9E8SStMBnmb4LY2kAOkViDan/QHdKUsg5QLiEnanMzMZTalrgSfQbkM0zU2g/tiGoiaY5GXOeoo0Csb83eFYysqVbND/AYrVhxazBPE6HiosY19cwJ0Oh5fbugR68FS8UYzmQI7a15GBiaQXZVe6eOB3i2sc8Grh94WlcXVjEwwzae0nMZ1wLpXHWX8CdFXO0H4DY jG9WZYw7 XKYFB73J2gr8HfFgqz9uvEdZfNhnE3tb0xAkx5hkY4+Eck8P+wWsnLZw+8V+5bEwwodBIfIRCq8RYWDbKU0cug6IXK8Kfg31iWcO8QYcUEORZ8d2vKG5Pir96+TkxfFJXOqSd3kl9Oyr4cM42iVqbCT/d5BV15N/K5MDYnMXUp5tuhoF5C8mIkSWbMKuH9yQQOIcHNX9+EXHWVhz35ThnIqztPoopUoypZCmcdG0+WoBHZrfrQ8fKFKQyVw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/10 08:26, Andrew Morton wrote: > On Mon, 9 Jun 2025 11:18:58 +0800 Ye Liu wrote: > >> From: Ye Liu >> >> err_name --> err_fd (fd failure case) >> err_fd --> err_file (file failure case) >> >> ... >> >> --- a/mm/memfd.c >> +++ b/mm/memfd.c >> @@ -475,22 +475,22 @@ SYSCALL_DEFINE2(memfd_create, >> fd = get_unused_fd_flags((flags & MFD_CLOEXEC) ? O_CLOEXEC : 0); >> if (fd < 0) { >> error = fd; >> - goto err_name; >> + goto err_fd; >> } >> >> file = alloc_file(name, flags); >> if (IS_ERR(file)) { >> error = PTR_ERR(file); >> - goto err_fd; >> + goto err_file; >> } >> >> fd_install(fd, file); >> kfree(name); >> return fd; >> >> -err_fd: >> +err_file: >> put_unused_fd(fd); >> -err_name: >> +err_fd: >> kfree(name); >> return error; >> } > > Not really, but I see what you mean. > > "err_name" means "there was an error, so free the name". > > "err_fd" means "there was a problem with the fd". > > > We tend to use the former convention. See > > grep err_free mm/*.c > > The memfd_create() code would be better if it used "err_free_name" and > "err_free_fd" to remove this ambiguity. > > Someone who was feeling bored could go through > > grep "goto err_" mm/*.c > > and check that we use this convention uniformly ;) > As suggested, I've reviewed error handling labels in mm/*.c. "err_free_name" and "err_free_fd" would be better. I will send patch v2 later using Subject: [PATCH v2] mm/memfd: Clarify error handling labels in memfd_create () Thanks， Ye