From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9254C369D5 for ; Tue, 29 Apr 2025 02:24:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37F1C6B0008; Mon, 28 Apr 2025 22:24:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 32E736B000A; Mon, 28 Apr 2025 22:24:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F7456B000C; Mon, 28 Apr 2025 22:24:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 00AD56B000A for ; Mon, 28 Apr 2025 22:24:09 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A835ABA804 for ; Tue, 29 Apr 2025 02:24:10 +0000 (UTC) X-FDA: 83385486660.30.28421BB Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf22.hostedemail.com (Postfix) with ESMTP id 49AE2C0004 for ; Tue, 29 Apr 2025 02:24:08 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Eu/VLqjy"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of baolu.lu@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=baolu.lu@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745893448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zsmuz9eQL48qnr4xlmF5nW8rV5R2SiDRvWC0kwoVziw=; b=0rqHYF1FUoqP7km4OAEmCLbv5/O7anaG06xGtNcjQZvsUz7QWL9ffU0VqJetmvsIbPJU/O iiG/nXyic3KX5YVhn1O2PGIeR5gczMlN+a/lkmjdjoGUwfp28Gq2W9BBwlZ1dXYkBU1gSn wf4/XLaBCG8jznwl6gsUomWlTjJIuuY= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="Eu/VLqjy"; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf22.hostedemail.com: domain of baolu.lu@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=baolu.lu@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745893448; a=rsa-sha256; cv=none; b=Rp4d2VdurpcO1mJsf3/25X2MTQ/9NC0L4gAyj1Fkk4+NfJA93TavYUWIG4ByoLqk6gFMTN 2AD11PQ/87hNp1WWkcZ657BZWkHgs5yRmA6CwtoMz0N3xR/kG8LQjiVO44UlOOa9VW4wtX d/baAn56imsZ1TcdItxMGDspYg3DTvI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745893448; x=1777429448; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=6sGMzojzYlJ54g3FQSKtIDOIOOhDQGpN7BZFln60WPk=; b=Eu/VLqjyox+WFVF+DSJk7KALGB0hPQxZNaElUOTs/9MHfcfQkMMjvbKA QxV/IKnHvE3G2hOpJzQWN/LRs5BG60dlyNPvvPC+0glutslE21IAjLJa4 eCN/kkNUJcaG/j6O8Nj+j/toW+nd7Cm5Wb93GLyjiteEb+2V939km2bjC fo0t3vL4b4CxEbzF9xEwds+5xJKBtwN0heILzn1Us1z5FWbVvMRLM8TYB vYAXIQcIO/0zhu+S5UzEYQ5R+DZ2qhOZSW2vIYkM6YsaqqSiXBJBA58is 0XaNgHmT5BQY5l7fQUrik/ys15YT044OXjcq3y4bbs8/TsJsy/IJJbXYO g==; X-CSE-ConnectionGUID: QbRl+VdYSI+unzgIPjh/Fg== X-CSE-MsgGUID: foq//XgbSsGXSy0wyic9FA== X-IronPort-AV: E=McAfee;i="6700,10204,11417"; a="51319160" X-IronPort-AV: E=Sophos;i="6.15,247,1739865600"; d="scan'208";a="51319160" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2025 19:24:07 -0700 X-CSE-ConnectionGUID: vvNJFknhTVeWI8A1w+PaZg== X-CSE-MsgGUID: xZVcFf42RYGbSOpMJUPKUw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,247,1739865600"; d="scan'208";a="138678340" Received: from allen-sbox.sh.intel.com (HELO [10.239.159.30]) ([10.239.159.30]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Apr 2025 19:23:58 -0700 Message-ID: Date: Tue, 29 Apr 2025 10:19:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 03/24] iommu: generalize the batched sync after map interface To: Leon Romanovsky , Marek Szyprowski , Jens Axboe , Christoph Hellwig , Keith Busch Cc: Jake Edge , Jonathan Corbet , Jason Gunthorpe , Zhu Yanjun , Robin Murphy , Joerg Roedel , Will Deacon , Sagi Grimberg , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Niklas Schnelle , Chuck Lever , Luis Chamberlain , Matthew Wilcox , Dan Williams , Kanchan Joshi , Chaitanya Kulkarni , Jason Gunthorpe , Leon Romanovsky References: <69da19d2cc5df0be5112f0cf2365a0337b00d873.1745831017.git.leon@kernel.org> Content-Language: en-US From: Baolu Lu In-Reply-To: <69da19d2cc5df0be5112f0cf2365a0337b00d873.1745831017.git.leon@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: gatrscg3c9mzsxjnfceq3h1wmmromp41 X-Rspamd-Queue-Id: 49AE2C0004 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745893448-782369 X-HE-Meta: U2FsdGVkX19ATOGAde+xl3yf/UA2pPPJ4q2H1LDA6Md+2ZO+cXT49aBVJFvxgCAURYoWWLHga768W3W18L78Rz5L9VUpN03OoufA0vsrbaOyEO1r8NoKhShnZkAcDTS+XkYLc30rj0HlmjPNO9YI+ndmn1NXdTkC3iNUMC4K4GYNv/OMOfFxCekuZxgUcxF7VhduRxnKTeZ6bjCuqFegM8oUCAbqzTZOPj2SAqk847OYD37kzYFEsZW3a6+pdpj/DI98WONP8yuyEs/obDFSSLU0HqucxJae1+pD28ONVdnQhQjETb+D0xb8vnSeIDslQk0Zw33KAMl3ChAb9bW/4axf9jFLzzNIAludNNNTNODfBeXf1yHK0dplU97iO+UjydNTSeXZNRCrCl8+nZCJdezqw6tV5qgTidUk/3AAB595hni1qEoTIGWEaG+hf/m34BIDEmo2QU4Im8ZkimUk3BCBKXm9wg9WYEPQwfXDV3XXuW8sNJL5qsNyyDtCWDgShZcpG3GP5N5hcU26G1i9q+uludsPlogdb+w6e3VOJVzIty9hzKdyauVTwKHlYV7+SPz37ULF2WmS3nkRjAfUC+gOjKFHlhMTBb2Uo+lYc9EzUaMySFMYic19gF9m1Y6T7kTqlGrnAxY5y/HROfi0C8FjM+yHAuQrC/GLmD7s5zGphopnaemrkwUzcz67/BT7pY7zKh5SF2nhv3ocB/pxOgTQtr+3qpNpo3PuS/xqQwauE6b2H9zIj8RNpKOYbVK67e/v7AZmRRFdq8B/cu3vfBOf4zErH9o1TAn9duoLTpUBpmRdg0hcX22pWYaWIawj46bhf3081gsGmlZDxKh0OML2K0Nwe15n6+8tVyEBfD1Qa6JpFxmrWD+Xey+wQz/0hDwjOpzc4LhTgz9nAbRtroRf3IM5GFWrB9fZYEvsovS1xWZ4f20pfqiTL5ZJdoF1f9HyVWUEgfsqqSlcxbf 2vRhLir+ X0VJi207RTiP5VNO8sv4MWTK8S3hzzH8yL19c4/E8eR+2gcqV5YaFdC8aY/tR/agGW6Ze/stpjRZlPrcRMp6M97C3nPUspAIDi8wKgKnQ1/hiDCkhjsTwUO0OPItwxjjzW4bpqWCTbAV7dwJgWDUQSWJR/v318235HrBTbi5G7b+ZWcGvm9Ue/RjiLP6Tq6Ogxu2NBe7Y9BPcSVlIx6UZMSfMRjks6ZflT8CxrVbCoxaH0pc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 4/28/25 17:22, Leon Romanovsky wrote: > From: Christoph Hellwig > > For the upcoming IOVA-based DMA API we want to batch the > ops->iotlb_sync_map() call after mapping multiple IOVAs from > dma-iommu without having a scatterlist. Improve the API. > > Add a wrapper for the map_sync as iommu_sync_map() so that callers > don't need to poke into the methods directly. > > Formalize __iommu_map() into iommu_map_nosync() which requires the > caller to call iommu_sync_map() after all maps are completed. > > Refactor the existing sanity checks from all the different layers > into iommu_map_nosync(). > > Signed-off-by: Christoph Hellwig > Acked-by: Will Deacon > Tested-by: Jens Axboe > Reviewed-by: Jason Gunthorpe > Reviewed-by: Luis Chamberlain > Signed-off-by: Leon Romanovsky > --- > drivers/iommu/iommu.c | 65 +++++++++++++++++++------------------------ > include/linux/iommu.h | 4 +++ > 2 files changed, 33 insertions(+), 36 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index 4f91a740c15f..02960585b8d4 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -2443,8 +2443,8 @@ static size_t iommu_pgsize(struct iommu_domain *domain, unsigned long iova, > return pgsize; > } > > -static int __iommu_map(struct iommu_domain *domain, unsigned long iova, > - phys_addr_t paddr, size_t size, int prot, gfp_t gfp) > +int iommu_map_nosync(struct iommu_domain *domain, unsigned long iova, > + phys_addr_t paddr, size_t size, int prot, gfp_t gfp) > { > const struct iommu_domain_ops *ops = domain->ops; > unsigned long orig_iova = iova; > @@ -2453,12 +2453,19 @@ static int __iommu_map(struct iommu_domain *domain, unsigned long iova, > phys_addr_t orig_paddr = paddr; > int ret = 0; > > + might_sleep_if(gfpflags_allow_blocking(gfp)); > + > if (unlikely(!(domain->type & __IOMMU_DOMAIN_PAGING))) > return -EINVAL; > > if (WARN_ON(!ops->map_pages || domain->pgsize_bitmap == 0UL)) > return -ENODEV; > > + /* Discourage passing strange GFP flags */ > + if (WARN_ON_ONCE(gfp & (__GFP_COMP | __GFP_DMA | __GFP_DMA32 | > + __GFP_HIGHMEM))) > + return -EINVAL; > + > /* find out the minimum page size supported */ > min_pagesz = 1 << __ffs(domain->pgsize_bitmap); > > @@ -2506,31 +2513,27 @@ static int __iommu_map(struct iommu_domain *domain, unsigned long iova, > return ret; > } > > -int iommu_map(struct iommu_domain *domain, unsigned long iova, > - phys_addr_t paddr, size_t size, int prot, gfp_t gfp) > +int iommu_sync_map(struct iommu_domain *domain, unsigned long iova, size_t size) > { > const struct iommu_domain_ops *ops = domain->ops; > - int ret; > - > - might_sleep_if(gfpflags_allow_blocking(gfp)); > > - /* Discourage passing strange GFP flags */ > - if (WARN_ON_ONCE(gfp & (__GFP_COMP | __GFP_DMA | __GFP_DMA32 | > - __GFP_HIGHMEM))) > - return -EINVAL; > + if (!ops->iotlb_sync_map) > + return 0; > + return ops->iotlb_sync_map(domain, iova, size); > +} I am wondering whether iommu_sync_map() needs a return value. The purpose of this callback is just to sync the TLB cache after new mappings are created, which should effectively be a no-fail operation. The definition of iotlb_sync_map in struct iommu_domain_ops seems unnecessary: struct iommu_domain_ops { ... int (*iotlb_sync_map)(struct iommu_domain *domain, unsigned long iova, size_t size); ... }; Furthermore, currently no iommu driver implements this callback in a way that returns a failure. We could clean up the iommu definition in a subsequent patch series, but for this driver-facing interface, it's better to get it right from the beginning. Thanks, baolu