From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07310C3DA49 for ; Tue, 30 Jul 2024 10:11:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63EA46B0088; Tue, 30 Jul 2024 06:11:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EE4C6B008A; Tue, 30 Jul 2024 06:11:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B5B56B008C; Tue, 30 Jul 2024 06:11:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2D3CD6B0088 for ; Tue, 30 Jul 2024 06:11:27 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C61B81401FA for ; Tue, 30 Jul 2024 10:11:26 +0000 (UTC) X-FDA: 82396001772.24.3530A6B Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf23.hostedemail.com (Postfix) with ESMTP id 065E1140010 for ; Tue, 30 Jul 2024 10:11:22 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T6nTpmsS; spf=pass (imf23.hostedemail.com: domain of arnd@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722334230; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qIJ46khXFSEAama4nq9DuQ90e9y0vg5FIHWryakasRg=; b=JqMeUVfaEsBvW/6eGBiqQ32riMbaQ+3FfPoNNtL5RLArqaIM2dLS+Z2gl8pXnPNFC/Pnc9 44NPeB3PY19ZIZ26byeeMQsv39VKRJKYWO0ZUBmJWTIIctCWkbstVZW2qW+EGMdZ48s4Sf VItIxxzn1+hiEBCwyzv1jqTALDuTbTM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722334230; a=rsa-sha256; cv=none; b=uvcv478rZtFk/0LXEqBvPiTXYKUGMmWoXLLmlIQTTqft2cvdDRO4vQ++rmjAjLvleT1CRF VC/u6ha4YU4DaGPJ/gHT4yUIkHSHGO99eR89lC8vGOPIHlGsbAZwBWU9weRrD2PUnpAVHn 4cfqEYB8CrO90oubrrGibUMIJ+vU5TA= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=T6nTpmsS; spf=pass (imf23.hostedemail.com: domain of arnd@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 9326BCE0F6D; Tue, 30 Jul 2024 10:11:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D605EC4AF0F; Tue, 30 Jul 2024 10:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1722334277; bh=pWtd5ufJwbu8T0nenKU0dt1FDubCPi1BqdpCJAfG+Dw=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=T6nTpmsS13RyRnVy4mJY7pj3Wvu6M/nUImepwXmML8WBdQQlQlbA88Twg50lWUOp2 1Cy6i7TK3rc4x2P9bpNZ74XUEzU8bOpEZRc5SU3UTcMU13KExw3fNmSWQMlSoofYXf KEiye1sxHblaI8dEEXhtOhs4fvYxo1/HgmulS4b2B0jkqvXX1IUmiGK9NF8yjjT0Hr dwA312DcKm3Z7gEl+DjzMJzEFjUuH+Z0mdKZ1M2xtgf7vhnkhLI7hn8Wjve7YA8edq xMerJ5lZ1iqpe3ztbJnSxv1d9i7X8pIhVfz5jRi6SYehnRA5JzXh75XYUzYDNrzgCv 7etKvLsD4ZK6Q== Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfauth.nyi.internal (Postfix) with ESMTP id AC8191200066; Tue, 30 Jul 2024 06:11:13 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute4.internal (MEProxy); Tue, 30 Jul 2024 06:11:13 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrjeeggddvhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefoggffhffvvefkjghfufgtgfesthejredtredttdenucfhrhhomhepfdetrhhn ugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugeskhgvrhhnvghlrdhorhhgqeenucggtffrrg htthgvrhhnpefftdduueeitdfgveeuudeikeduudfhffejjeejudeuffdtiedvleduhfeu gfdtgeenucffohhmrghinhepphgrshhtvggsihhnrdgtohhmnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghrnhguodhmvghsmhhtphgruhht hhhpvghrshhonhgrlhhithihqdduvdekhedujedtvdegqddvkeejtddtvdeigedqrghrnh gupeepkhgvrhhnvghlrdhorhhgsegrrhhnuggsrdguvgdpnhgspghrtghpthhtoheptd X-ME-Proxy: Feedback-ID: i36794607:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 772D5B6008F; Tue, 30 Jul 2024 06:11:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Tue, 30 Jul 2024 12:10:41 +0200 From: "Arnd Bergmann" To: "Linus Torvalds" Cc: "David Laight" , "linux-kernel@vger.kernel.org" , "Jens Axboe" , "Matthew Wilcox" , "Christoph Hellwig" , "Andrew Morton" , "Andy Shevchenko" , "Dan Carpenter" , "Jason A . Donenfeld" , "pedro.falcato@gmail.com" , "Mateusz Guzik" , "linux-mm@kvack.org" , "Lorenzo Stoakes" Message-Id: In-Reply-To: References: <402c3c617c29465c898b1af55e3c6095@AcuMS.aculab.com> <5cd3e11780df40b0b771da5548966ebd@AcuMS.aculab.com> Subject: Re: [PATCH v2 1/8] minmax: Put all the clamp() definitions together Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 065E1140010 X-Stat-Signature: xap41eak1kf119bmqihsnzzg6rnideto X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1722334282-937684 X-HE-Meta: U2FsdGVkX18O8pLQKE7+bxwLj7uwTixzKjvyfiN4dwBuq44zRGwcI9c6yWcZkB01JqgMwCUUdrcaU5aS5GYI4lnUQQwdFYeZa86lCcegOZTMRSYZBz4G5EuesJLTW+Qj51td8lnlSqSj6aB+l5SkdspH2VlWmcubOrGBqGueBzPkPepFn5f0hsLuAcyhLKIPBc5wnLXZ7XY05yUZdZaUiEQH5davWugYdwICYePj+BHsH7PmelCyxBd2OdtRNNb3pmG30sdQkUrWk7JB5TAL3Jm5n15L6c9mz38NUGSOf9+1scFCuSCqVQQRFDVuu0JPQ+cIzCrj8V0HYjArmEv5mF41/2wGPED6kqpQvBD9rcS/kamX4P2mi3n6rcydE8YJ0IYivrjhzgO/NUQiVTMIGOnejdNGKuijE5GnIA4eKcnV/xWZkXwhQKwpMf9bU+5Lh/63L74xitw3XDz/iMhtL95m8oUQZBGBEVmXQEbP+BEBcm0DLdIux/dSoAWznrsNJ/CUjsdOXAAhDgw02cSuNf+V84cL5ZZKUdzNRz5wwAOprdpuz/ufdUW8XKDuZjTSPMXNm9q/c9mF0UkgNtr2cVmXTr4gTRX3/truk3D0bZ9IKGar+UM75yPgZwjHIjuOpsjwowCHGZc9v2gqR1KvqeTPirq80bZkz3EfAgGe9f9O9oeXcUgdXa2JhW+jngjV5m8Idr8Iy86p3SKtMMvyMleeFJxrIxAIJZ2nD87mM4mz2fnR2TIDswbh5ufrbrGRQ+JHYZ+WhZAQIskIO3DsTIbFDLiOCryD2VgCHHF/wz7f85A0rA4+bFOv8udulUWVKhpMJ+ldggfsXrFK5aUZwLXBrxqWfqdr/2C8pS3nx1Y6PWh1vVrgeOaznHGoVsoVBP5c3vg+hdNvz2ImdN2RyoDIA3W1FU0f5b911qIo4FvZW3vUIESWROm2VKT44mS3CKW/8bJbLisC+hitTta v3O0ArZx AHQC0Ls2vstKJ0HbWUV002cZMDtTIiSyoZDFhJPTaEhQ5jXZTfItN7+YyGYeuiOCyX6/in3PnpDhP7rvZenTnPCWYN9zUc84QeFQhlnUkHPbY36i2gc2yYCrnc7R3exs2i3dbl61ReBalxJWnh9pS3+gybjc4kxQo8N673horb+duNNUO056nujhIK3XFBD6VTA1eGptLFmb2rUoa+LC6A5o+9SmpWtujm81yUy3zcybT6fPg2f1GmPwdH230ir4csjvAYXSux7B/Vy3NsOWXXV4RDlXudf/tJZbEicJNOIExL1aetrVBrRm+nz1hHoSHS6EcECxN+8tKewVsMON4JWw/A0UrGTkUAzMB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jul 30, 2024, at 05:59, Linus Torvalds wrote: > On Mon, 29 Jul 2024 at 16:21, Linus Torvalds wrote: >> >> Attached is the patch I have in my tree right now - it complains about >> a 'bcachefs' comparison between an 'u16' and a 's64', because I also >> removed the 'implicit integer promotion is ok' logic, because I think >> it's wrong. I'm giving this a spin on the randconfig test setup now to see if there are some other cases like the bcachefs one. So far I've seen one failure, but I can't make sense of it yet: drivers/gpu/drm/i915/display/intel_backlight.c: In function 'scale': include/linux/compiler_types.h:510:45: error: call to '__compiletime_assert_905' declared with attribute error: clamp() low limit source_min greater than high limit source_max include/linux/minmax.h:107:9: note: in expansion of macro 'BUILD_BUG_ON_MSG' 107 | BUILD_BUG_ON_MSG(statically_true(ulo > uhi), \ drivers/gpu/drm/i915/display/intel_backlight.c:47:22: note: in expansion of macro 'clamp' 47 | source_val = clamp(source_val, source_min, source_max); See https://pastebin.com/raw/yLJ5ZqVw for the x86-64 .config that triggered this. >> I don't think a min(u16,s64) is a valid minimum, for exactly the same >> reason a min(u32,s64) is not valid. > > Oh, and I noticed that it screws up the 32-bit case, and that does > need a workaround for that. > > So here's a better version. The patch contains one possible fix to > bcachefs for the type confusion there, but I'll wait for Kent to > respond on that. That's still a typo in the 32-bit case, right? I've changed __builtin_choose_expr(sizeof(ux)>32,1LL,1L)) to check for sizeof(ux)>4 for my testing. Arnd