From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9DC5E732CD for ; Thu, 28 Sep 2023 12:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B63F8D007E; Thu, 28 Sep 2023 08:02:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63F098D0038; Thu, 28 Sep 2023 08:02:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4911D8D007E; Thu, 28 Sep 2023 08:02:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 36C7F8D0038 for ; Thu, 28 Sep 2023 08:02:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id DE182160F12 for ; Thu, 28 Sep 2023 12:02:11 +0000 (UTC) X-FDA: 81285868062.30.D46ACE8 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 50354160025 for ; Thu, 28 Sep 2023 12:02:07 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X75jpHew; spf=pass (imf08.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695902528; a=rsa-sha256; cv=none; b=gPVXoBshOud8ypPrmhh6Vzv97U3ndnkJWA1Kvg9vzTGOoMjl/raHGpOyXr7JQQUxQNeWHU t2SLjOFkI7K0JplIjk7eIJLDlxUAEgDAeaTjfJSH0/s0qo8i/7mYBc3fqs553YlL+YADcl vBxab1+IFrwUdWRuJvK7B7hCoDfYHdE= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=X75jpHew; spf=pass (imf08.hostedemail.com: domain of jlayton@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=jlayton@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695902528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1OUz3HfWq12NDsf5pt/6tI4U8Mw0C+kMAWU6iE/wPW8=; b=A4Y3wVBxyhnDquZIA5d7SFOR53z81ruiAWK7mS1Tz/Z4NcyMq/DbaziLYwOk1/KraLrUCD VgO1wekkvuWzcW94djEzxso7prlSvnKERHjBcVWbulSzFQFz4qO6lXyRypMixldaDIl1JL 32TB9DYtgYi3kopz4m3TD9UqWlsm6hs= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 63305B81BE2; Thu, 28 Sep 2023 12:02:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DA9FC433C8; Thu, 28 Sep 2023 12:01:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695902525; bh=1OUz3HfWq12NDsf5pt/6tI4U8Mw0C+kMAWU6iE/wPW8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=X75jpHewuenH5i4yKP6hTRRG96bBnvYSW9ppyaPCvnjRr7Vm9FFZm7UX9cHhEdgJN 9sWsiJl4JoQqsZw/GKoi7gqY0vw1WSuYAKrfeyF1owUUDgi337zCsV6xBykTFrjqQ4 1IMm02SWv3ExmYV6PPhf6pdloK7xjV68MtysVko9J4sCrAu5RV7rZ7A69VK3LrHZj/ A70QTwuFIQFa4pBSyL7/hVskPkmrikqba+e0r1Z/ds7+Y2X+m8S6nvykGKta//EbMF i8R56KOYB+jvupadzk05Se+6sdUCAkxdoK6c3HGUXdwYBTc4QSGFZzFBPryJ+pbGMH lSy4ugTII5Mvw== Message-ID: Subject: Re: [PATCH 87/87] fs: move i_blocks up a few places in struct inode From: Jeff Layton To: Amir Goldstein Cc: Alexander Viro , Christian Brauner , Linus Torvalds , David Sterba , Theodore Ts'o , Eric Biederman , Kees Cook , Jeremy Kerr , Arnd Bergmann , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Greg Kroah-Hartman , Arve =?ISO-8859-1?Q?Hj=F8nnev=E5g?= , Todd Kjos , Martijn Coenen , Joel Fernandes , Carlos Llamas , Suren Baghdasaryan , Mattia Dongili , Dennis Dalessandro , Jason Gunthorpe , Leon Romanovsky , Brad Warrum , Ritu Agarwal , Hans de Goede , Ilpo =?ISO-8859-1?Q?J=E4rvinen?= , Mark Gross , Jiri Slaby , Eric Van Hensbergen , Latchesar Ionkov , Dominique Martinet , Christian Schoenebeck , David Sterba , David Howells , Marc Dionne , Ian Kent , Luis de Bethencourt , Salah Triki , "Tigran A. Aivazian" , Chris Mason , Josef Bacik , Xiubo Li , Ilya Dryomov , Jan Harkes , coda@cs.cmu.edu, Joel Becker , Christoph Hellwig , Nicolas Pitre , "Rafael J. Wysocki" , Ard Biesheuvel , Gao Xiang , Chao Yu , Yue Hu , Jeffle Xu , Namjae Jeon , Sungjong Seo , Jan Kara , Andreas Dilger , Jaegeuk Kim , OGAWA Hirofumi , Christoph Hellwig , Miklos Szeredi , Bob Peterson , Andreas Gruenbacher , Richard Weinberger , Anton Ivanov , Johannes Berg , Mikulas Patocka , Mike Kravetz , Muchun Song , Jan Kara , David Woodhouse , Dave Kleikamp , Tejun Heo , Trond Myklebust , Anna Schumaker , Chuck Lever , Neil Brown , Olga Kornievskaia , Dai Ngo , Tom Talpey , Ryusuke Konishi , Anton Altaparmakov , Konstantin Komarov , Mark Fasheh , Joseph Qi , Bob Copeland , Mike Marshall , Martin Brandenburg , Luis Chamberlain , Iurii Zaikin , Tony Luck , "Guilherme G. Piccoli" , Anders Larsen , Steve French , Paulo Alcantara , Ronnie Sahlberg , Shyam Prasad N , Sergey Senozhatsky , Phillip Lougher , Steven Rostedt , Masami Hiramatsu , Evgeniy Dushistov , Chandan Babu R , "Darrick J. Wong" , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Hugh Dickins , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Stephen Smalley , Eric Paris , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-rdma@vger.kernel.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, v9fs@lists.linux.dev, linux-afs@lists.infradead.org, autofs@vger.kernel.org, linux-btrfs@vger.kernel.org, ceph-devel@vger.kernel.org, codalist@coda.cs.cmu.edu, linux-efi@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, gfs2@lists.linux.dev, linux-um@lists.infradead.org, linux-mtd@lists.infradead.org, jfs-discussion@lists.sourceforge.net, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ntfs3@lists.linux.dev, ocfs2-devel@lists.linux.dev, linux-karma-devel@lists.sourceforge.net, devel@lists.orangefs.org, linux-unionfs@vger.kernel.org, linux-hardening@vger.kernel.org, reiserfs-devel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-trace-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, bpf@vger.kernel.org, netdev@vger.kernel.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, selinux@vger.kernel.org Date: Thu, 28 Sep 2023 08:01:50 -0400 In-Reply-To: References: <20230928110554.34758-1-jlayton@kernel.org> <20230928110554.34758-3-jlayton@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) MIME-Version: 1.0 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 50354160025 X-Stat-Signature: 81bpzgic5hjxuxo65yw43mkc5srbpdh6 X-Rspam-User: X-HE-Tag: 1695902527-422519 X-HE-Meta: U2FsdGVkX1/PrOSt2eIH1/jAJUWucXUkYIA0GUGJU5p9C47kIn7uT0qgW1d74SPnjAAwv5/IhhNo+WzOvZWLvxIghKHIj4YxLFJOBMEQCK1e5ZKyxQT02lRSu/0TW+OMR6xwado2pEpLVkdVa0X4zUeNkFMFWocr2y/7Vx6jir9mlD2KfAYzh6icKkakl1L8HqRn0Z8wr11sokAqtnK6vCVr2+mZCbFgfhlOKtRwz1szmEif6+BMlwDA3IiIkNgDaqzzxjhgspbkBaqFg/5jKrNP9JKd+sVPDEpFBa06Q05GX9mKZ/PF/SH9WUp7LURSEHPQo2iJL3306XRcnhnPxOwSRlwRxasuWI+O6sYzJ9lDPRM/HfFsB8S9D3HxYyLr+wXY1doygwbrwj+XMx1iN6sVPoQBCm72iO4rP0M/EWoMe8Eu0Bdc59dmk64SzFN+t4U/JnnGh7q38V9CB4zQuS7b+cCeMAYRqPJYCB10DaruYQkQ08GEciep3jZ/QvFv3zZZQeCgsj6lPQOXU0xruhinFo6x9M23rj1fFy/zMw6s6nen8XTNVXWqGqr682sx0OKDs43a8bSJqAzdIf+JDdHDS1JLdOC9Ph33aKPslYNXeOaqPmtXlxGno+Eyk01mFj+o8Qy/Q7tOjOpAYeOiKxn0V7j6Y5lc2/tffkfStpem9xhfyf52sRd5alxXguyFoIO1QuTgdqYu1TkZY1f/kORPhOtje6kX17WTY3tYwnu76FSL4UeoWR13Ww3qDvDmQGBzAJg5Zoh5Q70MVL8vUZU0QA0ne3o3msUDp3CVDN4IJKzGdVpPlASYX5T4WYGVc/FuO6RAcIsg5RehrIX71oFPpk3nvg5STXuwhdetqTGA6yNTzkgtd976sN5AvpnUjZKy3xX/9MXyN+qpM5EBG9bxBZcFavkku8+fqCViIMOqGz/oXYceso/1OqZnvAKMOQkwVmgGwNjmV2yAKlr 6NQQE900 hfUY4XEsAbmewYJIPBkjB4cwoVVH1KZP6vEymGZDSJDJxOj88kW2tpusOsiaDzjMmW914L5cbCzRC/fRWhN0CrmUL1Q4B6lX/Lrje4ff2kPcq/VyoJhyp8E/k+YiY2PD1OKsEWiygKjXm73wBwO1oGThPMIU6O6xprLrQ8wqjBLgzvZBHJnlS3hXSZT7i2E7FCdcmhKGvrSBMzU+1dpcyU9ZyrYHlDp4SD3QbhxgaRfyegNh4Yk8wI6svuofuLSV6ElR2ypTuPJ2fKL3vbu7OCMyEAHMXEFhvPCLMAZcTvnJG4hHDD7PN4WwvERQZIHFXqyP7r8MxeRVbxzM/1dp4OUnrsqeTdSi0VR1v00a3hSNe8XtcOVrIAbjXZNzFkzJsaO0oLnwPAEHI3siJYKC06tvKmP9nMZr3APfX8xEEJZjmRwbw+Lcg5s+JR9AaCYSf+N+WAdRTpPDEPnRbCdpvNxpjA4gq3v5BAGu5VLjFnS6ajn5GF9R+0L9Uuo4IZwSAs+sBRDm6V2bjgeVIhkgDiGMKcohK161miKldukmyRxKpf0U14cjIrq6OzG+Z3s05odru8h7vWRdz/CtjQV3Zu9rFHZdLsVEd1IuaZ3IDb0bjNtPpeLRL5Uzw/+rsoSnqa5qizGsS5svefQsNrTgpqQ4e9CKjPVzHWD7GwbJkcFZzaa4FlVKxhTVYhZufHfVctOBV0fFCwHEf63EfPSF6qB7RH5PlIUJA0nd89gy4HU5AKlfiyBryu2FYjvaRrk4vhBvZh22G5sgJonjtxUpy8tNt02StPL4F4L+Z5M6XHa6Iwi/QduQobEX/Ul8udyyTEqAjeD0X0n2nHWS33vQuhmAhA4lwcKjnMG/8NOs27TZbXD2+mk2Z60g8ydloUFcK8Too7kI32muweFtOuCzFxvQnj4GPTLKCBbRpZ/MTVshDZ711d7KMyzw8iUkvfD+M9yyrRuBB07r3UPIqNhUQkuaCE/p5 KF+18p1h cQ7ky90ilP5UIJg2S2HLbaEr0SyjubqX9PlTbl6MNB54PXasJbn1VNiP19lH/DCk/6PxZIzV42x5KdN+Ak7bL2gHML3ccgmdVId5R6T3qa46P1psgXT7+9oTkE9/mVW/sAXtNSCA69m50lqNovD70ujMB4rUQ2+ugjGto/buEsKLYFc4XoXHb7pSlvFHQmAvJjbFrxfB5xbFlb7cr8OIVzFWtD7opcdWwO6sDmvU0B3qXrQ1AsT1lrWQKCkkZo1SpwxyCKJH7v8a95bnnQPDjyUCybw2o1ExZvj0vy9RXjR3cWzHFiEfSBCiSpRnqzi76ZEh6CHXNg3RkBmxbc2VvRXkqEoM1nIg33pSxkcz+eCco+m+YaVWzTHw+aNejcDTvIIkuWPb5V+Pgr0F3r9go5mXxM4c+79m7cBJxuu2CZoGmI5BpXF7Wi/vpNgecQZMVBfLJ7Bibe676KlJb1Bt6VJO183c9bOt9Vqhcd24WgO4/J5sYs+nguck0Kpl9E6pUuc3h+HYL5gKwJVr7Yk5a4s2uEPRxafsvu6RxBYd9C2N4Q/rmj4dmlVQjMjClHScq5ajMp23fLO/cQo7igpIsE95ypYz32SxAJ4XXq8QzQC9ArTXfrXveR575gUGh+/wiCHYZ1aD7+8onK9bHTeB/soOcM+C+iClwza5bE7PcTs5Rofjh24nThQie59siGCgnmXRQ/pqW5/Ja6s39xCa3tAFYudcQXreAPdo0m8ncDjIDz02fE3/QTuInq9g8T5P2QeB3TsNMjZ3iwQq6Fgk4/JjQ9PWp0d0O0uYVAprsbMTmdbvPJGoE7hf0ZCVfXKvEIBuS8WbVo6Bu2iwBDdHIorVSf/jwM18zLhlZZD9/TzlTI7v3G59g9CEUrxuETBU8c/jkKutIIUq6q+M1E2qEkS4GAd+wVMRCKyE4tnLmJQMWEVgVHhJbPdd0Jut6IyeImGtJpLve3Uzd4k9YXdFmjfvyneYh PGWFQphP 4h0gwOYrRQYofpYtcwlTPqQh9n2RxGlRKTbwhbQ0T2b6Sr4isbQP/kN6NP/eHZn8xQhgwOTIQMZKFGL8ssjT8scxrmSqK+UqAS1TjhfbAhDX8XuXGRTXnw8QbcLlMH01Gn6hMWktJCKD2AKBtVpmXOv9FSB65VBGcCzvsqxklEy/VV3LEMmova+JVQs1vc062rl2SYnQ/sm1h10P5dNs2emJFSIj3qLuc79McrFpOIvMszqGse1CTFnEVk4B6Z0uVpuixH28FCBl1uf04GSXRwqbvD45EOQN2hUh1yXzx3mYQs1chCZaupncKQw24+LG2SuxyCPkHusVyaCA4zvfAcjDOwYyjcV7QFbGlSMSS2ejKIbeAjtYjCSHQQlhJ1lWBKcjGL8mMwF5D+sj2ToPa6CdzBU54dAMxNuZ6dIdqlQrs9qFV6YmMzXNiKtyONeKU0FvhmmvHB45QHp8Q9s5+FHlWcwSKf4OaeiklN+pvLrI+2OWIB83Mctuj4H0Op7u96+bc0txsW+/5ctA1MaO24awzKP6bLWsGnFPMa94rxzq/L+rH7Qpy7UNtdEuiD6v3/8i5uVXXEJVUQ3c+KrGszefFZ40l+Nmn+T05P0NhB6hKC5NJkLvdwfdfw3hJiHodAEjE6Ic1KFnVcPBiKO/hDgY62FcT40OQzey/eg+4e7U4AFEno4T/XYqAr7aStrHv4mPA8xn9aGKtJZZNc4fz/9xE4YxOQXs5LEBzfb8oJWuGIygzau+fVZJjpAb0JAvAdBkViDB1tmhlR/cFdlJbpkt3wN7oGYeYVIBCfOB8Jplya1xtV/x1jie2JiRTF9fHAByE9Hb8mdbDQBBFXY1iOqg6egyz4VUKMswoDXTjbo6DaGs1O+X8IYDWd5Ww1RwmHQYhvorZ/UuFj3XD8QZljlix3YtgdgbXqz4V0vBQKP2bH0PtbnVT8lDvMPJE8eLYWa7KVbH/P+6kquH7eFHkpIGk5lgl 1O9cU+0i zitsHqf9XIMrq7Xx9H7HlaSoEoaDtCOV4qpWSiK7WMdaMvw2/pGZatUqCd3L+PbJ7JUsmf5qoeJwZRWKO5QZu2dPR21yr3Q3pgqr/axOmSbo7cHi9RGug4G0UXKJtzE7zH74ecPVAQi76mhGA+DxlXFGazmCdz9HmZtVBb+7lXJBzeW3OqBsZxztlMixRRsNmRZOOahEm9OExT/cOFcbH1Jx5Xxe27ye19xVAyutR4knWu2MABN2m4Si0trPNQFSShzU8bm6ztKQBB64/o0edSCtyieG+8oqqFz8anQ+6MELJ1vpE5AcI51lIEfy0qRKuoe7AxsgCGZ96lai3MBKVoZiyX0Y+aIrGXoClNoCMrz/ufrJpvBYayOnr3oAOC9YbD6xtfLjg+6oJ1+jSN2tIf974eEF2/n/0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 2023-09-28 at 14:35 +0300, Amir Goldstein wrote: > On Thu, Sep 28, 2023 at 2:06=E2=80=AFPM Jeff Layton = wrote: > >=20 > > The recent change to use discrete integers instead of struct timespec64 > > in struct inode shaved 8 bytes off of it, but it also moves the i_lock > > into the previous cacheline, away from the fields that it protects. > >=20 > > Move i_blocks up above the i_lock, which moves the new 4 byte hole to > > just after the timestamps, without changing the size of the structure. > >=20 >=20 > Instead of creating an implicit hole, can you please move i_generation > to fill the 4 bytes hole. >=20 > It makes sense in the same cache line with i_ino and I could > use the vacant 4 bytes hole above i_fsnotify_mask to expand the > mask to 64bit (the 32bit event mask space is running out). >=20 > Thanks, > Amir. >=20 Sounds like a plan. Resulting struct inode size is the same (616 bytes with my kdevops kconfig). BTW: all of these changes are in my "amtime" branch if anyone wants to pull them down. -- Jeff Layton