From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7059C54E58 for ; Mon, 11 Mar 2024 17:09:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 413D96B00F3; Mon, 11 Mar 2024 13:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C4426B00F4; Mon, 11 Mar 2024 13:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2B41C6B00F5; Mon, 11 Mar 2024 13:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1BFF06B00F3 for ; Mon, 11 Mar 2024 13:09:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7D15A16027E for ; Mon, 11 Mar 2024 17:09:54 +0000 (UTC) X-FDA: 81885395508.16.76C706A Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) by imf11.hostedemail.com (Postfix) with ESMTP id B45E54002C for ; Mon, 11 Mar 2024 17:09:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=OOEYxatM; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf11.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710176992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DJk4OccdsDgrvApN46LlvnNx2J20bXazGhIkO+MbIuM=; b=8LBYS6CpFvPyheIZBHrgQiRN8Jr4n4nbMWQnIIc1hbt0EoIkOYP7cm7BqJ1ixHi4ctxTll nqwEQhr0LCfADvXOet0K/DMYrT/pQKk30Eqz/TDQEop7LISaUMQhDvsd4k0tkEysxu/M1g Yowbd+DbWZj/1Q1CPAB8tkwjLUJfqc4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=collabora.com header.s=mail header.b=OOEYxatM; dmarc=pass (policy=quarantine) header.from=collabora.com; spf=pass (imf11.hostedemail.com: domain of usama.anjum@collabora.com designates 46.235.227.194 as permitted sender) smtp.mailfrom=usama.anjum@collabora.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710176992; a=rsa-sha256; cv=none; b=L633b8eRsOhOgul7he+pobhiN4UJsi0ufkaydqJdcnkaoZoopb+HaFxlrRqzZm5Xaolkiq FSNGF+T8Vv5rG5fVDk+k1RpDs+hW+uT4yHHNbHSuzp2PdLWTmirFWVi7gw6DNgz4Huv58e Byrk1KTPU5tqKonotRIkLRXKVxFxyEk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1710176991; bh=yy7nLIc9ARnpjfGsqcuqP0zQZXEMX49eVq06dLU0h04=; h=Date:Cc:Subject:To:References:From:In-Reply-To:From; b=OOEYxatMo5uTX/liE3V8JTujD6RVwmqScXEq20wkVnKvQCPQp6BdkOCR+qurJbIqt FVsNOJFGhfW3CH1wX91vAwkkF0+pgDXGkiFeCCuQ85xmp+4NNmqi1bn34jXKxq88Qb I2Fw4fNQpf/5eXabYSKq90AICCvAgp28ejqIXKbWwczWdd6clPCCgOLB5s+PyNN2OL fL2AmIiW0UBpUg24faQPjJ1RaPIrqjNja4G5VCwqR+SuOMSt+RJUxQSmDrcWS/1s30 nIblG1ZKfqRVEwqIVTu19PoD24K/0rQDNJ5fkFnsza8emwbkJAPjb0tkCk+mu/r5vv Ql4koz6WqoJ1A== Received: from [10.193.1.1] (broslavsky.collaboradmins.com [68.183.210.73]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: usama.anjum) by madrid.collaboradmins.com (Postfix) with ESMTPSA id DA073378200D; Mon, 11 Mar 2024 17:09:47 +0000 (UTC) Message-ID: Date: Mon, 11 Mar 2024 22:10:21 +0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: Muhammad Usama Anjum , kernel@collabora.com, kernel-janitors@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kees Cook Subject: Re: [PATCH 1/3] selftests/exec: Add the overall result line accourding to TAP Content-Language: en-US To: Shuah Khan , Eric Biederman References: <20240304155928.1818928-1-usama.anjum@collabora.com> From: Muhammad Usama Anjum In-Reply-To: <20240304155928.1818928-1-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: B45E54002C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: b595gx44qki8kfmep8te1a9s546p5x6q X-HE-Tag: 1710176992-788332 X-HE-Meta: U2FsdGVkX197FVUvF1pMP1QKLk628MoN7jTDuPKAfLsresC6JQK30MfFoiI7/rZnG5wiSFksHgl29f1jqcsprAOJo8Z2KvajG9HDcEOx6Xpd1gP93RLMxqGEx1x2VR9WQHFBtJXp6PEiuMAXsbAAuRZ2JM+ivZ+etkigxglATg45rKZTBnBSJeRpVYQW9WRWz9880sIitzQpWHvckgc6rtMxLNJl6epI5YGn0OykH0TWI/hUdHwibQm66TG6TqyUOLCE6AHwuZ/KxFk629wR7in3LAJiXoNXp4V2OCOFZQ3CbmFHs7ASKlPUdtACP8ZpLMLvoWf1bZ2lDz0hHg4o21hxpu9Mj5aLTM+dmJW0yndzEw1agt6wz/0yr+9vl2qC+MRH1GOCtlHFRgJgI/2Fli1pLqWUVDZs0TqMbzYOX/cNG3mVlf9Ir1HD0rYaSwwLyeX2IorgjWM/SRM9uQbRea7Xz8YcPU0RtXTZeNlfJMLHFBAFu7OSvuaKzNZ0KRKw6r8n6o86BfxyObBwIZceQK9gJmKgCktCMgOKGZ0gkJG6nbZa3SWPo4gDpRz2HDmqRl0IG/sPTY4EBSCefRsLmx22airD0n4OqrPgYhBjjF7DYxVr0NHAuLmchrjTjW86TmJfrT4xaYlFGR10HWgmCOICF7b2dyfbQHc7TEF9l48Xqa6+rHuUid9lVvUOA1tcB3qF9dEMgp/YHm0pAj35i4QMFb3TaNuVIrJsnQ9SOn8v3Pf+LrTDv8x1W4yEIpEaAOX6PwReldxmDvmBFOfy15CWc7urPMCz8i57dat5VEUHjgLsGIX5Aqqe+d01ZvET9pZ3Nt6jQaKHVjmLyn8z+u4Ug2hKFQReo2UlAkrQOO9HNyc69j7nJPUvRM2zxjXGWnWOmeKnqNYMR81kjxadym6d6y2bAHqtTRrk8D1iCCgAxTb5VYZic/VAdPbAiMwi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Soft reminder! On 3/4/24 8:59 PM, Muhammad Usama Anjum wrote: > The following line is missing from the test's execution. Add it to make > it fully TAP conformant: > # Totals: pass:27 fail:0 xfail:0 xpass:0 skip:0 error:0 > > Signed-off-by: Muhammad Usama Anjum > --- > tools/testing/selftests/exec/binfmt_script.py | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/exec/binfmt_script.py b/tools/testing/selftests/exec/binfmt_script.py > index 05f94a741c7aa..2c575a2c0eab4 100755 > --- a/tools/testing/selftests/exec/binfmt_script.py > +++ b/tools/testing/selftests/exec/binfmt_script.py > @@ -16,6 +16,8 @@ SIZE=256 > NAME_MAX=int(subprocess.check_output(["getconf", "NAME_MAX", "."])) > > test_num=0 > +pass_num=0 > +fail_num=0 > > code='''#!/usr/bin/perl > print "Executed interpreter! Args:\n"; > @@ -42,7 +44,7 @@ foreach my $a (@ARGV) { > # ... > def test(name, size, good=True, leading="", root="./", target="/perl", > fill="A", arg="", newline="\n", hashbang="#!"): > - global test_num, tests, NAME_MAX > + global test_num, pass_num, fail_num, tests, NAME_MAX > test_num += 1 > if test_num > tests: > raise ValueError("more binfmt_script tests than expected! (want %d, expected %d)" > @@ -80,16 +82,20 @@ def test(name, size, good=True, leading="", root="./", target="/perl", > if good: > print("ok %d - binfmt_script %s (successful good exec)" > % (test_num, name)) > + pass_num += 1 > else: > print("not ok %d - binfmt_script %s succeeded when it should have failed" > % (test_num, name)) > + fail_num = 1 > else: > if good: > print("not ok %d - binfmt_script %s failed when it should have succeeded (rc:%d)" > % (test_num, name, proc.returncode)) > + fail_num = 1 > else: > print("ok %d - binfmt_script %s (correctly failed bad exec)" > % (test_num, name)) > + pass_num += 1 > > # Clean up crazy binaries > os.unlink(script) > @@ -166,6 +172,8 @@ test(name="two-under-trunc-arg", size=int(SIZE/2), arg=" ") > test(name="two-under-leading", size=int(SIZE/2), leading=" ") > test(name="two-under-lead-trunc-arg", size=int(SIZE/2), leading=" ", arg=" ") > > +print("# Totals: pass:%d fail:%d xfail:0 xpass:0 skip:0 error:0" % (pass_num, fail_num)) > + > if test_num != tests: > raise ValueError("fewer binfmt_script tests than expected! (ran %d, expected %d" > % (test_num, tests)) -- BR, Muhammad Usama Anjum