From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8722CC433DB for ; Thu, 4 Feb 2021 12:35:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D32564F3F for ; Thu, 4 Feb 2021 12:35:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D32564F3F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 919A76B006E; Thu, 4 Feb 2021 07:35:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8CB096B0070; Thu, 4 Feb 2021 07:35:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8070E6B0071; Thu, 4 Feb 2021 07:35:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0182.hostedemail.com [216.40.44.182]) by kanga.kvack.org (Postfix) with ESMTP id 6A11F6B006E for ; Thu, 4 Feb 2021 07:35:13 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2D5ED8249980 for ; Thu, 4 Feb 2021 12:35:13 +0000 (UTC) X-FDA: 77780530506.05.frame37_3b13bb0275dc Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin05.hostedemail.com (Postfix) with ESMTP id 1395418022D1D for ; Thu, 4 Feb 2021 12:35:13 +0000 (UTC) X-HE-Tag: frame37_3b13bb0275dc X-Filterd-Recvd-Size: 2921 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Feb 2021 12:35:12 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B58ABD6E; Thu, 4 Feb 2021 04:35:11 -0800 (PST) Received: from [10.37.8.15] (unknown [10.37.8.15]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B65A63F73B; Thu, 4 Feb 2021 04:35:08 -0800 (PST) Subject: Re: [PATCH 10/12] arm64: kasan: simplify and inline MTE functions To: Andrew Morton , Andrey Konovalov Cc: Catalin Marinas , Dmitry Vyukov , Alexander Potapenko , Marco Elver , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <17d6bef698d193f5fe0d8baee0e232a351e23a32.1612208222.git.andreyknvl@google.com> <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> From: Vincenzo Frascino Message-ID: Date: Thu, 4 Feb 2021 12:39:08 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210201144407.dd603ec4edcd589643654057@linux-foundation.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, On 2/1/21 10:44 PM, Andrew Morton wrote: > On Mon, 1 Feb 2021 20:43:34 +0100 Andrey Konovalov wrote: > >> This change provides a simpler implementation of mte_get_mem_tag(), >> mte_get_random_tag(), and mte_set_mem_tag_range(). >> >> Simplifications include removing system_supports_mte() checks as these >> functions are onlye called from KASAN runtime that had already checked >> system_supports_mte(). Besides that, size and address alignment checks >> are removed from mte_set_mem_tag_range(), as KASAN now does those. >> >> This change also moves these functions into the asm/mte-kasan.h header >> and implements mte_set_mem_tag_range() via inline assembly to avoid >> unnecessary functions calls. >> >> Co-developed-by: Vincenzo Frascino >> Signed-off-by: Andrey Konovalov > > Co-developed-by requires a Signed-off-by: as well. Vincenzo, please > send us one? > > I added my Signed-off-by to the patch. -- Regards, Vincenzo