From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28022C25B75 for ; Mon, 3 Jun 2024 15:27:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46106B008A; Mon, 3 Jun 2024 11:27:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F68B6B008C; Mon, 3 Jun 2024 11:27:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897BC6B0092; Mon, 3 Jun 2024 11:27:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6C56E6B008A for ; Mon, 3 Jun 2024 11:27:33 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1FDB61C1E28 for ; Mon, 3 Jun 2024 15:27:33 +0000 (UTC) X-FDA: 82189956786.13.9AF627E Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf23.hostedemail.com (Postfix) with ESMTP id C28EE140011 for ; Mon, 3 Jun 2024 15:27:30 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EdNOSRLT; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717428450; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ar9gzrik4rhckEVRPLbE8X2OcbLolgrz1g9vN29eeQg=; b=g398J2CH4Zojzmodh0ww4st7w7pfke/fmhyjO+NxmK3Hb/LcFX3ZcnjKGoWCtFZi3mmP+q 50t3FnfJdq4rCL/i2dbXMhd+m9DagBlOaIZbybGio8N//e3uZI9bA/EDeL+HgG3/SV7C2P 5zzqMdFe8QF08AIXnUOsNtw2jc6EWJI= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=EdNOSRLT; spf=pass (imf23.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717428450; a=rsa-sha256; cv=none; b=N0xhBuIbZSDOX1PCUTwZyuj9jD7daWhYeKqLeS32S22EpymItbD1jSA93RDdCdjmqUSbDu XqjQe/xVd9jXCxbamV3fAg1l0VkOg+VV2jrH6qKtwKNlVAjWg9oZ7bpf7UvX16gYVMm7Hh 7mdC2/K8Ic+q5eUiNVatZpPNe8h8knw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717428450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ar9gzrik4rhckEVRPLbE8X2OcbLolgrz1g9vN29eeQg=; b=EdNOSRLTXHpR2WgzKPKzBVgDP1sDOuDlmc79pwA8tGyZF9tf8Ct/ynZVUXu4y6q2ihurw6 jdDboKHDqiEsfNq4cxk4ebJoUUZ8RljIqxhRHl/hhfH/1ZDXTqLt4N2Qw7CYIPhF+5KYep P7TqgCb8Z5zZhEPTaOPESrFxgHfo/IA= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-77--KZCMA_HOmKGUY64h8EHEg-1; Mon, 03 Jun 2024 11:27:28 -0400 X-MC-Unique: -KZCMA_HOmKGUY64h8EHEg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4212a3ddb6bso26829265e9.2 for ; Mon, 03 Jun 2024 08:27:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717428447; x=1718033247; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ar9gzrik4rhckEVRPLbE8X2OcbLolgrz1g9vN29eeQg=; b=bnShV+HLbPGY3EHC31cI0fqmpuyBJFx1ukxSs1nROAUd5J2nuLGF77flPsrKs9/sxe NAo/JNI3cIU7Pgds6nBeMQoSMoxv4lmiSizfbDejJaly8XTO8koYzSEsiH+WlgOUrhBk 6qqwTTtlhcNUr1TaIy7u67JQ1eiyDbRvnjG+MvF1JWbIHx8i5Up/FlAm/zXnR/gHfgyW 5Er3qXJYzvlfevBGRcAepLiuLKDT7HosGpsC3cDZ7+JX1t90RkvNCaqlpiyalI3CeAiR nP9E1t0UovAKrxaljgNtM0JEUXL8xjV04AEGLZFgrbXzgKX+NVtuT1VqYdD6Cr3IiWn5 uqBw== X-Forwarded-Encrypted: i=1; AJvYcCWVviNp0SmKNfjMfHfdxYJ3EXK6oOvHNCMEte+KiWSeW4ArHpugseXTtqe8UxCBDDfFlptwY/Ke2yTnfp5o7Qug/8k= X-Gm-Message-State: AOJu0YwXR/p2mQ8W9v+MUNROs/byQov3i7hWbAQSUR0qtyfiYSYce3bN HtWr/+vj6Q0YnKO8i9jEK17v+wh6v8WxN02fyUiyb/C4f+r71pIfRgSwvQjbz8g3KT4Sa90j+kL +pIZ21jFsg5et3IjNkHbF98b0MCOrgluuqkQGJXnHbbrpkyDd X-Received: by 2002:a05:600c:3d8c:b0:420:fcd:10e0 with SMTP id 5b1f17b1804b1-4212e05dfa2mr72664675e9.15.1717428447504; Mon, 03 Jun 2024 08:27:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFpBRQbamqxXLfeZ0zqOXC87vSWhwtU762ZehParQC2zaOtREMaeN0/9mqa3qf0Xr6Fcsku9w== X-Received: by 2002:a05:600c:3d8c:b0:420:fcd:10e0 with SMTP id 5b1f17b1804b1-4212e05dfa2mr72664475e9.15.1717428447161; Mon, 03 Jun 2024 08:27:27 -0700 (PDT) Received: from ?IPV6:2a01:599:908:c963:af9b:c64c:dfd8:5999? ([2a01:599:908:c963:af9b:c64c:dfd8:5999]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4212b83d4e2sm121728565e9.2.2024.06.03.08.27.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 03 Jun 2024 08:27:26 -0700 (PDT) Message-ID: Date: Mon, 3 Jun 2024 17:27:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/1] mm/mlock: implement folio_mlock_step() using folio_pte_batch() To: Lance Yang Cc: Matthew Wilcox , akpm@linux-foundation.org, ryan.roberts@arm.com, 21cnbao@gmail.com, baolin.wang@linux.alibaba.com, ziy@nvidia.com, fengwei.yin@intel.com, ying.huang@intel.com, libang.li@antgroup.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240603140745.83880-1-ioworker0@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: ig5jejuy9jd3efnbymthxr6cwaqqs3y8 X-Rspamd-Queue-Id: C28EE140011 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717428450-436851 X-HE-Meta: U2FsdGVkX1+EQpr+vrCOLPRZxPDvSyxNRKR5rsHlHReZLAQXjqh7PGfyZzc4svlkWhISO1Y0I49JNJ+vImgNMG8P5gyeUkby6ycXNUmhv8GzE/2x7i8XmARHvt+ex6TLmlJI2TdrNPNeQTLAlrz4t0CYp1IIfi1PE6lxaPw9jteyLiEwgyWMJAA6EQx4m3yssUlQNuIHESW3cLAXN5Bg4Qq26Q28I3Of03rOMQt7oEYgIak6k6WHyJqACW2n4GTSTpc6uyc158g8HA658SQSpV97A6sd56wI0Nu/B5aLZcGk0Id0YkvrvUtcaBHDLF+PGkQal/WkQqkcbBlwZvRpV4NsQEx1CgLiiGfvcCyodaHEb0ATvE2zKNkufO+YBk1sJo0vcpZc/qR/p8jj2RcYjj3F5QfO7MxiT9Na3M3QugEHgH8Me+0gZHj2Z/O7WVv+4kStw6IrAqmxdmsuC74VBrksJPtwc3v2zJa77D7PDQB/OgVqakLgHP+yJPVOHrAXjZEwuI6GZsPIXleLNVCSUhmHvN5UPEIH28iTBP8pMzelEsLpJGVmWYFyKHscG53X5FFk3DkfddMnTR/Kb553PgZqSIrDX2m2zKpSpL5Yim7Ccs3R3gAMqAzq/TA5sQiThiC8Bh9EbT4LKYudldhPBUVyWP26cz+ni/vTGuIGVVrB7cNG0IukHs7mcPKZhYXaC5RTdltmzz2lyu1gn3GOQz8qn0hDDtwRXFhyvrGBFNM5grG6yzgXQ+JsWlAT1G6QkcHWM1jG+w2i2TVRGa+pYSTYH22DZr5zquNLG+AlpotqvitbjviNwvnA2gfCyiNXnZE86yCkiY0mLzEK9zdx6WknHWhQhNLpMlsToADyIrWD985sykg0Udz+czKngvp8b7nPWGThvHeDtjWofEcBIbUYS90AfoiJSM8RMyY/Vgwad+01UzacuBHgn2IAMolSpjx/wKukmFNsGoJ/By5 qYMubY4h 5PTVRlJVS8IrZLGKAoGgtARBTTe7RUyolDosFt3M5549jlcL8WRTt6jVDyJTMcaiU+5/F13DY/NgLJnp/ijxBQ+UFfuZq91/zWS9+1AGKRPkYPrrgUIPzRszlgCnetcjKUq05An7bwe3HynulSQuvDlYSK1aHA/3jBdE4NmljDbutaDTBXCiziFWmFkLU/sNLEA6icFEsfHDoVXvGbNxZAOICtLFPOlLo57fBloSsGkOOogTk21zY/WlF7JEZ/cBUCoC4MOWwIUfIOKliWwO3pwCvAxPDzSFmOx39l6aM9bqF9tSndz8cxvJXJuqM8pe2gVaXtaugsojFkqk02aB7HRMQfV9oIXaMDzHYd2el6X+CpYDp8vrUNoFmw8UNzM3JCAvXcrpK1HicnPgKyWwmWFu+tPpF9Ik719/b2ea6c0rkpV2SnvivibJCG3bNI7q3tuqpa78KDuJfHmZib3YWuCkJ/2JqW0IQkp6OTFZ/KHqwnM6ZDWn7HuCQD1sA9k79kF37+1KV8AifX9tXDtdnmzYxz+2XG0ntKfmj9iRsYF2Qm9rJkJXr9agI8XOdmvkDMMskfaorlYfDOAeGT5fvaj7KfA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 03.06.24 17:08, Lance Yang wrote: > On Mon, Jun 3, 2024 at 10:56 PM David Hildenbrand wrote: >> >> On 03.06.24 16:43, Matthew Wilcox wrote: >>> On Mon, Jun 03, 2024 at 10:07:45PM +0800, Lance Yang wrote: >>>> +++ b/mm/mlock.c >>>> @@ -307,26 +307,15 @@ void munlock_folio(struct folio *folio) >>>> static inline unsigned int folio_mlock_step(struct folio *folio, >>>> pte_t *pte, unsigned long addr, unsigned long end) >>>> { >>>> - unsigned int count, i, nr = folio_nr_pages(folio); >>>> - unsigned long pfn = folio_pfn(folio); >>>> + const fpb_t fpb_flags = FPB_IGNORE_DIRTY | FPB_IGNORE_SOFT_DIRTY; >>>> + unsigned int count = (end - addr) >> PAGE_SHIFT; >>> >>> This is a pre-existing bug, but ... what happens if you're on a 64-bit >>> system and you mlock() a range that is exactly 2^44 bytes? Seems to me >>> that count becomes 0. Why not use an unsigned long here and avoid the >>> problem entirely? >>> >>> folio_pte_batch() also needs to take an unsigned long max_nr in that >>> case, because you aren't restricting it to folio_nr_pages(). >> >> Yeah, likely we should also take a look at other folio_pte_batch() users >> like copy_present_ptes() that pass the count as an int. Nothing should >> really be broken, but we might not batch as much as we could, which is >> unfortunate. > > Could I change folio_pte_batch() to take an unsigned long max_nr? It might be more future proof; see my other mail, I think currently all is fine, because "end" is not the end of the VMA but the end of the PMD. Please double-check. -- Cheers, David / dhildenb