From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1D14C4167D for ; Thu, 2 Nov 2023 11:45:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F29E580020; Thu, 2 Nov 2023 07:45:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED9AF8D000F; Thu, 2 Nov 2023 07:45:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DA14D80020; Thu, 2 Nov 2023 07:45:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7E728D000F for ; Thu, 2 Nov 2023 07:45:46 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 97D331603C6 for ; Thu, 2 Nov 2023 11:45:46 +0000 (UTC) X-FDA: 81412834692.20.1DCEB45 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf03.hostedemail.com (Postfix) with ESMTP id 8847320005 for ; Thu, 2 Nov 2023 11:45:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698925544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZKj7NoLATX5Lay+q4AA85Fj7gMXiCVXqFk193V95DOw=; b=4EclHCkuR4g9X/voHZUXSCvtzEzRNTWQYDE5BmaG0VEfukhaqzIFDiZEqjFg1h9w9XdXmK l8xEcSINT1jde+DdmpzjsrVG3tUvcgOPWpRc+2FXWrOsN02Mz4c7vtYHiV/G1u5OdE2jBF kO0T/saYkRPbGEQPgnK3Y6vbvJkrnBM= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf03.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698925544; a=rsa-sha256; cv=none; b=OyeVoKrV/QO7oFoTnSkJZ93oTvzRLNT4Be+mx5JC/5NnUu4dDQ7Mo43JtoBaF9jq0Vomlk jIsXX1H/uNnZpP6bpAaC/p9hY+TE6HaW/fV1V0UXv7j+YGblIES+9kR1IQ/9ZehzypPZ4Y 07UuJ5t2EXssApKuWewIBnMbu9F2YXU= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99B702F4; Thu, 2 Nov 2023 04:46:25 -0700 (PDT) Received: from [10.1.33.173] (XHFQ2J9959.cambridge.arm.com [10.1.33.173]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DD83A3F67D; Thu, 2 Nov 2023 04:45:38 -0700 (PDT) Message-ID: Date: Thu, 2 Nov 2023 11:45:37 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v33 6/6] selftests: mm: add pagemap ioctl tests Content-Language: en-GB To: Muhammad Usama Anjum , Peter Xu , Andrew Morton , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman Cc: Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com, Cyrill Gorcunov , Mike Rapoport , Nadav Amit , David Hildenbrand References: <20230821141518.870589-1-usama.anjum@collabora.com> <20230821141518.870589-7-usama.anjum@collabora.com> From: Ryan Roberts In-Reply-To: <20230821141518.870589-7-usama.anjum@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 8847320005 X-Stat-Signature: b8p1zbdmzt1ncmtfj4egymesd9hxzeq3 X-Rspam-User: X-HE-Tag: 1698925544-604492 X-HE-Meta: U2FsdGVkX19Sxc6lX2lNPqTlfrJDfRJKnyWHxAkhmdEUau8JnSDoB/vM0HwrMT6voOgaXBWuB9HbKiB/IUEcMqf5N1JU2Sc3hJB1zDeVLF3QJtjTdGFf6UwoI8T5hwMB14OOemvuEZ3pm158E8ZbiaJKENfF1Wh6oaTGeYeRfIFcbS3+JUXZ0IG3QpAPSYl63ojyiATP4O2PZ1SksniCHR8UyW6cXIwoFQfbglgNFA/Mw2NJ4awDb+Mp47ailcmsaZwMZKC/x24cfO8FV23CVBwklEcq88BPvSIJgi0yqWyy5cZMs7DMEWHE7Rjglr3CgYAD45BmtzHHs9xuQi+8+R+P0gK9KHFg5zFRKsJHo0NumBXBEssR6NzfcHFRMtxXMSpk3aJJrDftRBqJA7JnOzYlnnnctyIf9RCJBzfQB+ohThBBMsZq37LqFSqZm1RhRsN+b65cZdKhDFnX7WBHJEiPDtxp9dZ8nFm9vigen2bFaFQcGSPYXexHzS2hQBJ0jlcMrMWDbBnOBMraD68qWitYVLigOpmC9sgGGByuAymR11IsfQvzb+rB6NIn2b5ppVlOtOVK7udb1IY8lR7LFek4dCKpWOpagiwzR5VXUBIp8UrSXUm6AaSjhygep3u0JvTW/uCzu/8ykWuwrZ6gmLwsqDbI2iYDH9AXg4Sbnk40ub5DUBvVe2vjZVLzL3JCfePkKvuPmYwgSs1sO5KboXl061L0/ONqi9J8McfGXGgzeNsrtExoNUerL/+7hY3zwkFG/zUds4kDJJB6zUBBWRJsB6/vj6BLDOMIXlsDOr+rxvAxt34RNpLB617BBNct6c8UmzjgGNFHmtu2vbKfWSOFibRqMg1Y0ELi4sLU4hpLzPOGCNy6HEy1kx1o6yFaYeAu7o/7b9juPfKO6RyvHA5YMPEmMCU41wvuGayT4gKmJu5ZSRsurQRiWrPblleIOwApsajgGuAd2l9Skl6 VE8/7eKQ Ne1lviPyeqyMtERhZzQN5UnWDGHQdRrL+GlL22ICI+B1itRwQ/gaz/jglZ9jax3JJXtonXfw5kRGPwgD1urwz9brWTtYEC+FAX8YgpL6abFWjrSTojVimqEiMSahgIIbiokSjlNzdNuHgC5exSvvvMe9/Ug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 21/08/2023 15:15, Muhammad Usama Anjum wrote: [...] > + > + > +int init_uffd(void) > +{ > + struct uffdio_api uffdio_api; > + > + uffd = syscall(__NR_userfaultfd, O_CLOEXEC | O_NONBLOCK | UFFD_USER_MODE_ONLY); > + if (uffd == -1) > + ksft_exit_fail_msg("uffd syscall failed\n"); > + > + uffdio_api.api = UFFD_API; > + uffdio_api.features = UFFD_FEATURE_WP_UNPOPULATED | UFFD_FEATURE_WP_ASYNC | > + UFFD_FEATURE_WP_HUGETLBFS_SHMEM; > + if (ioctl(uffd, UFFDIO_API, &uffdio_api)) > + ksft_exit_fail_msg("UFFDIO_API\n"); > + > + if (!(uffdio_api.api & UFFDIO_REGISTER_MODE_WP) || > + !(uffdio_api.features & UFFD_FEATURE_WP_UNPOPULATED) || > + !(uffdio_api.features & UFFD_FEATURE_WP_ASYNC) || > + !(uffdio_api.features & UFFD_FEATURE_WP_HUGETLBFS_SHMEM)) > + ksft_exit_fail_msg("UFFDIO_API error %llu\n", uffdio_api.api); Hi, I've just noticed that this fails on arm64 because the required features are not available. It's common practice to skip instead of fail for this sort of condition (and that's how all the other uffd tests work). The current fail approach creates noise in our CI. I see this is already in mm-stable so perhaps we can add a patch to fix on top? Thanks, Ryan