From: David Hildenbrand <david@redhat.com>
To: Zi Yan <ziy@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Cc: "Huang, Ying" <ying.huang@intel.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] memory tiering: introduce folio_use_access_time() check
Date: Wed, 24 Jul 2024 16:13:17 +0200 [thread overview]
Message-ID: <f82d58f6-4549-4f74-9bd1-0507d2e1afc1@redhat.com> (raw)
In-Reply-To: <20240724130115.793641-3-ziy@nvidia.com>
On 24.07.24 15:01, Zi Yan wrote:
> If memory tiering mode is on and a folio is not in the top tier memory,
> folio's cpupid field is repurposed to store page access time. Instead of
> an open coded check, use a function to encapsulate the check.
>
> Signed-off-by: Zi Yan <ziy@nvidia.com>
> Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
> Acked-by: David Hildenbrand <david@redhat.com>
> ---
Yes, that is much clearer, thanks!
--
Cheers,
David / dhildenb
next prev parent reply other threads:[~2024-07-24 14:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 13:01 [PATCH v3 0/3] Various memory tiering fixes Zi Yan
2024-07-24 13:01 ` [PATCH v3 1/3] memory tiering: read last_cpupid correctly in do_huge_pmd_numa_page() Zi Yan
2024-07-24 13:01 ` [PATCH v3 2/3] memory tiering: introduce folio_use_access_time() check Zi Yan
2024-07-24 14:13 ` David Hildenbrand [this message]
2024-07-25 1:01 ` Kefeng Wang
2024-07-24 13:01 ` [PATCH v3 3/3] memory tiering: count PGPROMOTE_SUCCESS when mem tiering is enabled Zi Yan
2024-07-24 14:14 ` David Hildenbrand
2024-07-25 1:00 ` Kefeng Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f82d58f6-4549-4f74-9bd1-0507d2e1afc1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=wangkefeng.wang@huawei.com \
--cc=ying.huang@intel.com \
--cc=ziy@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox