From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF976CF9C72 for ; Mon, 23 Sep 2024 16:54:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BA6F6B0089; Mon, 23 Sep 2024 12:54:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 56AC86B008A; Mon, 23 Sep 2024 12:54:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40B306B008C; Mon, 23 Sep 2024 12:54:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 1D61B6B0089 for ; Mon, 23 Sep 2024 12:54:49 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C79E9AC528 for ; Mon, 23 Sep 2024 16:54:48 +0000 (UTC) X-FDA: 82596602256.19.D60AFCC Received: from fout-a8-smtp.messagingengine.com (fout-a8-smtp.messagingengine.com [103.168.172.151]) by imf27.hostedemail.com (Postfix) with ESMTP id 972144000A for ; Mon, 23 Sep 2024 16:54:45 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=qUUNPVBI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="C hdCSZL"; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1727110367; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kR6thF4mL5TK/tahzSYtD/0ZIm7FZeNAgdWnaPLLR6o=; b=b9WYxpfa5K+XiRO/cum7aGWsSkLOGX7t6mZiuUjONMjyHTLzFGrxKJ5eNejMmU02gfbnkn ZgMPzqyJSVssI2hp1KPaLPauAzjVOAC1+gKLLBHzTPjLDji35teu0hFGet+fC/RhNchcV6 lUKyO8wrbrgpv7AW5Hyq1SSOQXt/QCU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1727110367; a=rsa-sha256; cv=none; b=Yf+A5iDGq1PM6Ys+6mp9/2wlyWLjZ5p2WPFqquAsHKeGGMGi5WGdyrYtlkfU4Q10nT2dpO U2uKBmwbJ4u0yMkcq1LZdnHH5tHAc87jQrJw3AV8tCaV/tmZNBBW497tAO7srZ6yeYg+oO AZj1Ysi92X92fQsMj118Ncm9sJnJ8FA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm1 header.b=qUUNPVBI; dkim=pass header.d=messagingengine.com header.s=fm2 header.b="C hdCSZL"; spf=pass (imf27.hostedemail.com: domain of arnd@arndb.de designates 103.168.172.151 as permitted sender) smtp.mailfrom=arnd@arndb.de; dmarc=pass (policy=none) header.from=arndb.de Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfout.phl.internal (Postfix) with ESMTP id CFFC71380245; Mon, 23 Sep 2024 12:54:44 -0400 (EDT) Received: from phl-imap-11 ([10.202.2.101]) by phl-compute-10.internal (MEProxy); Mon, 23 Sep 2024 12:54:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1727110484; x=1727196884; bh=kR6thF4mL5TK/tahzSYtD/0ZIm7FZeNAgdWnaPLLR6o=; b= qUUNPVBI9mFPBCOSguUktHvjsdT8BY7n0jAdIZ0kOHkkPQEeyWzbHrR6BqDbGwOb dy9cuUrnVFMr1OqueC5F2NWuvjMfX6ifm/M6rrUQIZcCvxDCFraGQKTUu+Xgtt7E vbPxt0i9oYBGANmO48vMGlLFurn2BL8dBS7a7Mo2Dpn7arMRdfNkQDS+v0vS515P Sl1Ofajg0dPZQaup9tc8u1FESR6yaCruxX84Oi394F9vqN6h8LYoJ+VT20s88OY6 LAZHrgUmu8BTSgBE0MFv8Gpoyt3FBtvyA7PmhVzWuIecetV9Q17oCj0VYUNU2dwP TWbDLmy6Wwx75Zbzxi19cw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1727110484; x= 1727196884; bh=kR6thF4mL5TK/tahzSYtD/0ZIm7FZeNAgdWnaPLLR6o=; b=C hdCSZLl2aZhq7L29NuYRMd+ymOY1Gh9MtMw4atgeDTAMi6/Ggu+KQIPl7sncv7Na 30JjwJWsLlfl4MELF+2JFVOQapzcWGp11VpYpXBIDdJahtYbPmf8pSVIsdxT8Put YmqrxKF220y3X8ddvuLAo0s98/UhXLVm6BS3/TQP/otW+IL1WIu+yRordXNWdQ3O 7ZA13Z/U7z3PW6DWKuoVM1rLPtoQ+SJbYokPrsmbRzdtBcXiVLjAVJQGkIDhb36+ 0FfMI5x+PNuklgmKAHbu/NaFiLaNvJwReXSMp/J9dNRL94QJL918+OcSx/UcW6oC e/4xsiZVFnns8FiMEFlaA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudelledguddtjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefoggffhffvvefkjghfufgtgfesthejredtredt tdenucfhrhhomhepfdetrhhnugcuuegvrhhgmhgrnhhnfdcuoegrrhhnugesrghrnhgusg druggvqeenucggtffrrghtthgvrhhnpefhtdfhvddtfeehudekteeggffghfejgeegteef gffgvedugeduveelvdekhfdvieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpegrrhhnugesrghrnhgusgdruggvpdhnsggprhgtphhtthhopedv tddpmhhouggvpehsmhhtphhouhhtpdhrtghpthhtohepsghpsegrlhhivghnkedruggvpd hrtghpthhtohepvhhinhgtvghniihordhfrhgrshgtihhnohesrghrmhdrtghomhdprhgt phhtthhopegthhhrihhsthhophhhvgdrlhgvrhhohiestghsghhrohhuphdrvghupdhrtg hpthhtohepmhgrthhhihgvuhdruggvshhnohihvghrshesvghffhhitghiohhsrdgtohhm pdhrtghpthhtohepmhhpvgesvghllhgvrhhmrghnrdhiugdrrghupdhrtghpthhtohepnh hpihhgghhinhesghhmrghilhdrtghomhdprhgtphhtthhopehrohhsthgvughtsehgohho ughmihhsrdhorhhgpdhrtghpthhtoheplhhuthhosehkvghrnhgvlhdrohhrghdprhgtph htthhopehmhhhirhgrmhgrtheskhgvrhhnvghlrdhorhhg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id 2F95A2220071; Mon, 23 Sep 2024 12:54:43 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface MIME-Version: 1.0 Date: Mon, 23 Sep 2024 16:54:22 +0000 From: "Arnd Bergmann" To: "Vincenzo Frascino" , linux-kernel@vger.kernel.org, Linux-Arch , linux-mm@kvack.org Cc: "Andy Lutomirski" , "Thomas Gleixner" , "Jason A . Donenfeld" , "Christophe Leroy" , "Michael Ellerman" , "Nicholas Piggin" , "Naveen N Rao" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Theodore Ts'o" , "Andrew Morton" , "Steven Rostedt" , "Masami Hiramatsu" , "Mathieu Desnoyers" Message-Id: In-Reply-To: <20240923141943.133551-5-vincenzo.frascino@arm.com> References: <20240923141943.133551-1-vincenzo.frascino@arm.com> <20240923141943.133551-5-vincenzo.frascino@arm.com> Subject: Re: [PATCH v2 4/8] vdso: Introduce vdso/page.h Content-Type: text/plain Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 972144000A X-Stat-Signature: ot9p1g49p84abdk74azanoxz379n9ycb X-HE-Tag: 1727110485-635901 X-HE-Meta: U2FsdGVkX19DLPbFiJ6xHdnoTVj1yZhmIPRh81Am8G1khL4ARNM87niGxxvGDPS4crCQqdAc+Poy3St3+Bt7s3MkU1tR5TvOBct0zl7lPNW6q9eUKVEOwkUluzXSo4XglKsbkVAuO6Hpm01IyzOVawIIM+pN1gQ0m/9TRek1SLBOZ+DGIKvYdHNShovKzOGnO8eaAhyTqX4Qyzadyo7ClhscmQ3Q6lACJhwcMbEeASzuC9lALFfMqi68E3kHqxNPfbxel4fQMZYA9sgEgLkDmxf1xruynfPz86cB6r7Urlf8p+Il/yS6j3NhSzcWypcW2llBGJ6JkKdB/vr9tv0aQ82t6LV09WlNv/Gx90UpmDh7GSvNZS4VvTe1OfjudSVPV7yUkZpbvAJli9py751LhdqsY6ImpQlzmYK38Ag95Wc92KHSz9jitOgfgvVyrNSzW+Pp/+Ytv7C0sm85yO/Q00g/IR/iBYHZPZwgNedcbz05VpzL1atW5C//ikxh1zgkW377tjzfhEx7M6Er09p6EDC7Hb/2W+kmAzpO4LBGqUwifyL5ZiEjpMG+5TYZYKolMKW+f/WNAL2KbVwyCxjhVUrTu57pVxo50SOGIKPrte+1g7LBD93S7SQPmoGYTuxi2Z9Ls48BMTeFPaWM93505SCAoER7ELv32W9COrS18767HgGv7+YfVWnxyNDgblGGM7bIeXrKHanMxsCmM4rIm72ydDu28/zU9He50ZXeiF7aqoLqEK+au/ry8OC8uRK5zbLKi+y/cEhhN3c4FrCI0IMlai+rGEZ1OZvEDz7p1jooN8w1WR1JQt9BvUJRFG/nV0d3eEvpUDMePpUz1JcpIovS0qTVuFXH0sVt9ZYgM0UpBWdR7ysikd0m2AqJsHP3AXD0a+uiSGWJB3F8NT2uxlK4TAj2LVGIJ9s30b94JZTcXar8TMUSMA+KbKgIt1CyMmqUk9iXaLTfRTS297b CAtBv9Vh TeTtl+eC2CenFXqUqA/rhVdnF1Svynz2+iicr+vfSiNjfRT1P8YX3b9fp6Ypazpo+k91OL3er8miy4qnGQwrg/IK1wTO6GVRTihIM4JPKCCZv7jeB500Oaycw9qnJUl95fdzDnBOHKqzkPDqXp4qhZPzt8HRZLA16hX9wmwfgyrKcOvHMENTw0P8VbXkNSFkKYc8jxH3seyq97CWDBs0qDYOK9EuCw4EGiTWl78bN4t4Wnq2Lf6iwBpCOJIHMkbdmtt54ut+gt7iWnrA65BWAxjX4OhVTwgkOCpR3CRqPFIcsO0Z9nSAtaGGls6A/215qVEwDqI4u4EjtQuc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 23, 2024, at 14:19, Vincenzo Frascino wrote: > The VDSO implementation includes headers from outside of the > vdso/ namespace. > > Introduce vdso/page.h to make sure that the generic library > uses only the allowed namespace. > > Cc: Andy Lutomirski > Cc: Thomas Gleixner > Cc: Jason A. Donenfeld > Signed-off-by: Vincenzo Frascino Thanks for the new version. This looks all good, just some very minor ideas for how to possibly improve the new version: > +/* PAGE_SHIFT determines the page size */ > +#define PAGE_SHIFT CONFIG_PAGE_SHIFT > + > +#define PAGE_SIZE (_AC(1,UL) << PAGE_SHIFT) > + > +#if defined(CONFIG_PHYS_ADDR_T_64BIT) && !defined(CONFIG_X86_64) > +#define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) > +#else > +#define PAGE_MASK (~(PAGE_SIZE-1)) > +#endif I would open-code the CONFIG_PAGE_SHIFT in PAGE_SIZE and PAGE_MASK, just to avoid the extra indirection in the preprocessor. This mainly has the benefit of slightly shorter compiler warnings when all the macros get traced back but can also slightly improve compile speed in case this is used in deeply nested macros. Without a comment, the special case for CONFIG_X86_64 not very clear, and probably not needed. If you are worried about introducing an architecture specific regression, I would suggest instead explaining the possible issue in the patch description but using the more generic and simpler #ifdef check. Arnd