From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9915C48BC4 for ; Tue, 20 Feb 2024 07:43:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6E6376B0087; Tue, 20 Feb 2024 02:43:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 696A36B0089; Tue, 20 Feb 2024 02:43:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55E706B008A; Tue, 20 Feb 2024 02:43:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4774D6B0087 for ; Tue, 20 Feb 2024 02:43:05 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 186641A0556 for ; Tue, 20 Feb 2024 07:43:05 +0000 (UTC) X-FDA: 81811391130.23.073BDCA Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id E1EC4100005 for ; Tue, 20 Feb 2024 07:43:02 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nM4aQe9A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xxj75LFW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nM4aQe9A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xxj75LFW; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708414983; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YP75gQ+KuAUWIsBrrfVvGIwpBE4lZR/yaSnCbNK3JAo=; b=yBDSrnie84d8NdVXXDAEmMutyO2TSLsuVMlxEBVkA/yG/4r+P1FBXiE+2zSYFYwqUEoL68 6oWOWVzbL8cHpgrDVwuvstUkLx1fUtrpQxGSuqX4NubIOkX4MoA3hc5nFelAryjQPchEhx Re0juYAX+LZgg4FioB6mpoUoCRwEpvc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nM4aQe9A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xxj75LFW; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=nM4aQe9A; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=Xxj75LFW; dmarc=none; spf=pass (imf14.hostedemail.com: domain of vbabka@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708414983; a=rsa-sha256; cv=none; b=RZGr4+fyNayejkphynuscM12ajAsuVShEhayIg/Rt2a4tzRJ4IiWgdpD31gc3mSpJiulEl oKTQ5KGgGX/6GokmRQmLyqpJUP9aq4idL18I4530zDMEtY0aYEWwO+XDp6Y6YX1l8RWrj4 LPwO2c+eWpWY3M8UriOG9Pn1Wlf5OKw= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1C22A21E83; Tue, 20 Feb 2024 07:43:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708414981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YP75gQ+KuAUWIsBrrfVvGIwpBE4lZR/yaSnCbNK3JAo=; b=nM4aQe9AUG8OB1eQInkY9Ey1DsyWYVDk188d6SvNNIgHsMFwsMVFV/MlTT+VWvxhX2+Sw5 WRlyzHHj0HD090JpMzTpZ4Hu2rG6F6aAQvrxSKMuSV+lqTkZqxQDTnbC7dINm+3BasLuim 8Vs5hjK9pKxdg/GIzHgCcwRTl++1lh4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708414981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YP75gQ+KuAUWIsBrrfVvGIwpBE4lZR/yaSnCbNK3JAo=; b=Xxj75LFWc7tNaXnTr/HSZprPWtodjUnliFQX2qfQfv7XVJM4g6gsvO5QLb2fPQFULR4Yvd /p4S2vmzdSK1zUBQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1708414981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YP75gQ+KuAUWIsBrrfVvGIwpBE4lZR/yaSnCbNK3JAo=; b=nM4aQe9AUG8OB1eQInkY9Ey1DsyWYVDk188d6SvNNIgHsMFwsMVFV/MlTT+VWvxhX2+Sw5 WRlyzHHj0HD090JpMzTpZ4Hu2rG6F6aAQvrxSKMuSV+lqTkZqxQDTnbC7dINm+3BasLuim 8Vs5hjK9pKxdg/GIzHgCcwRTl++1lh4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1708414981; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YP75gQ+KuAUWIsBrrfVvGIwpBE4lZR/yaSnCbNK3JAo=; b=Xxj75LFWc7tNaXnTr/HSZprPWtodjUnliFQX2qfQfv7XVJM4g6gsvO5QLb2fPQFULR4Yvd /p4S2vmzdSK1zUBQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D05BC134E4; Tue, 20 Feb 2024 07:43:00 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id DTs8MQRY1GVrSgAAD6G6ig (envelope-from ); Tue, 20 Feb 2024 07:43:00 +0000 Message-ID: Date: Tue, 20 Feb 2024 08:43:00 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] mm: compaction: update the cc->nr_migratepages when allocating or freeing the freepages To: Baolin Wang , akpm@linux-foundation.org Cc: mgorman@techsingularity.net, ziy@nvidia.com, rostedt@goodmis.org, mhiramat@kernel.org, mathieu.desnoyers@efficios.com, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org References: <6440493f18da82298152b6305d6b41c2962a3ce6.1708409245.git.baolin.wang@linux.alibaba.com> Content-Language: en-US From: Vlastimil Babka In-Reply-To: <6440493f18da82298152b6305d6b41c2962a3ce6.1708409245.git.baolin.wang@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E1EC4100005 X-Stat-Signature: pezqacktaq7hks9pszwwna413absa8t6 X-Rspam-User: X-HE-Tag: 1708414982-283726 X-HE-Meta: U2FsdGVkX1/c2cZnz+hX5ifASUBbwvUdVrvRf+iDr2CPCW19TNEVWzbi7W5sh/PDYjtQ87GTj7fjOlbYd+rdBytNg+14hNZWKufwBykNZP4E0NemkA6M9QzB05RXFfNzHVhHSbpY5Se6lBKXek8PErKf46yb0THgQ7Z3jmsIvf0AlEDzhlIzhtXGYTHxPUOPbeoOQDn7LkykS39XYKl5PQq+vyLRg776AVnv3mnC1Nb4wTWG5jcgx9ixIYwwVFYhvOtE3ys1EwQQp+HNx4Db4m9+QV53SFM3ZVOo51fOu7m2yU0RSiEfwA7VbAeMaQMEJdIqyIAOi0SCwno6rHKp03r2K+h3ia6puse1AST/NgRqwPFKqQNpyzD0hRjAzWYe650x7HtoXZejN9TQ4cz5FiuhoRe/bS6ABT7GvmeZ4n3mTiElh3zfnLZKqMLMcokpB5xmYHPvlEA5dC+yFbJ9y4+/VY4LJCbnNAjosWXoGotNWcw4yhftnDO4C4SRIG1EgxAurxd6u0gX+ysoPfOoIbxq5eb2zHk2tE8UiyYuwwfxZz5imkqT2xK675cEuhm2FW4T7FFmibdRb5tvUHVtVc1SI4mjR5SvxT7jUZEiwpF5uq0/3gyb8ZcNxBKwygyP+uXu14/5IGRoTiRwEH29nvjOIVA/u8IBdGjFPnMj47IYbplfDdzB7QSRIdFnYQ58D3qK3MWdupbRqsRG+HA/WVsyKWiLgNZlL8W/Ypv8o2PtDFaMXLME3JvF/UGOYz2J4U4Nm53xXk5oLHYERY5yQrTXr786mpI2ocprbZSZYQqAN43U8/yu0ybDKyOH/YxBncCW1KoLJEZB/JjuwcS+LibWKgNvF2Fqybc0PNRQJgn0eWVxv/0ebE3JQD2zFSWwiNaaA7gE85lNDZH1/PnMEfZmlcBZ7SAcg1jHdT2Wij6tNrmjqYdCsJcNqz0CbvRfVGfU3ZsuEd/VFrKaYBl snpudVRP hOf85SLxUN2K8TWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/20/24 07:16, Baolin Wang wrote: > Currently we will use 'cc->nr_freepages >= cc->nr_migratepages' comparison > to ensure that enough freepages are isolated in isolate_freepages(), however > it just decreases the cc->nr_freepages without updating cc->nr_migratepages > in compaction_alloc(), which will waste more CPU cycles and cause too many > freepages to be isolated. > > So we should also update the cc->nr_migratepages when allocating or freeing > the freepages to avoid isolating excess freepages. And I can see fewer free > pages are scanned and isolated when running thpcompact on my Arm64 server: > k6.7 k6.7_patched > Ops Compaction pages isolated 120692036.00 118160797.00 > Ops Compaction migrate scanned 131210329.00 154093268.00 > Ops Compaction free scanned 1090587971.00 1080632536.00 > Ops Compact scan efficiency 12.03 14.26 > > Moreover, I did not see an obvious latency improvements, this is likely because > isolating freepages is not the bottleneck in the thpcompact test case. > k6.7 k6.7_patched > Amean fault-both-1 1089.76 ( 0.00%) 1080.16 * 0.88%* > Amean fault-both-3 1616.48 ( 0.00%) 1636.65 * -1.25%* > Amean fault-both-5 2266.66 ( 0.00%) 2219.20 * 2.09%* > Amean fault-both-7 2909.84 ( 0.00%) 2801.90 * 3.71%* > Amean fault-both-12 4861.26 ( 0.00%) 4733.25 * 2.63%* > Amean fault-both-18 7351.11 ( 0.00%) 6950.51 * 5.45%* > Amean fault-both-24 9059.30 ( 0.00%) 9159.99 * -1.11%* > Amean fault-both-30 10685.68 ( 0.00%) 11399.02 * -6.68%* > > Signed-off-by: Baolin Wang > Acked-by: Mel Gorman Reviewed-by: Vlastimil Babka Thanks. > --- > Hi Andrew, please use this patch to replace below 2 old patches. Thanks. > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-20-04-19&id=cb30899d456d64fb83ee3e3d95cd9fbb18735d87 > https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git/commit/?h=mm-everything-2024-02-20-04-19&id=65713d1c4fc498d35dc1f7c1234ef815aa128429 > > Changes from v2: > - Add acked tag from Mel. > - Fix the mm_compaction_migratepages trace event. > Changes from v1: > - Rebased on the latest mm-unstable branch. > --- > include/trace/events/compaction.h | 6 +++--- > mm/compaction.c | 12 ++++++++++-- > 2 files changed, 13 insertions(+), 5 deletions(-) > > diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h > index 2b2a975efd20..d05759d18538 100644 > --- a/include/trace/events/compaction.h > +++ b/include/trace/events/compaction.h > @@ -78,10 +78,10 @@ DEFINE_EVENT(mm_compaction_isolate_template, mm_compaction_fast_isolate_freepage > #ifdef CONFIG_COMPACTION > TRACE_EVENT(mm_compaction_migratepages, > > - TP_PROTO(struct compact_control *cc, > + TP_PROTO(unsigned int nr_migratepages, > unsigned int nr_succeeded), > > - TP_ARGS(cc, nr_succeeded), > + TP_ARGS(nr_migratepages, nr_succeeded), > > TP_STRUCT__entry( > __field(unsigned long, nr_migrated) > @@ -90,7 +90,7 @@ TRACE_EVENT(mm_compaction_migratepages, > > TP_fast_assign( > __entry->nr_migrated = nr_succeeded; > - __entry->nr_failed = cc->nr_migratepages - nr_succeeded; > + __entry->nr_failed = nr_migratepages - nr_succeeded; > ), > > TP_printk("nr_migrated=%lu nr_failed=%lu", > diff --git a/mm/compaction.c b/mm/compaction.c > index 4494b2914386..218089b29f13 100644 > --- a/mm/compaction.c > +++ b/mm/compaction.c > @@ -1798,6 +1798,7 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) > dst = list_entry(cc->freepages.next, struct folio, lru); > list_del(&dst->lru); > cc->nr_freepages--; > + cc->nr_migratepages--; > > return dst; > } > @@ -1813,6 +1814,7 @@ static void compaction_free(struct folio *dst, unsigned long data) > > list_add(&dst->lru, &cc->freepages); > cc->nr_freepages++; > + cc->nr_migratepages++; > } > > /* possible outcome of isolate_migratepages */ > @@ -2435,7 +2437,7 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > unsigned long last_migrated_pfn; > const bool sync = cc->mode != MIGRATE_ASYNC; > bool update_cached; > - unsigned int nr_succeeded = 0; > + unsigned int nr_succeeded = 0, nr_migratepages; > > /* > * These counters track activities during zone compaction. Initialize > @@ -2553,11 +2555,17 @@ compact_zone(struct compact_control *cc, struct capture_control *capc) > pageblock_start_pfn(cc->migrate_pfn - 1)); > } > > + /* > + * Record the number of pages to migrate since the > + * compaction_alloc/free() will update cc->nr_migratepages > + * properly. > + */ > + nr_migratepages = cc->nr_migratepages; > err = migrate_pages(&cc->migratepages, compaction_alloc, > compaction_free, (unsigned long)cc, cc->mode, > MR_COMPACTION, &nr_succeeded); > > - trace_mm_compaction_migratepages(cc, nr_succeeded); > + trace_mm_compaction_migratepages(nr_migratepages, nr_succeeded); > > /* All pages were either migrated or will be released */ > cc->nr_migratepages = 0;