From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61A4ED6ACE3 for ; Wed, 27 Nov 2024 15:07:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B17506B0093; Wed, 27 Nov 2024 10:07:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC70F6B0095; Wed, 27 Nov 2024 10:07:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 940426B0096; Wed, 27 Nov 2024 10:07:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 765716B0093 for ; Wed, 27 Nov 2024 10:07:15 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 322E31A1403 for ; Wed, 27 Nov 2024 15:07:15 +0000 (UTC) X-FDA: 82832202852.09.44CE8B8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id C53791C0019 for ; Wed, 27 Nov 2024 15:07:01 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HLvxDuqh; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732720030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JtuSWI6j00O07KNYgnvI29vLhCBSe3nh6gxQ45WAVg0=; b=4B10kiRwOxu+FWvw+disYtSBvG26bbyIyxcd75hxrQRz0np0ls2Wz+Iqi7AEcOid0NNM1D i15RAGNtvHI6+KsuVKgtPvrjx/99Q72GoPoKdmN3AzU5pNAkXQFrrzQ7HnD+ZrOqCJuddZ HyEFg8kOum2jkLR760GyxCOObiZmP4Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732720030; a=rsa-sha256; cv=none; b=vZa42BPCpgj+BqRnnGGcx2xNVcOgnpGa09UZ8JMX3Njb3WTLQe4wOSKSesgmIb58ZdmYSJ Ia8CHjW81TWdYu9b1FMJeUi+7kNuygnwKf707FMttg1fG1o7DamFzpkXFEaK5qUVHrdfBV QxoNVFjEk4jX2zd8IT98mnN6xn8AVM4= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HLvxDuqh; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732720032; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JtuSWI6j00O07KNYgnvI29vLhCBSe3nh6gxQ45WAVg0=; b=HLvxDuqhtvm9VvL7P8kLPsEVIYpR01kPqf9RLXWRe8/laQgXeWFPJIvvwi0GR39/5oQ63v 1sCyqaJHDRNEVWTr6xcNNMgke+TGVU0bt6QHHf997wbuOG7zih3E1GfwePifHJgSXPWTr0 SOcoZmpxvhnUhWY1XNyxLRGFN1zVoxk= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-644-4WKYGW1UOHawFE23LoPTsQ-1; Wed, 27 Nov 2024 10:07:09 -0500 X-MC-Unique: 4WKYGW1UOHawFE23LoPTsQ-1 X-Mimecast-MFC-AGG-ID: 4WKYGW1UOHawFE23LoPTsQ Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38231e6b4cbso5154785f8f.3 for ; Wed, 27 Nov 2024 07:07:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732720028; x=1733324828; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=JtuSWI6j00O07KNYgnvI29vLhCBSe3nh6gxQ45WAVg0=; b=COFYcL0C3hJDUX61BuPfQ45VEkqMHXu2Bm4Plwk+8eTfODEAhfZ9Wn/KArgomfH/A6 F1AzSiWpOY+II+5todpYUqJTuv0vf+g80f3NVR7K/N9VAXq511tdPWAp3qu6Pfl9BnQN mBJpeb/awBPszkEytskkhT4Xg+zflKhtstYNiHD+r3th7g6fXZm957O+i2ieLupDWahR Obc8FKQcNOjAAAhL9n/eIu3BMPP7UQtvCPwCYhIqyZP+Po7eWjJfH5jyGj/o7zJSSiPj FSDegxLCwijwB1eDTlqsVN4CpaGzb7+P1xVaI1hcRXowp2ogeunFa3niSeEs55LW1b8E 8aqA== X-Gm-Message-State: AOJu0YyDVVFUUsNdm0hvRJjxQ7VlkzrWNW1VJ2ab5Stax5cktsIxH83X qoWBQ1L1FgY056uEnHhmjpSWl8ktUsJKXhAFBpBFYwypXqGEKQ4kfMXbeZ5jzJwEreohTg0i0gF 4EgAVJb1G80oI4Y7mub7vJGwfZepLKh2sZrex64boS6Q9y0SU X-Gm-Gg: ASbGncuPy+k7+olSNqpkhIjSGdE3D510jS1UF+8rmY8pSLptxxxJZAwgAUQ58IUdbAh zo0pAKc0xv1/HIWn/utU5DIGZJMaiExobn+khS0j+P5Pwpt/1XX2SCRkZIAJwgjeM6Rn/3962e0 8WhjrhpWdLNWNmg5Y8md1PxnEcB+mWhpT4X8FZLA2Flw3o3fIdeIA2j0c+JLwQ4obDm4LH6VA6n eBSbYbEVlcWzuLyzWaI55C7rtW+zJdbO+ftsHHXmMPs938UEDoE3jOfWaFOt8ync3UtStlZOd20 J39G0M1RRPRHBjmjOfBTezJhxgA61V3B2JnKoMxeI9fpHuiHZj1k5A64Bm6+u9Xu8pCJBHqXDvl K5g== X-Received: by 2002:a05:6000:1fab:b0:385:c512:658 with SMTP id ffacd0b85a97d-385c6ed93aemr3314501f8f.39.1732720028262; Wed, 27 Nov 2024 07:07:08 -0800 (PST) X-Google-Smtp-Source: AGHT+IE3avjjCUdWFobMNY41ESHZ406g4M9WPXdKCG/t8TjQuIAPXn5ippduXqDSI2iPUiHkXdz87Q== X-Received: by 2002:a05:6000:1fab:b0:385:c512:658 with SMTP id ffacd0b85a97d-385c6ed93aemr3313877f8f.39.1732720024066; Wed, 27 Nov 2024 07:07:04 -0800 (PST) Received: from ?IPV6:2003:cb:c70d:be00:66fa:83a6:8803:977e? (p200300cbc70dbe0066fa83a68803977e.dip0.t-ipconnect.de. [2003:cb:c70d:be00:66fa:83a6:8803:977e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fad62fasm16489726f8f.15.2024.11.27.07.07.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 07:07:02 -0800 (PST) Message-ID: Date: Wed, 27 Nov 2024 16:07:01 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 15/15] slab: Allocate frozen pages To: "Matthew Wilcox (Oracle)" , Andrew Morton Cc: linux-mm@kvack.org, William Kucharski References: <20241125210149.2976098-1-willy@infradead.org> <20241125210149.2976098-16-willy@infradead.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241125210149.2976098-16-willy@infradead.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PHvTOdA4Atq2EL8Gd0cC0ihNEx4U2U8O0v8YEXCb0Ag_1732720028 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: C53791C0019 X-Stat-Signature: fz8ic6bgqwdmt5zcu9b1r7nnbax6hq7d X-Rspam-User: X-HE-Tag: 1732720021-819271 X-HE-Meta: U2FsdGVkX18b768IP2NQVB9S70pNMighbzhXHb0gbM+k0PwWlaXqbyz+Q2WnxtdmVfbJwkAW6LPnoZjtv6w0V/ev8nuRpJ5qOo51vFDxlwrS5OkdFeHe/HETPwWm1+1ln4aqpNcBbpvCXdbOJs5k4gruLjCwGZjVhSR+6ud7CQzZYaB6WNZ//cszqV/1K4rMHkcb35e/0D9zLTkBwb3AOhDbv04sIJzqhH3AIwhFKPulyibgnEYgKMoqvarQkGFScG9+VvK+JnRNs85AJ9WZJeYULBb7EXsC1aSW8zFGOnyYqOttDTbSUetKhuIz5e/6qn42mCNg0Xb27EIRjJrbWuc9PtxuLB2F45rXSTbuOALINIbme70creaNs0v/Kv+EOy1YGdYVGsgND9ciCfLUACIuDYfapedzj/HVipzOr/zpjvX4SRjrFZb4HpsO6+STCoU5dceoMtJF8eOb6CyMfQeOFdUuq7JvEIzRGKDac37mJ2eNDAlZ6N1aYUeDcevBNzVt8aKAdaJg7hJFkwOjrnzM6FkkNpUkkvGc/gFri3ok172Q6nit66F8NgqYmIsW0zqMaZ2fvicMaaPFL6MyBvuCjXnrrOH3ToT3HuRnYF5e4vyUjTAh5ddqpvlPj3K3qQbgr8OQtsVzo2I3tHCWlNUAg5CL6In/P/FJi1eUdxw3yH8TI8lRdYIMlUCOgk3o6SKCaYZLp8sHJMbcPymjg5lSm8ZXG2QqS+ziQN9APcM8yi8ZyNraf8dx5S4JLWZWaAL7p/IKJvhSmL1y4k/R0EP+eVijlQ7NOTjU9mq41FTtSkFp8sV9/juvqVq+qYzMCLGCVDZBFQs21aW+oVtpUKvwjwRUokIrBgE8vbUmNxAdiBGeNKD12A5RAbJQYOt22BljzSk/0+t0RyzD9TNh6I1IwXwSQ/zRG6m3MJO+EtMM1PfPksMnI1NcoYVbbgi2AS1VPDJKPP0TJ49zkgp 8C7Bs6aS 4GBSE+RFBYGm0NNi6RI5KzDKn+nNgkpGFKoIf+4frTzMVixPwt07NHXJReU8EfHLkjAouW0fEtQy2IJB0Jk06d7z89CbXoGlzeuT2u/58Rj37UxQYhnHYx+S/Y/YtHpMP5tJQU+HJuwn//3OCsne8DTdfqYKaaWdHGcK3bqEGMRATNoWc80bkgb8/BZ47k8kRVnj0WmNjYM8CksGpISkq48mdYaoEHDgvOCAD48KoCqQiKklXxm3Wp5MzNwJKpre/oEWXplmCuc6irPGSmUotzShNuu6fGbPwGJzh7Z3o08Vp9VvgVJm3qHZ7FBYpF3X8hgYI29eATRyK9MZcmghRfVN6ALwAJSVbNmq0AR9eFlkSnmAhSk1rcO07oVdl7dqTz6HlBZ+/UNueVUMnKySQb92eidoRhbvAcnLHZ6IBU4WpF00Mvt6JnLTL9V1oCFR3zZXKQrI8FKMJZSB+OEsa/PMh3a/52AnupCIP X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 25.11.24 22:01, Matthew Wilcox (Oracle) wrote: > Since slab does not use the page refcount, it can allocate and > free frozen pages, saving one atomic operation per free. > > Reviewed-by: William Kucharski > Signed-off-by: Matthew Wilcox (Oracle) > --- > mm/slub.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/slub.c b/mm/slub.c > index 19980419b176..3d0c1cd6bdf5 100644 > --- a/mm/slub.c > +++ b/mm/slub.c > @@ -2405,9 +2405,9 @@ static inline struct slab *alloc_slab_page(gfp_t flags, int node, > unsigned int order = oo_order(oo); > > if (node == NUMA_NO_NODE) > - folio = (struct folio *)alloc_pages(flags, order); > + folio = (struct folio *)alloc_frozen_pages(flags, order); > else > - folio = (struct folio *)__alloc_pages_node(node, flags, order); > + folio = (struct folio *)__alloc_frozen_pages(flags, order, node, NULL); > > if (!folio) > return NULL; > @@ -2641,7 +2641,7 @@ static void __free_slab(struct kmem_cache *s, struct slab *slab) > __folio_clear_slab(folio); > mm_account_reclaimed_pages(pages); > unaccount_slab(slab, order, s); > - __free_pages(&folio->page, order); > + free_frozen_pages(&folio->page, order); > } > > static void rcu_free_slab(struct rcu_head *h) I think we discussed in v1 or v2 that page isolation should be taught about that. Likely we want something like: diff --git a/mm/page_isolation.c b/mm/page_isolation.c index 7e04047977cfe..7db2f79b39f0d 100644 --- a/mm/page_isolation.c +++ b/mm/page_isolation.c @@ -101,6 +101,8 @@ static struct page *has_unmovable_pages(unsigned long start_pfn, unsigned long e * because their page->_refcount is zero at all time. */ if (!page_ref_count(page)) { + if (PageSlab(page)) + return page; if (PageBuddy(page)) pfn += (1 << buddy_order(page)) - 1; continue; -- Cheers, David / dhildenb