From: Sahil Chandna <chandna.sahil@gmail.com>
To: akpm@linux-foundation.org, david@redhat.com,
lorenzo.stoakes@oracle.com, mhocko@suse.com, vbabka@suse.cz,
rppt@kernel.org, surenb@google.com, hannes@cmpxchg.org,
shakeel.butt@linux.dev, zhengqi.arch@bytedance.com,
Liam.Howlett@oracle.com, weixugc@google.com,
axelrasmussen@google.com, yuanchu@google.com,
yosry.ahmed@linux.dev, nphamcs@gmail.com,
chengming.zhou@linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Cc: Sahil Chandna <chandna.sahil@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
David Laight <david.laight.linux@gmail.com>
Subject: [PATCH v2 1/3] mm: pagewalk: simplify hugepage boundary calculation using min()
Date: Sun, 23 Nov 2025 08:34:16 +0530 [thread overview]
Message-ID: <f802959f58865371ba1b10081bced98e3784c5e4.1763796152.git.chandna.sahil@gmail.com> (raw)
In-Reply-To: <cover.1763796152.git.chandna.sahil@gmail.com>
Use the kernel-provided min() macro to compute the minimum value instead
of an explicit ternary expression. This improves readability and matches
common kernel style. Also change the return hugepage boundary expression
by using bitmask for better clarity.
This was flagged by Coccinelle
(misc/minmax.cocci) as an opportunity to use min().
Found by: make coccicheck MODE=report M=mm/
No functional change intended.
Suggested-by: Matthew Wilcox <willy@infradead.org>
Suggested-by: David Laight <david.laight.linux@gmail.com>
Signed-off-by: Sahil Chandna <chandna.sahil@gmail.com>
---
changes since v1:
- Updated boundary calculation of huge page range for better clarity.
- No Functional changes intended.
link to v1: https://lore.kernel.org/all/ff24b3c573b766b187b55a38497fbad0a319b9f8.1763227530.git.chandna.sahil@gmail.com/
---
mm/pagewalk.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/mm/pagewalk.c b/mm/pagewalk.c
index 9f91cf85a5be..1d38763a502a 100644
--- a/mm/pagewalk.c
+++ b/mm/pagewalk.c
@@ -312,8 +312,7 @@ static int walk_pgd_range(unsigned long addr, unsigned long end,
static unsigned long hugetlb_entry_end(struct hstate *h, unsigned long addr,
unsigned long end)
{
- unsigned long boundary = (addr & huge_page_mask(h)) + huge_page_size(h);
- return boundary < end ? boundary : end;
+ return min((addr | ~huge_page_mask(h)) + 1, end);
}
static int walk_hugetlb_range(unsigned long addr, unsigned long end,
--
2.50.1
next prev parent reply other threads:[~2025-11-23 3:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-23 3:04 [PATCH v2 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-23 3:04 ` Sahil Chandna [this message]
2025-11-24 10:53 ` [PATCH v2 1/3] mm: pagewalk: simplify hugepage boundary calculation using min() David Hildenbrand (Red Hat)
2025-11-23 3:04 ` [PATCH v2 2/3] mm/vmscan: use %pe to print error pointers Sahil Chandna
2025-11-24 10:54 ` David Hildenbrand (Red Hat)
2025-11-23 3:04 ` [PATCH v2 3/3] mm/zswap: " Sahil Chandna
2025-11-24 10:54 ` David Hildenbrand (Red Hat)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f802959f58865371ba1b10081bced98e3784c5e4.1763796152.git.chandna.sahil@gmail.com \
--to=chandna.sahil@gmail.com \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chengming.zhou@linux.dev \
--cc=david.laight.linux@gmail.com \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yosry.ahmed@linux.dev \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox