From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65F36C54E66 for ; Fri, 15 Mar 2024 06:38:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D50B980101; Fri, 15 Mar 2024 02:38:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C94B2800B4; Fri, 15 Mar 2024 02:38:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2E1980101; Fri, 15 Mar 2024 02:38:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9653B800B4 for ; Fri, 15 Mar 2024 02:38:45 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 43E504080A for ; Fri, 15 Mar 2024 06:38:45 +0000 (UTC) X-FDA: 81898320210.25.7DD6058 Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf27.hostedemail.com (Postfix) with ESMTP id 1C41B40016 for ; Fri, 15 Mar 2024 06:38:41 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1710484723; a=rsa-sha256; cv=none; b=lRvIW8bYMiKMu2YAucb3V6EMVtTWXHmgPK0ygX25UYUdC16wL99yyDRm8g3mkj7r/iZ1Kc OFfPSRMgRRzCRqTsMes/VSCWeBBgZB7RjuiScBZGrnpE43FG9Y+T8oASVxuxV1kV/cWXdN uvo19LLBpdGy5fqC8EqIwBNePF7bm3Q= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.35 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1710484723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iw88FItvCEpjDoW+dIXoXtC94TQ4q+mNqy7V5LVSUxo=; b=Jr4StS9AxeQcxvsGk0nOYiGbdYSygQnMhJWrd5XRd5tce+3+yDUxGopiUZ2DLayKD4bnxf luuZyAMGQL7PzX8r6rVXrMcHiN5B7f5AbIzbAZTsxJF2qByaPSVnBRutKj9ervc2u1BCeq JfMxjpcLhZtJZzKFPud6jo3cJY8OmYg= Received: from mail.maildlp.com (unknown [172.19.88.234]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4Twvf02V6Gz1QBZG; Fri, 15 Mar 2024 14:36:08 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 8D8151402CC; Fri, 15 Mar 2024 14:38:37 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 15 Mar 2024 14:38:37 +0800 Subject: Re: [PATCH 2/2] mm: Remove a call to compound_head() from is_page_hwpoison() To: "Matthew Wilcox (Oracle)" CC: , David Hildenbrand , Oscar Salvador , Andrew Morton References: <20240314012506.1600378-1-willy@infradead.org> <20240314012506.1600378-3-willy@infradead.org> From: Miaohe Lin Message-ID: Date: Fri, 15 Mar 2024 14:38:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20240314012506.1600378-3-willy@infradead.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 1C41B40016 X-Stat-Signature: paq4pyu5o6m7spuj6gymq7qmjj1fxy7s X-Rspam-User: X-HE-Tag: 1710484721-980007 X-HE-Meta: U2FsdGVkX1+E3o+L3lXYmi3a48PDrD61Docrk3dOyeM3OYG8q/xPq/g/kzEFYrKvFUTaui7IUsozrthttRXr/hEKPyW7T3UHNEHn5hzlxH9+GV7mili3uhRnnsLA3pL4PwU1J3fW5aQJWBj9zi3AvpwzmqZGxrzR/1Nuq23S6Bpm6RAD3oMZ4HHCO7h+zY0xNTxv0hEdvLJLc9nf+BNWKHEfZTNNGpT0X9l6HpXLV0J3uhyEd9/rFGTeYGjjnyS3k8uDwCjA3KMRYyUyNAWLBnCPdyD0eTQTj2/u27jSv5GimHr7tb/f5SI6qfQfZj15yU8QwN9uf7+7+ZEx2f6j6ogG9vxhuXbMpi9o8vtxW9tx1gI8mBc21ouB179PnD5c/PnbWzPrMNqLwUnPUqbtSePZPh4yFRbkiZ8LBlqPNnqRG89Sigfo+PkjjVLbB57DbcZszLIOxWljcFKitJDav/VXEm4eLGUT++XlSyb1COiOx06minrgzE3vENWfmTC7/V9XyoxuZ5ZyQm4x9T14xJwekvE0s5k77yXFZt+az0XROs4331RdjRHTPRuDPJMvpL9K0hZM6yKCUWYAYorpJq43MqEAxjncSQV8hGUZ2INOhEHlPcHc0QowypEanvyDRcUFUa3WgqRF1lnGYHZKrl+xqE6eZxzzyNaEK+2WbqcJNTSb0ybFiKDqm2S/KbQ0LA6xwBtkeURbazsHKIGu2+t6e8aK2WEBxX2Eqa+jo7VdkBInwb1J2uI8RtYkqt0A+/bVPwRCA5EDv2nYK56mhl66jzN7rAQJoLZj70OR1Ks0Rwp0Bvo7Mb8t+Njcm+JvLQrhwQpT64uc92b+plh1TqJs6w6Z04kVu+37dYv0BnLe0FB9UheoQLDAmT7gF5ggtIRev3BW3izgKIom9vJtwg5yECXlseBu7GlZc8FOVZAn7474ZR3Sya1/ATFBWE6vG8jC3t2p2627oe7M2x3 MTxCdh+c M5W+rIUPP7o4x3NaRVOFypcK/QuxG31AnL9ueXwv4nFy4JXqExtg7Ylzg47550RJ/jxdvJIvFgI0VcjoqoCFoD1Sh3HpPtB/96dKLkC8KCPHnsQfsZr5u89WoBii/Is/8lQEaSSqhryB6FLmR3aG5Df3ZK4oJ1vT2DM266e8fN6PpSPSmtCnAkqLU/wWzldZUK3kSR60AeS5mEQ6LVLcrBmjX5CkKiIVrwp4XpdwmrP3ipUOGapUgOcC1hthYXngnbwdA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/3/14 9:25, Matthew Wilcox (Oracle) wrote: > We can call it only once instead of twice. > > Signed-off-by: Matthew Wilcox (Oracle) Reviewed-by: Miaohe Lin Thanks. > --- > include/linux/page-flags.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/include/linux/page-flags.h b/include/linux/page-flags.h > index 6ebb573c7195..f1d65a72b378 100644 > --- a/include/linux/page-flags.h > +++ b/include/linux/page-flags.h > @@ -1017,9 +1017,12 @@ static inline bool PageHuge(struct page *page) > */ > static inline bool is_page_hwpoison(struct page *page) > { > + struct folio *folio; > + > if (PageHWPoison(page)) > return true; > - return PageHuge(page) && PageHWPoison(compound_head(page)); > + folio = page_folio(page); > + return folio_test_hugetlb(folio) && PageHWPoison(&folio->page); > } > > extern bool is_free_buddy_page(struct page *page); >