From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail172.messagelabs.com (mail172.messagelabs.com [216.82.254.3]) by kanga.kvack.org (Postfix) with ESMTP id B53146B002D for ; Fri, 28 Oct 2011 13:20:39 -0400 (EDT) MIME-Version: 1.0 Message-ID: Date: Fri, 28 Oct 2011 10:20:27 -0700 (PDT) From: Dan Magenheimer Subject: RE: [GIT PULL] mm: frontswap (for 3.2 window) References: <75efb251-7a5e-4aca-91e2-f85627090363@default> <20111027215243.GA31644@infradead.org> <1319785956.3235.7.camel@lappy> In-Reply-To: Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Pekka Enberg Cc: Cyclonus J , Sasha Levin , Christoph Hellwig , David Rientjes , Linus Torvalds , linux-mm@kvack.org, LKML , Andrew Morton , Konrad Wilk , Jeremy Fitzhardinge , Seth Jennings , ngupta@vflare.org, Chris Mason , JBeulich@novell.com, Dave Hansen , Jonathan Corbet > From: Pekka Enberg [mailto:penberg@kernel.org] > Subject: Re: [GIT PULL] mm: frontswap (for 3.2 window) >=20 > On Fri, Oct 28, 2011 at 7:37 PM, Dan Magenheimer > wrote: > >> Why do you feel that it's OK to ask Linus to pull them? > > > > Frontswap is essentially the second half of the cleancache > > patchset (or, more accurately, both are halves of the > > transcendent memory patchset). =A0They are similar in that > > the hooks in core MM code are fairly trivial and the > > real value/functionality lies outside of the core kernel; > > as a result core MM maintainers don't have much interest > > I guess. >=20 > I would not call this commit trivial: >=20 > http://oss.oracle.com/git/djm/tmem.git/?p=3Ddjm/tmem.git;a=3Dcommitdiff;h= =3D6ce5607c1edf80f168d1e1f22dc7a852 > 90cf094a >=20 > You are exporting bunch of mm/swapfile.c variables (including locks) > and adding hooks to mm/page_io.c and mm/swapfile.c. Oh, good, some real patch discussion! :-) You'll note that those exports previously were global and were made static in the recent past. The rationale for this is discussed in the FAQ in frontswap.txt which is part of the patchset. The swapfile.c changes are really the meat of the patch. The page_io.c hooks ARE trivial, don't you think? > Furthermore, code > like this: >=20 > > + if (frontswap) { > > + if (frontswap_test(si, i)) > > + break; > > + else > > + continue; > > + } >=20 > does not really help your case. I don't like that much either, but I didn't see a better way to write it without duplicating a bunch of rather obtuse code. Suggestions welcome. Thanks, Dan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org