From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03277CDB474 for ; Tue, 17 Oct 2023 13:48:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2EF628D010E; Tue, 17 Oct 2023 09:48:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 275A98D000C; Tue, 17 Oct 2023 09:48:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 118B38D010E; Tue, 17 Oct 2023 09:48:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 0144A8D000C for ; Tue, 17 Oct 2023 09:48:23 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B9CAFC0CB8 for ; Tue, 17 Oct 2023 13:48:23 +0000 (UTC) X-FDA: 81355082886.14.A93062A Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf24.hostedemail.com (Postfix) with ESMTP id 65249180028 for ; Tue, 17 Oct 2023 13:48:20 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1697550501; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=67pEmRLSwXBI4Gi53NlTbRTBpIsK1qNq4sPdJrAjHVw=; b=qtPde+EQCkZxWV6qdNRW+h9qhb47+Xbfcs61JVn2s2RfMkcovSd3jkRiILR3Hv+jfI55+l HPNjorjIQqlldjfzMPeFF1c6GRcj6Sc74Dduj7MPsff9q6Q2FT43Ammnd+DCtsg5/dMSEF FNps14N0qbOw5Iz+TG2vCQrWmfyz1Sc= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; dmarc=none; spf=none (imf24.hostedemail.com: domain of riel@shelob.surriel.com has no SPF policy when checking 96.67.55.147) smtp.mailfrom=riel@shelob.surriel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1697550501; a=rsa-sha256; cv=none; b=CseRE98rMxYclts/qe6QjBfh2kBqWu3kf/CJ75cqWZUO9XSk5Kz7EZQ9RSEw3bGHPxpDVs FTAExJh5F6lM8RxEIw4nRRwO3vLNZ6Brbwa+9YsUkdwItBSYp01fSB3+1fD0qKXcNxxY+q EaVWu1VSB27kRlpvglIVAQxxqISM+rk= Received: from imladris.home.surriel.com ([10.0.13.28] helo=imladris.surriel.com) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.1) (envelope-from ) id 1qskPy-0000VA-2n; Tue, 17 Oct 2023 09:47:30 -0400 Message-ID: Subject: Re: [PATCH 4/4] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock From: Rik van Riel To: Mike Kravetz Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, muchun.song@linux.dev, leit@meta.com, willy@infradead.org, Ray Fucillo , Jacklin Kotikian Date: Tue, 17 Oct 2023 09:47:30 -0400 In-Reply-To: <20231017005236.GA236970@monkey> References: <20231006040020.3677377-1-riel@surriel.com> <20231006040020.3677377-5-riel@surriel.com> <20231017005236.GA236970@monkey> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4 (3.46.4-1.fc37) MIME-Version: 1.0 X-Rspam-User: X-Stat-Signature: rk5fj3uijfh8gg896d5tthfykigq3f7p X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 65249180028 X-HE-Tag: 1697550500-707698 X-HE-Meta: U2FsdGVkX19+mMBHekvrkrQSztV4conypgGo5AhMcBstdQWnOxEa0L8iTCy6EgOMPb2CQaD6r735BmljWauXFvM4tMx2oQ6HSHhKKU5xx5a0PZTM85TJdahd/1m838fEel5zP5CBT73020+oR2TEroW9E7us1IongnbZhhFU59/Fb9ETQOfuvKwcxULGfUvoQoFU8ZiYbVx13RaFUvNOb70JParEMweV1P7JWktFcreki65oif9WaMRXBBbm6C300RDXiFKVVFeltuTprFiqJk0PNwNIOiHSqQfpek87k7/aGAX3MphqM0SilA2IhTDYHJ0efK9qHns8IFMUkuTURIZRvD1jraDFG72NBQjQwEN8GFzrtia/5VGxW/bjSeY2jpuAOcLR6p6Ym4Sa6VzbN6nl2hX0cje9e6GkLCyag9tmi4syj5RFTTEslm4m1JDnxemsweyATuMkEtQ6onWxob0A99UREOyVuUx33REASbXZM03YLduS6gO1yKPHWultZDb23IZhyItYXzo+7/HlJ/hyMtZYKN+L3tYIaKof1kHtYfl0b2ExhKrtkgFkt55/vxEQdFxRpIIxaagqc8djGajAU3VsXmuaFfc1xP01XiRHPL3MDJqdAW2haHom1Fo187np1jUolU9Fe/DeuJz3/aL/dxdUS6GSMAIjKiVWIlI/WLpYI6CPJ8OE1jcNO27HAnSbsSvHEyLjDW4HNPN2FhmfWegDxZcKEUUqBmFUnA2zq1Rf7SpWVhs7SyNBbTlP07xqst02G96Lh1EZpq/dFkL0zCEf9J+40dLl0OShib9Df0hWzKgB5Vdu+rnSqecRKRzzCAhXE7xZYa8dY0Ox/D28zGekvoiyc6kJwCFXJdqMezht9azno3wCoogPPBBq6ISgWCTG1gzDB0TmDkFEd2AUVR+3e5yBGeRwX9QVdpljfUrDXFd/t8khkiz7c5wcDjDwagPZ1L2uVRupKr5 +eVNo4SW G5LuqHI1/1JyQ3ZRtmx5nx5zAPEv0hcZWwlaEVV+K00+aGomMjpTV2nMQYDKDzu6tLEsHJHdd1PTWj0Yeq4zOMT5mwjnzAbdY7pQSZoyFZmQZdqGkz7W/hWQIdWiYVY1wvurRandNK/mPHIUS8RWTNRoYUMBcFNMfdVERrsRI5vX39fe7dqxEwyrW48lQYJFeSKwW/yNFo8nJqL7US16M8/p/DrolfL8+sQ51X7oK9rbnU3q/M/6qBQrcHS04SOeX9TyFpM8EMK5WlImlaDErCHW+nupHaht/6tZu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 2023-10-16 at 17:52 -0700, Mike Kravetz wrote: >=20 > The Combined faults number drops by over 50%.=C2=A0 This is not nearly as > dramatic > as the changes originally seen.=C2=A0 However, I do expect that there wil= l > be > a noticeable performance regression.=C2=A0 Ray may be able to help runnin= g > real > workloads on real applications and database. >=20 > I suggest we hold off on adding this change until further, more real > world > analysis can be performed.=C2=A0 The simplification of the code is nice, > but I > would hate to regress any workloads. Agreed. Thank you for running those tests. Andrew, would it be possible to drop patch 4/4 from -mm? --=20 All Rights Reversed.