From: Rik van Riel <riel@surriel.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com,
linux-mm@kvack.org, akpm@linux-foundation.org,
muchun.song@linux.dev, leit@meta.com, willy@infradead.org,
Ray Fucillo <Ray.Fucillo@intersystems.com>,
Jacklin Kotikian <Jacklin.Kotikian@intersystems.com>
Subject: Re: [PATCH 4/4] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock
Date: Tue, 17 Oct 2023 09:47:30 -0400 [thread overview]
Message-ID: <f7f7b396f60e2a9d22e5d5ab36f78507138d8650.camel@surriel.com> (raw)
In-Reply-To: <20231017005236.GA236970@monkey>
On Mon, 2023-10-16 at 17:52 -0700, Mike Kravetz wrote:
>
> The Combined faults number drops by over 50%. This is not nearly as
> dramatic
> as the changes originally seen. However, I do expect that there will
> be
> a noticeable performance regression. Ray may be able to help running
> real
> workloads on real applications and database.
>
> I suggest we hold off on adding this change until further, more real
> world
> analysis can be performed. The simplification of the code is nice,
> but I
> would hate to regress any workloads.
Agreed. Thank you for running those tests.
Andrew, would it be possible to drop patch 4/4 from -mm?
--
All Rights Reversed.
prev parent reply other threads:[~2023-10-17 13:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 3:59 [PATCH v7 0/4] hugetlbfs: close race between MADV_DONTNEED and page fault riel
2023-10-06 3:59 ` [PATCH 1/4] hugetlbfs: clear resv_map pointer if mmap fails riel
2023-10-06 3:59 ` [PATCH 2/4] hugetlbfs: extend hugetlb_vma_lock to private VMAs riel
2024-11-07 20:18 ` Peter Xu
2024-11-12 11:24 ` Oscar Salvador
2023-10-06 3:59 ` [PATCH 3/4] hugetlbfs: close race between MADV_DONTNEED and page fault riel
2023-10-06 17:57 ` Mike Kravetz
2023-10-06 3:59 ` [PATCH 4/4] hugetlbfs: replace hugetlb_vma_lock with invalidate_lock riel
2023-10-17 0:52 ` Mike Kravetz
2023-10-17 13:47 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f7f7b396f60e2a9d22e5d5ab36f78507138d8650.camel@surriel.com \
--to=riel@surriel.com \
--cc=Jacklin.Kotikian@intersystems.com \
--cc=Ray.Fucillo@intersystems.com \
--cc=akpm@linux-foundation.org \
--cc=kernel-team@meta.com \
--cc=leit@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox