From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 586EAC433EF for ; Tue, 21 Jun 2022 09:09:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF7496B0072; Tue, 21 Jun 2022 05:09:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7226B0073; Tue, 21 Jun 2022 05:09:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B95136B0074; Tue, 21 Jun 2022 05:09:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id AE22F6B0072 for ; Tue, 21 Jun 2022 05:09:55 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6C72D80F6F for ; Tue, 21 Jun 2022 09:09:55 +0000 (UTC) X-FDA: 79601670750.12.F5DBEC8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id E87E31400B8 for ; Tue, 21 Jun 2022 09:09:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655802594; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p6YYqoeBYUlu/VJufYNPYGtqIyaJ1M+ZkJJuqhZoIco=; b=buxwxhJ2HnOB3Nwo8otDSl47pX6cJ3lKQygPquU8hFCnEwSKbEQRNCtxIY1COMeEMusDQp 4Iou0/W7hQhq8P2XT05OdisJNvI/KBG+JfU8spFiZhqkcDIGZ1GTyL2zR8j5BZi4QSWS2P bt8jpDogaBaSazHOpOreZfrH3VcdYzQ= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-418-ZdjYw_RgMLqMkON77TTxZA-1; Tue, 21 Jun 2022 05:09:53 -0400 X-MC-Unique: ZdjYw_RgMLqMkON77TTxZA-1 Received: by mail-wr1-f70.google.com with SMTP id i17-20020adfaad1000000b0021b883a2892so1849400wrc.22 for ; Tue, 21 Jun 2022 02:09:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:organization:in-reply-to :content-transfer-encoding; bh=p6YYqoeBYUlu/VJufYNPYGtqIyaJ1M+ZkJJuqhZoIco=; b=GwUYF07tO9HC1lw3FuyHVWQ0M8vKdDcdEqkJbw7bsJoT6qiS2TAMLsGyw/ddcbkIEc NQYIrXxEcStCGV2jdcc9D35rzixzdCY8wykf8WA1JIjCE4fr29gH1CdJ1DDWdGxp5zX8 D7L8HvECbQLOTSW60wl3YHi0wQcIzC7I3djfnsRAZWC09+fRpxIC61sdRkO3JA+KhBRg 9Iu/+TRIzfIWq96WvewAa9QT7vTWW9pLN3YWqcHQvsSRNNmTUJSKyZGBVyRxFqZtmV2w 3WdMMs7fqPeZ/8i55+oQuL0DsmAxg3ZzEG2B1fnCJQkslDXzCNzcTlce6+CDa30PnOt6 kOIw== X-Gm-Message-State: AJIora+2m3w8JSuUB3IE4QcUk24JRVdroYWlofVvsleV/DO9sR4kemD6 D7DdjboJXicuMO+RNAKmm2g0ZleaXPOLAdtqLdR19nP+2e/jcbBJpHl4dXeekIz5SIX6cS56taV f2jxs9Hme2Po= X-Received: by 2002:adf:eecd:0:b0:21b:7f2d:47bd with SMTP id a13-20020adfeecd000000b0021b7f2d47bdmr19757776wrp.26.1655802592042; Tue, 21 Jun 2022 02:09:52 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tDQqiFdsiM0RmmM6T7X/6TbXNmyK6Rjm0rXyvCFabqXryy8DMxqQmhHjyF/YbQWw5GjbYaEw== X-Received: by 2002:adf:eecd:0:b0:21b:7f2d:47bd with SMTP id a13-20020adfeecd000000b0021b7f2d47bdmr19757755wrp.26.1655802591829; Tue, 21 Jun 2022 02:09:51 -0700 (PDT) Received: from ?IPV6:2003:d8:2f04:2500:cdb0:9b78:d423:43f? (p200300d82f042500cdb09b78d423043f.dip0.t-ipconnect.de. [2003:d8:2f04:2500:cdb0:9b78:d423:43f]) by smtp.gmail.com with ESMTPSA id y16-20020a5d6150000000b0021b932de5d6sm3880603wrt.39.2022.06.21.02.09.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Jun 2022 02:09:51 -0700 (PDT) Message-ID: Date: Tue, 21 Jun 2022 11:09:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH] maple_tree: Make mas_prealloc() error checking more generic To: Liam Howlett , "maple-tree@lists.infradead.org" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Andrew Morton References: <20220615174213.738849-1-Liam.Howlett@oracle.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20220615174213.738849-1-Liam.Howlett@oracle.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655802595; a=rsa-sha256; cv=none; b=gq/B4WiHSuOByRUxIUBjbtse8nZPZU5ieprE4b24uJBbds70vsNZbB+vFYl8cUsxLUxXvK xUFnpVFAB80geKtH4800hucuwxgpUz0esRIzxjheIjoiKH0ajT/c0BB0q2oPDl13X/e5kH vayyPJsYtJig00Ctpioc887/tgE8gaw= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=buxwxhJ2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655802595; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p6YYqoeBYUlu/VJufYNPYGtqIyaJ1M+ZkJJuqhZoIco=; b=jLcXpcH7N2m/7h8vpn/MSKy9BJS2KxNd3SbFxn+esUnkPGwC9obTBmOVUIGOCQte2kNJhQ pnYjaM+uNxY7z0hA4cOaEhtIOdfe3TciBvutvqOyvhjC0ikSC0VKgdOQdZNg2GxiZqSqPD U+PHXg9w+VGagrN7Q2+yeUSudHD0qNI= X-Rspamd-Queue-Id: E87E31400B8 X-Rspam-User: Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=buxwxhJ2; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam06 X-Stat-Signature: 9khg7fbpsdbu8ayzwiu3nfrh4peawqtr X-HE-Tag: 1655802594-154370 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 15.06.22 19:42, Liam Howlett wrote: > Return the error regardless of what it is. This is a safer option. > > Signed-off-by: Liam R. Howlett > --- > lib/maple_tree.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/lib/maple_tree.c b/lib/maple_tree.c > index f413b6f0da2b..89ff5ef7ee28 100644 > --- a/lib/maple_tree.c > +++ b/lib/maple_tree.c > @@ -5670,16 +5670,15 @@ void mas_store_prealloc(struct ma_state *mas, void *entry) > */ > int mas_preallocate(struct ma_state *mas, void *entry, gfp_t gfp) > { > - > mas_set_alloc_req(mas, 1 + mas_mt_height(mas) * 3); > mas_alloc_nodes(mas, gfp); > - if (likely(mas->node != MA_ERROR(-ENOMEM))) > + if (likely(!mas_is_err(mas))) > return 0; > > mas_set_alloc_req(mas, 0); > mas_destroy(mas); > mas->node = MAS_START; > - return -ENOMEM; > + return xa_err(mas->node); > } > > /* Liam, (as asked privately before, I was just too busy to respond :) ) once all known issues are fixed, can we have a new version posted to ease review? That would make my life easier to see what needs review and in which order patches apply. Thanks! -- Thanks, David / dhildenb