From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 886A0C4725D for ; Mon, 22 Jan 2024 06:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AF3736B0072; Mon, 22 Jan 2024 01:16:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A7C936B007B; Mon, 22 Jan 2024 01:16:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91CEF6B007D; Mon, 22 Jan 2024 01:16:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E1056B0072 for ; Mon, 22 Jan 2024 01:16:50 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C0AA1140733 for ; Mon, 22 Jan 2024 06:16:49 +0000 (UTC) X-FDA: 81705938538.21.E663F6C Received: from out-174.mta1.migadu.com (out-174.mta1.migadu.com [95.215.58.174]) by imf02.hostedemail.com (Postfix) with ESMTP id EB8BA8000E for ; Mon, 22 Jan 2024 06:16:47 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cv8EMnSK; spf=pass (imf02.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705904208; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8Pb80DoRWEyZoi0wqPXsfRRerxvgd/0OhZbYr/fDW1k=; b=6BIZxuTYVUGL1u6Fr5ksR2xelLcfNdnRbYeNCNqSt32X/hIErCbKjwDDV582BBT/n6WAaq GP2Anke9qWtwojwnaqBFHM6AxVVslF5NrhF1+BnZYFi1y6kXOxqIAoxKsouUvYZvHZnVpZ JygFvGGardak4S9Ua1fxq96HpWULcFY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705904208; a=rsa-sha256; cv=none; b=xFztlo+t0UX05XB7kZR8y9UGRp+KFhnab12a7dCDqHbvk53+6wrQ/KJVIljP2WcVuGTMTp R/YAgGuz6SDsZBXfmectlTJ1zwaVP5KPg1/PrsQhwQY+osHqFjFE1GXAaToQRyL895NZLC qnxLExPTq1pSBrZri5KoNC4XKZiqswc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=Cv8EMnSK; spf=pass (imf02.hostedemail.com: domain of muchun.song@linux.dev designates 95.215.58.174 as permitted sender) smtp.mailfrom=muchun.song@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1705904205; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Pb80DoRWEyZoi0wqPXsfRRerxvgd/0OhZbYr/fDW1k=; b=Cv8EMnSK34A8/z8rlXk13g6F0z8uk3JfdETFL7MOLnZgIcCjw4qv3uKqH8gA3DPi89fLWm kz+S8S+k58QCbd8m6mSfsPNA0gxiQDFtMTWT8QOj+34W6OGnudn9vUj0IGAiC0CwMFl+6g MQARgoJzjqEMSyHitrjFOE4E0nUVxkk= Date: Mon, 22 Jan 2024 14:16:30 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v4 4/7] hugetlb: pass *next_nid_to_alloc directly to for_each_node_mask_to_alloc To: Gang Li , David Hildenbrand , David Rientjes , Mike Kravetz , Andrew Morton , Tim Chen Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, ligang.bdlg@bytedance.com References: <20240118123911.88833-1-gang.li@linux.dev> <20240118123911.88833-5-gang.li@linux.dev> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Muchun Song In-Reply-To: <20240118123911.88833-5-gang.li@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: sfq3yukk4bmrwmjoifbdw11udckj4fy1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: EB8BA8000E X-Rspam-User: X-HE-Tag: 1705904207-924095 X-HE-Meta: U2FsdGVkX18ZEHECoknvsB8hvvIjhmAQHh71eKM81yZQawKaUb45qAD1K3NaKfKPHsaK2VQ1scj94GZXfNdjv/cWYF+c4jBpSx4T7uqnnvbm69Q/Td0bPZ9TIty8PWX2FzlaKhq95FX1VeGx9xKMRGnPCfqu5ssa/f6DT3eJtW2IPzpw5GCOTTlRmIHLtgrr3aeIm/Bc/A7Aqi6nj1EelQ+gWoLTBGz2g2K/4t5om1m13lpm/09nyxAoX4R6nLaLeDCIsVbZ2MQj3bMQm1Eg+VUqFIY2SK/diRRvmJoRA0QkJW4MiHzZuIbxOy2734XIzqoci28yeGO1K9YtOg8iBmlUJydm/DpaCfXGwMGx3RWyopWMZoZcmRX0tPwCKFhbmYVlqJgwxlvxZUDUvzM0ZPLD1epOg8xiUalubNkEo8NC1sSSYxKwxsQjyzvOrAwvWC/8JXlOeIdcbJLrCRxncJNHwOkVdQpucIF9i/A+RQjiR5Y8vgYyhUs4suYq5/Wok4CPPkvNdiPyowfPrdPNeodvU8VaYYvnwfj7m61ZY9gxPSnRL4NhExA5/SqSdNsjYYKUMsYIguaA67ylFSmsQmjnR4VYJHAZfdqLUzM9CinGWpnR81X251cRWqw5D9vyFIg/7vF+80YTQI6+1ZXjoVL0quDZJf+uegLTwjaW65HYzBPk9pJ3F0AxMbfsDYeJ/mX9BzCxCi8NyIUzab7I4HB1babvm0uUYdaoNXBtRoqr+VPGOzAP6zT88XU4TqbGxliYmpOtduAxyLU3siVpKASAf0CRh7uBtxvZxdiKgUkOeeFnWhkgoDOzfFlCg696Uj8GnFN5zsoOP0zi5cIRB0tSeJHZgS1lfehk/6WWwEZU29jybBYp6XEhVTGtanCB3E27ucdjrcEpOlEqjqdHJQe8cnnL1I43H0UvHKxfOF7LT1ZdJLaSX7NiGOFHvD/E4Z2/iTguo87TkCvwrfD 4GiIMAdR Qv/W+3Unv9nkYMwQfpPRCrJqGEEm3jLYK4X+wJlTATQ3L6AtsWL8UVl4lTgvOUQc7oKyMZzPZdFkiA/hwTge903TbSmyVG/f1M8tuxUfd6M+uGeqzRXURtmDQKbpRNB30+2u/RC3HDyhmYbxE/Rw3A2qNd53YVMaDSSz8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/18 20:39, Gang Li wrote: > With parallelization of hugetlb allocation across different threads, each > thread works on a differnet node to allocate pages from, instead of all > allocating from a common node h->next_nid_to_alloc. To address this, it's > necessary to assign a separate next_nid_to_alloc for each thread. > > Consequently, the hstate_next_node_to_alloc and for_each_node_mask_to_alloc > have been modified to directly accept a *next_nid_to_alloc parameter, > ensuring thread-specific allocation and avoiding concurrent access issues. > > Signed-off-by: Gang Li > Tested-by: David Rientjes > --- > mm/hugetlb.c | 22 ++++++++++++---------- > 1 file changed, 12 insertions(+), 10 deletions(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 98ae108e1fac..effe5539e545 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -1464,15 +1464,15 @@ static int get_valid_node_allowed(int nid, nodemask_t *nodes_allowed) > * next node from which to allocate, handling wrap at end of node > * mask. > */ > -static int hstate_next_node_to_alloc(struct hstate *h, > +static int hstate_next_node_to_alloc(int *next_node, > nodemask_t *nodes_allowed) > { > int nid; > > VM_BUG_ON(!nodes_allowed); > > - nid = get_valid_node_allowed(h->next_nid_to_alloc, nodes_allowed); > - h->next_nid_to_alloc = next_node_allowed(nid, nodes_allowed); > + nid = get_valid_node_allowed(*next_node, nodes_allowed); > + *next_node = next_node_allowed(nid, nodes_allowed); > > return nid; > } > @@ -1495,10 +1495,10 @@ static int hstate_next_node_to_free(struct hstate *h, nodemask_t *nodes_allowed) > return nid; > } > > -#define for_each_node_mask_to_alloc(hs, nr_nodes, node, mask) \ > +#define for_each_node_mask_to_alloc(next_node, nr_nodes, node, mask) \ > for (nr_nodes = nodes_weight(*mask); \ > nr_nodes > 0 && \ > - ((node = hstate_next_node_to_alloc(hs, mask)) || 1); \ > + ((node = hstate_next_node_to_alloc(next_node, mask)) || 1); \ > nr_nodes--) > > #define for_each_node_mask_to_free(hs, nr_nodes, node, mask) \ > @@ -2350,12 +2350,13 @@ static void prep_and_add_allocated_folios(struct hstate *h, > */ > static struct folio *alloc_pool_huge_folio(struct hstate *h, > nodemask_t *nodes_allowed, > - nodemask_t *node_alloc_noretry) > + nodemask_t *node_alloc_noretry, > + int *next_node) > { > gfp_t gfp_mask = htlb_alloc_mask(h) | __GFP_THISNODE; > int nr_nodes, node; > > - for_each_node_mask_to_alloc(h, nr_nodes, node, nodes_allowed) { > + for_each_node_mask_to_alloc(next_node, nr_nodes, node, nodes_allowed) { A small question here, why not pass h->next_nid_to_alloc to for_each_node_mask_to_alloc()? What's the purpose of the third parameter of alloc_pool_huge_folio()? Thanks.