From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C714C61DA4 for ; Mon, 13 Mar 2023 19:41:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 21C4F6B0072; Mon, 13 Mar 2023 15:41:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CBAB6B0074; Mon, 13 Mar 2023 15:41:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 092DB6B0075; Mon, 13 Mar 2023 15:41:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E96456B0072 for ; Mon, 13 Mar 2023 15:41:13 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id A721AA8ADE for ; Mon, 13 Mar 2023 19:41:13 +0000 (UTC) X-FDA: 80564893626.18.E462F86 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf27.hostedemail.com (Postfix) with ESMTP id C001840017 for ; Mon, 13 Mar 2023 19:41:11 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WG5pBvPY; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678736471; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kDHoNTYRuPYjRiZwfgC2w8CcgH54J2Q5EIBdARM+oCs=; b=T03yAZIcNS4viB68gQKz/WQXcFVyC3n94IJgGEh8NuGTVsYnTCyJgrntOP1XadawrJ7aXl mAH2BDsWOE0bTi3i3nBlPAcypQ2nL1BY+NUaLzVoAxsLwaNzLPPRxM1JM3wgk1U95Lssvg SbJOIt2mlvv9fyM+RlQX2zC3wKGK+/4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=WG5pBvPY; spf=pass (imf27.hostedemail.com: domain of lstoakes@gmail.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=lstoakes@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678736471; a=rsa-sha256; cv=none; b=AeZ0DBZLg2KRrZ8z0TNreTuXRcni957fpV6lmpqqd/AyBr9yD2ADkbGPh64HepBRgQKCW7 Vij+x9B5x0Yoo+GGJ1Oyqv5EgMMC2NcM4ny4vaPTMFhfHI/83l4L0hJYTDlLr8y+Jm1Nhh 0+/Q2T0iNHoV8uOICwwOT5uQ0N43aSA= Received: by mail-wm1-f43.google.com with SMTP id k37so8847934wms.0 for ; Mon, 13 Mar 2023 12:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678736470; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=kDHoNTYRuPYjRiZwfgC2w8CcgH54J2Q5EIBdARM+oCs=; b=WG5pBvPYaNCjjDwtZhJYZGmaoF5Ny5BQy6Q0w2tuyxdosHjqXxzz9N2KtYfxkEKHda bm6vOO2777IPYEQXY6u/tySVgYXKB5XWGqyGrEfaaNwj6VdrEYBmxZn/pwgiraxmm0Cr SBmkBACdsWLyQynkKWUszIZ7ltl0Npmd/o/tqhH+c6I9LdmPHm2c2PHNWm8PD1wioYNP 5d87KJwG9qTMslXHhmeNSxuvx1DJUKZRG1zYBASthmByI5J70Mvx/ra1G8y/7Vo/R4pe kCu0gYG5YCqtdimuPkVxcwR3pXYtIE0+D+UBiu+ZjsYoTDkgB1gwi6fF+enZ5gvLZXXW ZmHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678736470; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kDHoNTYRuPYjRiZwfgC2w8CcgH54J2Q5EIBdARM+oCs=; b=oul//hUxaclkxPP9Ms6Yc1iyPFco+T4gTSkC+KLG2mxex8b0ueAjMSyuhKqWYgB1Dl CcRzfMfkQK4aygemMbre9PpdhyUL5XpC31lCDuUtYI05z4YyDZRo5UmQntNSuokLavSW 0gzWv7EUpDvC5M58r+0WCL3cM1YeflQzc+lyyBIZKt2hMIE58JPVMNH1V/8mmEkJo01T tkyFJQfQrht7b5RZgbTpi6EqYrjyfOCl0SXKKWYb34WwlZAW9HPQ4A6r9ZglASOu1ri3 LalBJMgeu3NBUo/yzQ+U7IHofPZVVND39ngv4CXleoVRKthDRBFjAyp+CkSI0J3uzWvg DMOA== X-Gm-Message-State: AO0yUKULgLc6sa/8z19OOTrO7DZN5vZvQc3tGGDGl3LxQRYeGXxv5KE7 DNy3gih98fv6B1XoAKWRvA/BsTeR5Fs= X-Google-Smtp-Source: AK7set/Cb4iH1IKwtyGpCNnEPAGk9kmpHLpbX4q9NnLiWUOQVqEje7GnNxwgOvhHQra3m/ty24H0zw== X-Received: by 2002:a05:600c:4e8e:b0:3e0:1a9:b1d7 with SMTP id f14-20020a05600c4e8e00b003e001a9b1d7mr12100047wmq.19.1678736470047; Mon, 13 Mar 2023 12:41:10 -0700 (PDT) Received: from localhost (host86-146-209-214.range86-146.btcentralplus.com. [86.146.209.214]) by smtp.gmail.com with ESMTPSA id a16-20020a056000101000b002c54e26bca5sm275557wrx.49.2023.03.13.12.41.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 12:41:09 -0700 (PDT) Date: Mon, 13 Mar 2023 19:38:58 +0000 From: Lorenzo Stoakes To: Christian =?iso-8859-1?Q?K=F6nig?= Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Andrew Morton , Thomas Hellstrom , Matthew Wilcox , Michal Hocko , "Kirill A . Shutemov" , Dan Williams , Jason Gunthorpe Subject: Re: [PATCH 3/3] drm/ttm: Remove comment referencing now-removed vmf_insert_mixed_prot() Message-ID: References: <58224a49-654f-0026-4286-c6103d2057dc@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <58224a49-654f-0026-4286-c6103d2057dc@amd.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C001840017 X-Rspam-User: X-Stat-Signature: nt6i7qb346bqdspeb5qdje1guggsu9aq X-HE-Tag: 1678736471-859942 X-HE-Meta: U2FsdGVkX18q0rAEBJzLMfGW1cCQGdufHPldW884GzFco5Q9Nr/ZzsZ5BIw+gqBwZd5if+VtLtSVX1vxTDCqsSMtAXVsOpY5Aht5mTRJg9dRkBoOX6rnmHE+cFvRxLMGRxlZa/ARa3tdy6lDU/B3CNbqPMKVFBKBkq9nx7KDWP+rpveF/V44bXBk/hpRoYu12w4Zm+Im+9vuRVq3eoM8r8D4j5V8rZk2OqqFbEHXtlnk7JyjnsZiYiLbp2aGCwggIR2fivRxkTjOco1ZQWWXfztXy4oMQx328QWWgIyOmei3HtqfqxEYrJJyGs0UX7iYI2g8SjKfKHuMWel6AoQtwLuEpGal2lIGgfDvJI9fR4U5D/k+H4sj2ZYuvVf3m1yPq/xJhfEUTxypz0G+djteEsQ1sTgci6QYtfNsb9zVdLUJ+E1qWQzDAjBlVn+ElZS33qwXBzbcCTSbxkVOBtTqpYGk5rxkcmJlhed8822S+htyzUDsKsUWoPRQmV/NxRYPtFWdNYpg/4fLWIX/8kIvJ5boeHliOg/2eeMQVKP+DgTP+v/0wn31GTmKwCqhsewUqsGGuPaMFXM+k5asPGguirxX3oxHacyckpHRnhB9Oq/rCidwuQvEEQKK8TibqcyekKozLWL1LABjck0YSod91t34jmwxf81KCXx42lTfwJzvku9J6Az4miYPDHCQG/Jml/6NUTsgn+N3i7BNh7w/yCONa6EyRPukQ8ljxJ69on5CxT/Urw3gg2CIOHh36fcTE7jInaflsPizMR4uNgQxehVcn6ThTwWzPZ9rF1F1qy18u9tsNqs4VilJyksqIlDJfVoTIhwWRGRVAQWkwXvLDg4TWVBEaWZCa3fz03GqpbbPKgkcBhOZkoaj4l4+nW0negXk9en1sZNSemFYf61dRh+cNnADW1naDWYwN1VJuuJCpypM5Fa5BGLffgzd1NTIOSlk9p8PKz5Y0DNT1+U qYj37tQk ph5uOWFVnGOkrbNNvm26aPCvVywBkrUR1mXy38S75G2s3cRLBtTpUZsTJMYcG+Lf0/Ume1/6YvREh22r7sgQwFJXDgWLwM8aiN3mTp6dj/ZNO+uE41qZisjJVpRnO437AVCqWq7TwhEA5U4/bGqGA/y9sMfjHWKwFUcQJ93AZhJStrFJah+IqD6TDJkhFG/MKa7Uqb3sI1uv2fiNiaNX8tv5Aj3BP0k8wOeuu6IN1wH+Pq3jcyIrftsZWsFv9P0ESeBmlwKBgsVVDfXW6P3sSGRY5QgYrXgRZSV84nMigfCN36SSVSmyV96M04kxvWNq6XpMU/yWPkGw/87hEdOBTys+2gSuyE/nPeNjMrMbEOsVcrzN2C/LJFqvD95drrDk3HcTwpW0/SOF/LB5SQO5eWgaaUhVUMbQTSmIxdevrfWd2+jyGmthO3gJSJ5nYisjE/fcpRGVqlXmPfKG5LIwLUrBSYcIOTEj6NZ2wYKtMlQ9q0sAmK0+m8KzOog== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 13, 2023 at 08:47:21AM +0100, Christian König wrote: > Am 13.03.23 um 00:40 schrieb Lorenzo Stoakes: > > This function no longer exists, however the prot != vma->vm_page_prot case > > discussion has been retained and moved to vmf_insert_pfn_prot() so refer to > > this instead. > > > > Signed-off-by: Lorenzo Stoakes > > Reviewed-by: Christian König > > Feel free to add my acked-by to the other two patches in the series and > upstream through any branch you like. > > Alternatively ping me when you get rbs for the first two patches from the MM > people and I can push this upstream through drm-misc. > > Thanks, > Christian. Thanks, much appreciated! I'd rather go through mm if possible as Andrew has already taken for mm-unstable pending further review + that's easiest for dealing with any mm feedback. P.S. apologies for dropping the umlaut on your name in initial patch, I really need to sort out my terminal which got horribly confused by non-ANSI characters :) > > > --- > > drivers/gpu/drm/ttm/ttm_bo_vm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/ttm/ttm_bo_vm.c b/drivers/gpu/drm/ttm/ttm_bo_vm.c > > index ca7744b852f5..5df3edadb808 100644 > > --- a/drivers/gpu/drm/ttm/ttm_bo_vm.c > > +++ b/drivers/gpu/drm/ttm/ttm_bo_vm.c > > @@ -254,7 +254,7 @@ vm_fault_t ttm_bo_vm_fault_reserved(struct vm_fault *vmf, > > * encryption bits. This is because the exact location of the > > * data may not be known at mmap() time and may also change > > * at arbitrary times while the data is mmap'ed. > > - * See vmf_insert_mixed_prot() for a discussion. > > + * See vmf_insert_pfn_prot() for a discussion. > > */ > > ret = vmf_insert_pfn_prot(vma, address, pfn, prot); >