From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80E6C7EE2C for ; Thu, 18 May 2023 01:35:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3EEF8900004; Wed, 17 May 2023 21:35:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 39EA5900003; Wed, 17 May 2023 21:35:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28D42900004; Wed, 17 May 2023 21:35:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 154AC900003 for ; Wed, 17 May 2023 21:35:39 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CD580803D8 for ; Thu, 18 May 2023 01:35:38 +0000 (UTC) X-FDA: 80801658756.29.17588C5 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf27.hostedemail.com (Postfix) with ESMTP id 0402940006 for ; Thu, 18 May 2023 01:35:35 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684373736; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bO/gRdPC2r+jJ9RuTm1PHRx5VkNX2it3MThtTjFTSr8=; b=lZPVIPeoP92ZqeZdCOwimjIOWa7XghPIxZHby1nrbX5TZBvINAADnm31qKdH67VHmk+evw bg3IX2/FFwqIOitaQWrUCQd4D1q79AfTXuZ1s4Y7KgyyJsgKP1cF6Dr5nFd78jKxrLQF9V lVC8j86TaF98pDR7+5HoTdE+XAiW55Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684373736; a=rsa-sha256; cv=none; b=BBQU3sOOzApECiRb6WInpH4KL2CBIzt5fGg7ozYVai7YM4uMc3RNeDZTOdU/AJ1TRIWzjh CgXaIXsYvKg1VDwjCcgHXvXxhhOSgFgaBpQgEp5pSBg7czn+QaYZc6njsi9hfdqpsdrFV/ GL22cOOSGrUTj3Tg5Y/i7lr/fbqqzdA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QMC8x4VnRzTkgf; Thu, 18 May 2023 09:30:41 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 18 May 2023 09:35:30 +0800 Message-ID: Date: Thu, 18 May 2023 09:35:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 08/13] mm: page_alloc: split out DEBUG_PAGEALLOC Content-Language: en-US To: Andrew Morton CC: Mike Rapoport , , David Hildenbrand , Oscar Salvador , "Rafael J. Wysocki" , Pavel Machek , Len Brown , Luis Chamberlain , Kees Cook , Iurii Zaikin , , , , References: <20230516063821.121844-1-wangkefeng.wang@huawei.com> <20230516063821.121844-9-wangkefeng.wang@huawei.com> <20230516152212.95f4a6ebba475cb994a4429f@linux-foundation.org> From: Kefeng Wang In-Reply-To: <20230516152212.95f4a6ebba475cb994a4429f@linux-foundation.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: et4krcq7j3z6c8zgfnpprxgjxfdentuz X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0402940006 X-Rspam-User: X-HE-Tag: 1684373735-949757 X-HE-Meta: U2FsdGVkX1+/H/e36wQytg2c3tlgdOEBnzfX2IdLXOSIP/8F63i1uXPC5OvR+ZoaApGPQoe1Uace/feUdFZa4yszseQF0YbIqajyGpZBiQrv9yDWPSByDH/4gx5eym5dsFLrotMk6f/hPzwLO00zET8bLY3maw5raY8n8sH6qu7BU/bKhpjI+UWkFO2O/mSamfAwlWQcd5BXsIXMBh+2FwZ59+VdANnD6BgQNbyFxCfiPJeNjUy3O++ewzbpgCDS0/tTALDBBK6Bngj7lsAsuFvGL5qFxxcaW3yqt9Nl1xvFt4zYsNBD6GVsMuIKF8IQTOkRuRfuxZcqRYXrOEmuCBRw/W3d05tyX+wG6prkYeDFQvYxjC6CbZyhcvivtWvsIcQ6RCMpcykY/jLwMWdq1qAd9JIQbgnqQ+yjD102TsuEX2k7d2HKJJNFAqZ62xhKngdEeJpWPpZ46Vkpz5LG+kNoYqZlkWl6SilC0IswZa6G8ZZf7Q+ww7MOaxSQOkjgVqh3TuNzgC2zOXKkb7nA9AjpVNn3HmFMLaZ3t1GHZ2tMNshr6j8qt2ij0wKFbIgvWSzj4HpjcoJ2lEgy/DmRB+pLVEUuswBsmhX7jzzuel1doOmF6qA4DaP2tKB3b5qR9dvZkxxkeT9Zz1IluaCYMb2HJDpWNg6x8kcLh54yEowBR6H0G+nmCFEW9MOOffiJBpe5U7TPxJF+lvQkiIu8SN3XmPeNVFr9U6J+qRrpRgO6EZ+GJgIgZ3LeI0MHfRv/fsW99fQoYVQbx6fYAMK9iaAwE4v6fqtpkruVipfVsodko7O8Q4EMwFu1r//8p2IdIlQK/mTibi4yO3T3Hd+B0WDRL5UIUqowKBycu/tLPXwg4zQSzAJuL3Ltg2/Yffxgk0bfNLGg7Xm0xxdHdXkH2TOig5Yykl21Oj5YWnlLk8JbGi38LvxAMakTVWoM34Yoc1Shdewa7LAgehjOLgK 7k1lBenA AVyu84/QJM7vdQU2k4XhVPJ+aGU9LMBBC4XfNtAIGatQUobNTuw2hY4IWbPZ+glO4IF5dE7zX6k7frtxSBWEWVHCt7IRq/gjDh5hSHZCAz0U6yQP+BBwKwQ1Of0QVZGnmtXHNhsF6Q/FvwW+NIngOK/nI/AJNvW/su0EWsytq/gVWjaN1q3HN2YYiazehyHCxZbZGySGBj8puhaY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/5/17 6:22, Andrew Morton wrote: > On Tue, 16 May 2023 14:38:16 +0800 Kefeng Wang wrote: > >> DEBUG_PAGEALLOC >> >> mm/debug_page_alloc.c | 59 +++++++++++++++++++++++++++++++++ >> mm/page_alloc.c | 69 --------------------------------------- > > and > > FAIL_PAGE_ALLOC > > We're irritatingly inconsistent about whether there's an underscore. > > akpm:/usr/src/25> grep page_alloc mm/*c|wc -l > 49 > akpm:/usr/src/25> grep pagealloc mm/*c|wc -l > 28 All the 28 pagealloc naming is from DEBUG_PAGEALLOC feature, they chould be changed to page_alloc except the cmdline, but it will lead to long function name and don't gain too much advantage, so keep unchange? $ grep pagealloc mm/*c mm/debug_page_alloc.c:bool _debug_pagealloc_enabled_early __read_mostly mm/debug_page_alloc.c:EXPORT_SYMBOL(_debug_pagealloc_enabled_early); mm/debug_page_alloc.c:DEFINE_STATIC_KEY_FALSE(_debug_pagealloc_enabled); mm/debug_page_alloc.c:EXPORT_SYMBOL(_debug_pagealloc_enabled); mm/debug_page_alloc.c:static int __init early_debug_pagealloc(char *buf) mm/debug_page_alloc.c: return kstrtobool(buf, &_debug_pagealloc_enabled_early); mm/debug_page_alloc.c:early_param("debug_pagealloc", early_debug_pagealloc); mm/memory_hotplug.c: * Freeing the page with debug_pagealloc enabled will try to unmap it, mm/memory_hotplug.c: debug_pagealloc_map_pages(page, 1 << order); mm/mm_init.c: debug_pagealloc_enabled())) { mm/mm_init.c: if (debug_pagealloc_enabled()) { mm/mm_init.c: static_branch_enable(&_debug_pagealloc_enabled); mm/page_alloc.c: * page becomes unavailable via debug_pagealloc or arch_free_page. mm/page_alloc.c: debug_pagealloc_unmap_pages(page, 1 << order); mm/page_alloc.c: debug_pagealloc_map_pages(page, 1 << order); mm/page_poison.c: pr_err("pagealloc: single bit error\n"); mm/page_poison.c: pr_err("pagealloc: memory corruption\n"); mm/page_poison.c: dump_page(page, "pagealloc: corrupted page details"); mm/slab.c:static inline bool is_debug_pagealloc_cache(struct kmem_cache *cachep) mm/slab.c: return debug_pagealloc_enabled_static() && OFF_SLAB(cachep) && mm/slab.c: if (!is_debug_pagealloc_cache(cachep)) mm/slab.c: if (is_debug_pagealloc_cache(cachep)) mm/slab.c: * To activate debug pagealloc, off-slab management is necessary mm/slab.c: if (debug_pagealloc_enabled_static() && (flags & SLAB_POISON) && mm/slab.c: is_debug_pagealloc_cache(cachep)) mm/slub.c: if (!debug_pagealloc_enabled_static()) mm/vmalloc.c: if (debug_pagealloc_enabled_static()) mm/vmalloc.c: if (debug_pagealloc_enabled_static()) >