From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38BDBC6FD1C for ; Wed, 22 Mar 2023 14:50:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDDF86B0071; Wed, 22 Mar 2023 10:50:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C8D816B0072; Wed, 22 Mar 2023 10:50:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B7C956B0075; Wed, 22 Mar 2023 10:50:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A8DAB6B0071 for ; Wed, 22 Mar 2023 10:50:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 853C9A01BB for ; Wed, 22 Mar 2023 14:50:30 +0000 (UTC) X-FDA: 80596820220.03.A719E51 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 54C0640004 for ; Wed, 22 Mar 2023 14:50:28 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IO3cQVGF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+iAL7cCR; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679496628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V/1b+lUImqchwctHYvwFdftZc6h6aA5n3zMAKNVMaV4=; b=ePzoxaN0JTsk31qyd5y1qGQQhJibXKzcCY7cJJq9okNy07AM2z16/eXhDpocBMRFWFgph5 aefvJYsErB5fEdfGrOujvxWkjql6YndpFiSoJSX3GvZNMqpqWakPMVGtElQEcQnw3DI/fL eEIP3Jf4OFp5RfVBlbhgZGVsoUoQxjE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=IO3cQVGF; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=+iAL7cCR; dmarc=none; spf=pass (imf07.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=vbabka@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679496628; a=rsa-sha256; cv=none; b=Cts82Qts86IjtZBwMtGpJp7aOCtL8KhkjrFsZoOcgzuabPJ+46ATUx60Sb/XCXVr7g+WoP svruQU7zaT4zCpltwAOJ6wmyn1V6qmpq/GKCMwF2ObYg5vB+l6c8RYgZwvsHnQmCoki1Tm GUGWcqZk/wj9waT0Am1hUQT7lv4zfnw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DF90B20ED8; Wed, 22 Mar 2023 14:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679496626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V/1b+lUImqchwctHYvwFdftZc6h6aA5n3zMAKNVMaV4=; b=IO3cQVGFlvqDW6ZyGcdGTEGcrVoU+lFnGGdVxdblELxXQ8C+7Mx9vYTG9ZyP81FIx3wFYP NxKky5I0KbMgrgW+ZD7PthJn5RhNsYe2ioG0lh81ggFZZtzGim+qv+SCd6xX6OgJpv0PFH zC5SdKHQnt/Ky7F5U6F/EeVl+2J6anY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679496626; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=V/1b+lUImqchwctHYvwFdftZc6h6aA5n3zMAKNVMaV4=; b=+iAL7cCRrrBwt1PYzay5Usw9GyrCJmiAwc0v+DILaDEAHuDT3a+KJhTUXdWebqT/FpMVOq OK80Ln6U6IIYANCw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B5685138E9; Wed, 22 Mar 2023 14:50:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Ch52K7IVG2RZNgAAMHmgww (envelope-from ); Wed, 22 Mar 2023 14:50:26 +0000 Message-ID: Date: Wed, 22 Mar 2023 15:50:26 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 05/14] mm/page_alloc: rename page_alloc_init() to page_alloc_init_cpuhp() Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-6-rppt@kernel.org> From: Vlastimil Babka In-Reply-To: <20230321170513.2401534-6-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 54C0640004 X-Stat-Signature: 76qrn68imjtckzufpre4pucpp5rg6xq9 X-HE-Tag: 1679496628-278114 X-HE-Meta: U2FsdGVkX18x++flERf7BidSnJTfeNDuJlRsZ9X97NN418ewVB6GSbFNm3luANF3dgLRaj1NgGyJl7ZiD0IlrJbKuoV7UF1WaMBkBZTELQ2vXLMzOZwMqKdWH4YPZeoGf4kHWjs0NS4ApgmEC2CxJD8k/jna2gdHVKrsSiP5Me8T7yJhm5jvlv206slgnxVaIeumyzlIIytFCQvt3FkNiRU6UjDcH1RdnX2xU+Fu5q4LOBWNtjfy8Oh6PstCRg3pbZ0Vh0f9Rb5DL3zQLIlJwD0OV0y+hmzztSvi2Hte3naxIaqgvs2+Lgvmjdf6TUxUMAnm8uI9q/h4+zXFoFPi0T9z3TjnVmo/B3zLOTotqvaKBm5T55A1zgmRX/nu+FnDAuBMHy3RBdIHB6JUad87SQ7SndkmeMHg2/UIIWpVuM1AY4diasyTF9cRAjDjG5FlH+HOK3H1VegpwEwgqZZnaXf3oedZxWuVK9hD+GlQZ7eMEH5aZ5CK0PNmU+GcLIskOC439ltDmiWIONKmx6yzW9EDlZ819ZrUr42CDHtcNJa2OUGrRQpCDlJhGQS9t79kviVmUIqgepleuyIN4z5dgwocWHgdXCGVDX8IPrUjYYtM9RIn63R3OxmL4QUDkxf+Q20QzwHR7b0sXpQgyFTe+PgP++NVZPvpl6zyVfz2dfgywhaCdW05Z5wUWJlmnRS8RizmTVGH7SfcPPGQYdZ+ThoydYgqq+OvVmvLZhjNwhCg+p7YrkRsHhvpUjCCZ+/P9vDD2wuYA5jmDKu4o59jmPqTgi0EvZWKl/UlvVlHKCMWKrX+ZIAq9zeTv2qpWO0Bf9h7imY/o2ZI9FkZuEWi+Fym2VpkdPit3cCDFsEK0NCE9mgTrZbldpFyeC/s9yRwSs0UsY4sY5CaCdwHoCbINYF8aNBB3Zr3r7ElD+FRChxjsa+Ds3YlHCDpgL3Xya4DQAncNozv2yRAZI1G59B fM3B2mMD 8pGtYBPswmZGqtwOcL0tkkRN8hXCsDi+lcIYUU128nBQKWjZpO3yLmdoaLNk/Y3wUAAg9GVeUIVD2uRpMaPGBHBdRFafoO61arfyJm6iqxn0mi5RddTNFcxiL83+5TDtB70CJRVL2R98tcOHb0XCPJi60zIEYNNwhI51zF+loNrTC3JJLvE0Oc6bv/BYbsR6+RPymFf94WVdhsgiBxULTikW8pSP0hhUo5EueFd4tSPFvlENcTf7ifiDJMAL0x+RiReBC/CaY045+ZmOaoBQYgqBDQJUn+r0jCDMVBZQz8RjnIYrFD+6jy3WGdurOIQM88M8SsMq1oL5AGTl0cWFL1RQAgg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 18:05, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > The page_alloc_init() name is really misleading because all this > function does is sets up CPU hotplug callbacks for the page allocator. > > Rename it to page_alloc_init_cpuhp() so that name will reflect what the > function does. > > Signed-off-by: Mike Rapoport (IBM) > Reviewed-by: David Hildenbrand Reviewed-by: Vlastimil Babka > --- > include/linux/gfp.h | 2 +- > init/main.c | 2 +- > mm/page_alloc.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 7c554e4bd49f..ed8cb537c6a7 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -319,7 +319,7 @@ extern void page_frag_free(void *addr); > #define __free_page(page) __free_pages((page), 0) > #define free_page(addr) free_pages((addr), 0) > > -void page_alloc_init(void); > +void page_alloc_init_cpuhp(void); > void drain_zone_pages(struct zone *zone, struct per_cpu_pages *pcp); > void drain_all_pages(struct zone *zone); > void drain_local_pages(struct zone *zone); > diff --git a/init/main.c b/init/main.c > index 4425d1783d5c..b2499bee7a3c 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -969,7 +969,7 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) > boot_cpu_hotplug_init(); > > build_all_zonelists(NULL); > - page_alloc_init(); > + page_alloc_init_cpuhp(); > > pr_notice("Kernel command line: %s\n", saved_command_line); > /* parameters may set static keys */ > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index ff6a2fff2880..d1276bfe7a30 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -6383,7 +6383,7 @@ static int page_alloc_cpu_online(unsigned int cpu) > return 0; > } > > -void __init page_alloc_init(void) > +void __init page_alloc_init_cpuhp(void) > { > int ret; >