Re: OOM killer changes

[Vlastimil Babka <vbabka@suse.cz>]

On 08/19/2016 04:42 AM, Ralf-Peter Rohbeck wrote:
> On 18.08.2016 13:12, Vlastimil Babka wrote:
>> On 18.8.2016 22:01, Ralf-Peter Rohbeck wrote:
>>> On 17.08.2016 23:57, Vlastimil Babka wrote:
>>>> Vlastimil
>>> Yes, that change was in my test with linux-next-20160817. Here's the diff:
>>>
>>> diff --git a/mm/compaction.c b/mm/compaction.c
>>> index f94ae67..60a9ca2 100644
>>> --- a/mm/compaction.c
>>> +++ b/mm/compaction.c
>>> @@ -1083,8 +1083,10 @@ static void isolate_freepages(struct
>>> compact_control *cc)
>>>                           continue;
>>>
>>>                   /* Check the block is suitable for migration */
>>> +/*
>>>                   if (!suitable_migration_target(page))
>>>                           continue;
>>> +*/
>> OK, could you please also try if uncommenting the above still works without OOM?
>> Or just plain linux-next-20160817, I guess we don't need the printk's to test
>> this difference.
>>
>> Thanks a lot!
>> Vlastimil
>>
> With the two lines back in I had OOMs again. See the attached logs.

Thanks for the confirmation.

We however shouldn't disable the heuristic completely, so here's a compromise
patch hooking into the new compaction priorities. Can you please test on top of
linux-next?

-----8<-----