From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6D01C433EF for ; Tue, 21 Jun 2022 08:45:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54C876B0072; Tue, 21 Jun 2022 04:45:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FB896B0073; Tue, 21 Jun 2022 04:45:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E97A6B0074; Tue, 21 Jun 2022 04:45:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 335B16B0072 for ; Tue, 21 Jun 2022 04:45:39 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 014DF1069 for ; Tue, 21 Jun 2022 08:45:38 +0000 (UTC) X-FDA: 79601609598.26.ED274CA Received: from out30-42.freemail.mail.aliyun.com (out30-42.freemail.mail.aliyun.com [115.124.30.42]) by imf27.hostedemail.com (Postfix) with ESMTP id E306D4001C for ; Tue, 21 Jun 2022 08:45:37 +0000 (UTC) X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R921e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045170;MF=baolin.wang@linux.alibaba.com;NM=1;PH=DS;RN=8;SR=0;TI=SMTPD_---0VH0dWR7_1655801131; Received: from 30.97.48.73(mailfrom:baolin.wang@linux.alibaba.com fp:SMTPD_---0VH0dWR7_1655801131) by smtp.aliyun-inc.com; Tue, 21 Jun 2022 16:45:32 +0800 Message-ID: Date: Tue, 21 Jun 2022 16:45:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH] mm/damon: Use set_huge_pte_at() to make huge pte old To: SeongJae Park Cc: akpm@linux-foundation.org, mike.kravetz@oracle.com, songmuchun@bytedance.com, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20220620172742.48766-1-sj@kernel.org> From: Baolin Wang In-Reply-To: <20220620172742.48766-1-sj@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655801138; a=rsa-sha256; cv=none; b=mUL92WMEeEmrRxraQ4uamu4CcsD8Y26cISP5XxzPlVS+IX52vQcJ1gOCrRBkVmMRS0Mhl5 IjTq9oVCY5xqVUMVOHSNa0YMGd7wt+sRzLFbwCichYc6DzauQtfJ1nNJ69SyKvPKrvJJaw OsdMMohKCEZrOQ3ssB1YewzGCuBZ58w= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655801138; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=g/TkgiA+Wduhh71+er1XDbrfdmWhycLAX2sQZD7rUio=; b=qJ96e3obBbQuBrm2XV5KD9VVTli3IO7ZEXs2WNqiWeCsm/swpnaJJcXKQwbXjl4VV297VW AI6uc34bI8sNs7ZzSYfi7vAElCKJ1n+r5ZLT2QzCa6ZjsSHuc8g38xOz0AE3xAK0fvyo7u hQDpxTDNW7i/9m53sPWwoS2sSzJ2luk= Authentication-Results: imf27.hostedemail.com; dkim=none; spf=pass (imf27.hostedemail.com: domain of baolin.wang@linux.alibaba.com designates 115.124.30.42 as permitted sender) smtp.mailfrom=baolin.wang@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com X-Rspam-User: X-Stat-Signature: 7jfn4yohgc1n7s9c4nth5d649655zuzh X-Rspamd-Queue-Id: E306D4001C X-Rspamd-Server: rspam08 X-HE-Tag: 1655801137-432333 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi SeongJae, On 6/21/2022 1:27 AM, SeongJae Park wrote: > Hi Baolin, > > On Mon, 20 Jun 2022 10:34:42 +0800 Baolin Wang wrote: > >> The huge_ptep_set_access_flags() can not make the huge pte old according >> to the discussion [1], that means we will always mornitor the young state >> of the hugetlb though we stopped accessing the hugetlb, as a result DAMON >> will get inaccurate accessing statistics. >> >> So changing to use set_huge_pte_at() to make the huge pte old to fix this >> issue. >> >> [1] https://lore.kernel.org/all/Yqy97gXI4Nqb7dYo@arm.com/ >> >> Fixes: 49f4203aae06 ("mm/damon: add access checking for hugetlb pages") > > As the commit has merged in from v5.17, I guess it would be better to do below? > > Cc: Yes, thanks for reminding. Hope Andrew can help to add the stable tag when picking up this patch. > >> Signed-off-by: Baolin Wang > > Other than that, > > Reviewed-by: SeongJae Park Thanks.