From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6D90C4707B for ; Thu, 11 Jan 2024 03:35:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 548DA6B009A; Wed, 10 Jan 2024 22:35:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4F7946B009B; Wed, 10 Jan 2024 22:35:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 398116B009C; Wed, 10 Jan 2024 22:35:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 2718F6B009A for ; Wed, 10 Jan 2024 22:35:05 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id DEAD31A0B51 for ; Thu, 11 Jan 2024 03:35:04 +0000 (UTC) X-FDA: 81665614128.08.963D278 Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by imf16.hostedemail.com (Postfix) with ESMTP id 095F818001D for ; Thu, 11 Jan 2024 03:35:02 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SigsKEqd; spf=pass (imf16.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704944103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EhHrSgkO7aZS8gS4QgDVlSfOXoB9Gg7ntyWbIFGpcNg=; b=G3XMgsa20TWNFfZHMhIWB7y7Ru1uEwS4zIDOgBVQlgmnaeR0GyXctAb9ixoUvPesXtzMFF 3K0AxzZM5xSp8OuTcR8V2/WBo9vHvpH5U02MieLCxXhtP/zZIEi6BHolnk3W8hqkTwS3rm lZBnMShSRvWJPyRKRvrd/iU2rni9/Pw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704944103; a=rsa-sha256; cv=none; b=3RK5233r1EF/vcqq87hweFd9JN2dSYzryCkVHXONxKN5j4Vs62+7t13roxP72CuTpfjL/g KgLidOJ6w1PtWVRAtYfuRSNZMggqLBFYZn2Wvtgd3WwVKUzrRdHA8kWCzDbc1B+K2Har86 kQNzziR9Cs9JNjhiLSMWxkuTYybkLxc= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=SigsKEqd; spf=pass (imf16.hostedemail.com: domain of gang.li@linux.dev designates 95.215.58.175 as permitted sender) smtp.mailfrom=gang.li@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1704944101; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EhHrSgkO7aZS8gS4QgDVlSfOXoB9Gg7ntyWbIFGpcNg=; b=SigsKEqdmubuTyBpozylpZPLXPD8HcrWElSpfXXYbNRHuzskLowdEcJ/ElaFn35L3+LB79 91ynDlfmbds/omwHe0ohPC5FxscOWaDoIXDc8LGXUfY26QdnJdtCjpvSaGUfAZ1vLxNtmS l1z7T/zA0iklA3Xm/0/P+8EHrRWIYcI= Date: Thu, 11 Jan 2024 11:34:32 +0800 MIME-Version: 1.0 Subject: Re: [PATCH v3 1/7] hugetlb: code clean for hugetlb_hstate_alloc_pages Content-Language: en-US To: Tim Chen Cc: linux-mm@kvack.org, Mike Kravetz , David Rientjes , linux-kernel@vger.kernel.org, David Hildenbrand , ligang.bdlg@bytedance.com, Muchun Song , Andrew Morton References: <20240102131249.76622-1-gang.li@linux.dev> <20240102131249.76622-2-gang.li@linux.dev> <46769d44703b2f8d2e279d6e95db960c8a87e39c.camel@linux.intel.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Gang Li In-Reply-To: <46769d44703b2f8d2e279d6e95db960c8a87e39c.camel@linux.intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Stat-Signature: seqjbqmohue6jgogdzqktrqojgxnguim X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 095F818001D X-Rspam-User: X-HE-Tag: 1704944102-791080 X-HE-Meta: U2FsdGVkX198ArFqsu9qQmFmGdO3HaXuP06ks7HAWAI6r+zCpaQ1IdkMmeJlllIoPb7RfjYkIVdikmnvC7gtR/v/scAozOj+CQcXI9S2kfVz4TyAZcfG4znBPVpNJnX4FhtBmFQjsJ8ZjK/8GnubsfmIK1Ijkxtg3BfHqjQa0LBpYJrgHbqosjEVC/FWCAACHoAUUzrjsGYifKY8WOiN+qUfFv9ldsvDTgFI4sE/gsvYmL5fKjl/VllWFaOMzW8D5NCVanUASLEuXnrJR9F7pqoacZhU7uIjDDBeEYUj72BS/6jIYOm8n5SjanjfKBT7lD0z+LeC7BSiGeBtnjKmuWYCBdMqqRwGQbgLErjxcdOgI98wtJvLuxjH9LWf9BG6KB4gm90DU62fEGsLi0Ni44ItCzAvOc4+9gWeOvtCNeAJU25vjk4djzQr7UMV1kZGl0kYOLut10UnlF4zUmGFeAOJT4zESCVUpfMAim2ZDJhF86zhIhoEvQhAVz5joGOyfemNfVh+o0Op09rVbpOF4A8O0Z+YGFs4tLt7XRezO3tskdRWPVVic/8XfpjW35zh6uM9c0k3HjKdc9po2BG4gcvPLboK+W21SzlSXXajuAW0knhVF+FrvBiabQMRM023ZSKk6SGDFWMWyzu5zHfw0M8PDMYObBwwSKq3iPmEdD86dHfxBX4nYrsKsIVsRhp1lnQVVn5HA9GLwppBTOuESMNvcvBSeMhhlqGWYQ1HcLJJJranrncA/KbJCL3zKdSLbXbsnhTMBmHjP6Vapjen6FGNgb4MUyszHa10Ajdn2n9bO3QLY6zFh2wbmu/Daie/4WRhRYGI6cu5kyxP0hXUoVd4zBQVD46stKmZUNPEPpDkqPCEotlib3BtmDwCHTRid6zgBHx1loy++ML2bb186zvtf4+kEfgdw9cndbxdCCxz6hugCuSoc4K1cD8xKsma5qSLTHq6KqXuguEX/t4 FNxit4z3 qGTFla3JFMnYu7F4ojAseWv4VMN+U6xV1iQbmWCUaG+yKEF8fQG1Voy1LyuYuNa/Vqe5ERdPhA33BPFKjfYPdRSpLzNSh9k/46ShPE7n+N1PpNk2Q/1qf6r7Z5/cIk6ZpyMIiGl69MS+LLWjEWPE/2kra9tDHY0Ffw7EC X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/11 05:55, Tim Chen wrote: > On Tue, 2024-01-02 at 21:12 +0800, Gang Li wrote: >> The readability of `hugetlb_hstate_alloc_pages` is poor. By cleaning the >> code, its readability can be improved, facilitating future modifications. >> >> This patch extracts two functions to reduce the complexity of >> `hugetlb_hstate_alloc_pages` and has no functional changes. >> >> - hugetlb_hstate_alloc_pages_node_specific() to handle iterates through >> each online node and performs allocation if necessary. >> - hugetlb_hstate_alloc_pages_report() report error during allocation. >> And the value of h->max_huge_pages is updated accordingly. > > Minor nit, I think hugetlb_hstate_alloc_pages_errcheck() is more > descriptive than hugetlb_hstate_alloc_pages_report(). Thanks! This looks more intuitive. > > Otherwise > > Reviewed-by: Tim Chen >