From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDE57C48BF6 for ; Wed, 21 Feb 2024 07:12:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52E156B0075; Wed, 21 Feb 2024 02:12:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B5056B0078; Wed, 21 Feb 2024 02:12:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37CA36B007B; Wed, 21 Feb 2024 02:12:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 217A26B0075 for ; Wed, 21 Feb 2024 02:12:18 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id A668C8098A for ; Wed, 21 Feb 2024 07:12:17 +0000 (UTC) X-FDA: 81814942314.12.D6A95D9 Received: from out-188.mta0.migadu.com (out-188.mta0.migadu.com [91.218.175.188]) by imf12.hostedemail.com (Postfix) with ESMTP id 23BEB40019 for ; Wed, 21 Feb 2024 07:12:13 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Con9hWh/"; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708499536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WSnP/0YdPJWcrqeadRLJ8c8YxbEnoLRUfscJ82NzOdg=; b=NtbKfM6+PRM03WEzfyHU1HpkqK+0rp5ApgT4RRal9UoZgPgbM8cOw8sNfCiefo8xECF0R6 qIaPiJGsbPoI6GiYTpC/6jCmOWHYHuYe88FHR3DZzZHG2XmZt9IAIYwenr/ZZAqDxuRXVX Bo5pBZg0nyh6mS7AzsqJWruHBf5OxvQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708499536; a=rsa-sha256; cv=none; b=vQbuin4ksYmZAhzRRxzRoDJabtUurnQjpAJeoW2dFttHM6u3rm3+Vzh4e+Dt+IgnoGb4KF SCoTvRoY9ajO6OO4onSKS9his+r4HfP35SNAaQSfDXaYqZqk2qv2O5FfJwi9JhO1bCXrKd lgKnZK03GDrHUvb4bQWDoDLkhNwvJOw= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b="Con9hWh/"; spf=pass (imf12.hostedemail.com: domain of chengming.zhou@linux.dev designates 91.218.175.188 as permitted sender) smtp.mailfrom=chengming.zhou@linux.dev; dmarc=pass (policy=none) header.from=linux.dev Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1708499529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WSnP/0YdPJWcrqeadRLJ8c8YxbEnoLRUfscJ82NzOdg=; b=Con9hWh/qgjDQEXO+YEOr5FjUtVBPnumYSQTLumrCqVYXjQm/Ebok6lUO0t/I6ZhVZnaag CWaLu905U7Jrv9AR4XCR2JpU8eUzKGUZB7ttzDkvJMOVCIx/geOWiWsyqF8q52gL8LNGrC r2a6Dzgmpy6lJIS0WjUPJX8XDFYqSag= Date: Wed, 21 Feb 2024 15:11:33 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/3] mm, slab: deprecate SLAB_MEM_SPREAD flag Content-Language: en-US To: Vlastimil Babka , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino Cc: Zheng Yejian , Xiongwei Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Steven Rostedt References: <20240220-slab-cleanup-flags-v1-0-e657e373944a@suse.cz> <20240220-slab-cleanup-flags-v1-1-e657e373944a@suse.cz> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Chengming Zhou In-Reply-To: <20240220-slab-cleanup-flags-v1-1-e657e373944a@suse.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-Rspamd-Queue-Id: 23BEB40019 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: 3akskiu7en6cgs5rtsfu15rmi3hzorci X-HE-Tag: 1708499533-962205 X-HE-Meta: U2FsdGVkX1+jF8ezZm0O2nSC1ZDJS+ye0SFsvPxW5qzthTmp5dw7xVDfsuDXVNoX1o3tq98baaIn8yfUsNAgYCv/GhvgcgIpU96Eljewv2YCrNrKcSfaXxpRHMxt4ngCBfPxqPSg4NxwbjFTeKOUAzNiVxUViqRnRMI+jZ0WSBJaokOFZ752MPu7W/cb36rL/8P0boUnXNCaPyMIi17UExBNHhdOhW33bKNB5lzFFxEG5faYdEECYdraol8qbrUrrI1/MUnSNvZnX8Y4dWRagZcXoA/kIQ3c5eUlo9GSEdZa7KNjtE4c5M5oHTLvaRYhGRRqAE6Gk/6J0mnHmvJTDBqQKEE1+MVypdHXHOX4/Zo3+BNQWaX5MQlSXPFrTF6RfVjohNqYKS9sAArUScuawvtc59afFcFfD6LXYHbrqqCYOGAh6XlTcHe4WMvfbYBLxJLFLOGVGNhjfuMARrWHMCodd+AvCH10EIk6GPFPPwdDfOofmDEUUVwdXqPJbUJcuFfmK5AJwtXhLHOrxzxeiXRQrKUwNC4rxNCl2l9PjqIWOsLra/ys2Pp8Y40xkUaBegdawREUz5qdANO6721n54ZZHNdBjBci56uF0xxOJ5svGK/trJ628b6vTUTCoImCDFPV3iqQdrcvZq0dUbOgjw97W/o0BCYhSqJQGeJhjA2BwEYuIMJN1QZaxr1MQKsNeQXnnC0dNOHc5RpMCn+6Mwcd/XL6sanHaVKByYkeM4hm7cXCoXg/hGuzLyAqoRa35Wqjp70KAT5rnaII0aJovBEHJ+r5Eu2hRQpXIu5UoPULdugrvVnK6o0ixwgnI3e/64tAJnWU/XkVBEtjvEngwB75xDqQ6V9oDGPKbhGGooHa6JozC0kDRAhQKo9bB7nsUCLyDXcmsCZ7BA4W2NdfG330x9OoKNpil0OwyNvAQdcTyQ2S9UyMoQt9d72QOUKF5aTWdzEYgkKlulZPYmL YuzpJ93I 2fm+5PKmXgNRKC5lMSiZ7WKkxZ3oLCXSutDx4BY34jNS5L3j8A+mnFjceSCAQWjhmcRZ9aNxzoupza9OtsuwFzrKWVgLDgG2nA+nw5HF9KbYoeBar2DkiZLzAQ1zZBsG4p4lfgE12OcmNJ9BMdj5T/uf9D7abIeO+RNWLCLdj38xa1LKiDmiKbE0NSwoLYZJIKQH8TtE5mITaU9KmLnf6qjXxitJIbugqaVuHdegGZWHw4Bon6j3t0I2/IyZ+Omftu01TLICoOOpN4ovg+BmzOUISgawVchcMp+S+BGdNaCZhSiXc7I7ki+cuFWvEErmIw660 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/2/21 00:58, Vlastimil Babka wrote: > The SLAB_MEM_SPREAD flag used to be implemented in SLAB, which was > removed. SLUB instead relies on the page allocator's NUMA policies. > Change the flag's value to 0 to free up the value it had, and mark it > for full removal once all users are gone. > > Reported-by: Steven Rostedt > Closes: https://lore.kernel.org/all/20240131172027.10f64405@gandalf.local.home/ > Signed-off-by: Vlastimil Babka Reviewed-by: Chengming Zhou Thanks! > --- > include/linux/slab.h | 5 +++-- > mm/slab.h | 1 - > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index b5f5ee8308d0..6252f44115c2 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -96,8 +96,6 @@ > */ > /* Defer freeing slabs to RCU */ > #define SLAB_TYPESAFE_BY_RCU ((slab_flags_t __force)0x00080000U) > -/* Spread some memory over cpuset */ > -#define SLAB_MEM_SPREAD ((slab_flags_t __force)0x00100000U) > /* Trace allocations and frees */ > #define SLAB_TRACE ((slab_flags_t __force)0x00200000U) > > @@ -164,6 +162,9 @@ > #endif > #define SLAB_TEMPORARY SLAB_RECLAIM_ACCOUNT /* Objects are short-lived */ > > +/* Obsolete unused flag, to be removed */ > +#define SLAB_MEM_SPREAD 0 > + > /* > * ZERO_SIZE_PTR will be returned for zero sized kmalloc requests. > * > diff --git a/mm/slab.h b/mm/slab.h > index 54deeb0428c6..f4534eefb35d 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -469,7 +469,6 @@ static inline bool is_kmalloc_cache(struct kmem_cache *s) > SLAB_STORE_USER | \ > SLAB_TRACE | \ > SLAB_CONSISTENCY_CHECKS | \ > - SLAB_MEM_SPREAD | \ > SLAB_NOLEAKTRACE | \ > SLAB_RECLAIM_ACCOUNT | \ > SLAB_TEMPORARY | \ >