From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BAC7C3DA61 for ; Tue, 30 Jul 2024 07:42:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 888216B0083; Tue, 30 Jul 2024 03:42:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8381A6B0085; Tue, 30 Jul 2024 03:42:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B1606B0088; Tue, 30 Jul 2024 03:42:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4830F6B0083 for ; Tue, 30 Jul 2024 03:42:20 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EBB0EA16AF for ; Tue, 30 Jul 2024 07:42:19 +0000 (UTC) X-FDA: 82395625998.26.453B262 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id C14D84000E for ; Tue, 30 Jul 2024 07:42:16 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FtrxyWm7; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722325309; a=rsa-sha256; cv=none; b=3ZJdQacXSST79mFamKwthRTw/uZxo4zsREJnpTqEsK3CXUolKEoB4WnCZIvbRSEjceyntd YEJN13v+p/Fhw47bYni84cnho1Ynbs+9oefNmxc4AaKr4X4fiTt6IkwnHxwXmFLAxxhNJB h8aVIceCsF5eM3G8PvE/NdCdiO/vCBw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FtrxyWm7; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722325309; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S8RveV1uJTCfZnT37PuWrWtx5mKe8dhsCwpmqzn6Z14=; b=y6gDND4fJRcOOPay/qPccF93AkOVYCzhGGodd6ni0OG/Dozi3Z7Tds22+z7mcY7RjWI8GY inklp+3t+uzH3nB568aE80YHSKotESbfjm7A9kyvecGoCFbmuyfV/2TK+SmG1u1BykK4cE FIGk0N554hESdmmB1wRgLuZXrXAY8QI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1722325335; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=S8RveV1uJTCfZnT37PuWrWtx5mKe8dhsCwpmqzn6Z14=; b=FtrxyWm7I2MdV0K+F//4O3CknzHsEC0dAXcdBPtSGSuNI1UV4yp4ryNsg+S+xPOiAKXvPP L9kpiEcM/BPt9v4a02UFVqMEezSf6psai0ejj9YhncgxBBvG6ZVLHC2WotgDpnUJLF0f8f esms7yx3DtjQucas23LTSyYmcFgzqcs= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-651-DJcO49rxOFWgAlTrE5U3DA-1; Tue, 30 Jul 2024 03:42:14 -0400 X-MC-Unique: DJcO49rxOFWgAlTrE5U3DA-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-3679ab94cdbso1870739f8f.3 for ; Tue, 30 Jul 2024 00:42:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722325333; x=1722930133; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=S8RveV1uJTCfZnT37PuWrWtx5mKe8dhsCwpmqzn6Z14=; b=Unf0yOE0tqktvkeQAYmAHQGAgzHjpPNSOy2CPR2RhBux+a0+DjhorUOMO2FA6Lp4V6 KAxl5y4LM3jaWSiEBJp1SVXhJfGNQLoOkaITlJLG3QSJ+/2ZctxkYNZwyrb18HRjaiu0 5fMHRgZSvwS+QG8g5ay0hTeTpr3Uuh4MKK1oBV27oUDK9CtZKTWD5M1suFoilgQNzbIG NohN1NPtgu29Pm+xzzFmQVvrCz6PZ2Wdv8PVuWFSkEpDCFcd50qy+4DiTEyyN/I8VNUL g30sKW/YlV9Q96ABovvyZoNBrq6mTLHCFPNYseo4ogFJsaOGYY/0/sUKCRN8LUCMWdC5 wQ6g== X-Forwarded-Encrypted: i=1; AJvYcCXyAJxtAtTqmdq4Fb8vlM69UXi2zs8OWNT+34IL9EidNRA16RWRlHJYNzkpnVqrLsY2Y1DjcgRLnXYgm0/sKDi9jY0= X-Gm-Message-State: AOJu0YxNracmSmsvM1ZA/GkFCIHzVkZWhA80M+ZD+854kyadDFPuTCR0 HivmorxX9EiDww1d3+DlL1pL7Q1DhgdT6eAw8JkkrBuYvIu9PznF5eLFsrgguFNhZqeUTM1fHB7 rBDJ8pOb9ysjDvy99ACHY3PadtmnHn6iC9Ff0nSQ3vAYBYaUK X-Received: by 2002:a05:6000:1861:b0:368:3789:1b6 with SMTP id ffacd0b85a97d-36b5d073e6emr7399910f8f.47.1722325333137; Tue, 30 Jul 2024 00:42:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEzDMPvQGrehooTlu8wRs1y4lwfZQWrVLYOvYzs+Hb5azjF/CxsHsDslP58+1IgunNhRbuTiQ== X-Received: by 2002:a05:6000:1861:b0:368:3789:1b6 with SMTP id ffacd0b85a97d-36b5d073e6emr7399892f8f.47.1722325332633; Tue, 30 Jul 2024 00:42:12 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:4e00:31ad:5274:e21c:b59? (p200300cbc7064e0031ad5274e21c0b59.dip0.t-ipconnect.de. [2003:cb:c706:4e00:31ad:5274:e21c:b59]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36b367c093bsm14160573f8f.18.2024.07.30.00.42.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jul 2024 00:42:12 -0700 (PDT) Message-ID: Date: Tue, 30 Jul 2024 09:42:10 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/1] mm: swap: add nr argument in swapcache_prepare and swapcache_clear to support large folios To: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org Cc: baolin.wang@linux.alibaba.com, chrisl@kernel.org, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, willy@infradead.org, xiang@kernel.org, ying.huang@intel.com, yosryahmed@google.com References: <20240730071339.107447-1-21cnbao@gmail.com> <20240730071339.107447-2-21cnbao@gmail.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240730071339.107447-2-21cnbao@gmail.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: q5mwatf81zridaghhzdsn38ama8rrr8q X-Rspamd-Queue-Id: C14D84000E X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1722325336-463695 X-HE-Meta: U2FsdGVkX18N3XdxE+4lTlkCy8OzSBsYdbFMe3zFjSBvl6fYdqeWQTY3Q/iB+Qsji+RPOMJ/44LbNgR4lwcVXAQIixx4Rze2bFWovUQkJoqMhYdq92ID/zmadV9hPoyAWPZYrIDEhTRVhmaWFmF4hor50CBFHubF8crU6aOijAkkDQUGpdxev5jvXKw3qEIGKYrYUS3Cy3IejoFSGW1+RTo8+MyjC6mMFSTa7KDqkJ2STuLHjaGRImazBURYct45R8XXNWtIMmTy0Ohnv6v007IqLIogGfSDFN18ty948beKA9oiRx06XVdWdA2xM1OCyTE/Xa2SmJx/z9jOiVRMC8lMpSBN+Gt+hxJXmNJwFRk4ITOOFzTL8PKoku5V0wBwsBRefqSdAUAJG6PAyLgAT1Vf11D+0oH/n7gyDsakorEFdcAMFmCRpGW7i7wHnPbub0qxN/28G5c0LXk9CHllNj+ZQLVhQv97mcsuLn1o3PpPMzh4tx84wEbfHJZ19KgonmJejqac+Q3TOUZoMqpUvN8zFMZeVyRQRA7UdDwtLae0qk8YJFCiA10SFqtD8p1AkyOT3BkPrNckuKQcVtTqrV/9mzR5PwCD2a7+Vj77nwGnHEfedt96mmUUOuaaaIGFflYIGhN8IdmzAPU33AndwDAOtBWknzxwkpmIpGBbLaWWBWdfIqyr3O91Uvcl9HmENIjoXshR03szvMM+/yka6dWSwTpy5Q9v/RlIN/P553O4nMFLbF3Xr8/fonq1AMIZ1Fz2tv1yotiXDgKuVh9X5Fv2R0cEd6dey6Xv7Y87IrhorNfPqsPiazM12w7t8vhxb62oPrxMkyKag+JuQJZh/JMsjzAUqx3WCRlED0kTrI8gtEOOeXERYNzRzOCILnvElhWoczaBT8iH5dgJBU/rTd+5CHD/8fooQNRExh5Kw6R0w5O3EJfWd9kBZfL9u/qMjsIrxVv14Lp6To7CK9N DtKOltGw QmdJaK8E6Mrnd2o4Jty93MY5uxBpPi/KkXneAEoEV4jsNQUj3v60UOlD9/ctuABv19HgU3k8vpfRgK/ZcxYnZw2K5QWvPoqXFq6q/nsl/vDlrybyrQajtv6Ttm3oSaEQk9zauMRYG2vIBrkoBnBiZHdkhcE3ITNR748wqtpvsuFQcwYY3hLkw2eh3Wf/m8oumVo6qG41inT3a5dki2YzwymOMlL50W5IpeKGONOZd0r8m8f3jy2+FkYIpeuergfp8q6CtDpmiQLc48wR3BcZq8BK8fXK6UYBtls/sMIakKZttH+1berRuR9GD3tp6IjZiSub6gseWF4jQQa1Wo36ntJCBOJS42pFYGFY0zdk3txcuxyVUtkRKwmcrsq/b+rAtrrt6IJ1cYjLYv6g4hotBpalJknIpfBePs/yRcobu89OlNoOX7xJ/jTNLbyFNnxr7DFeJDvjDIIZ98zrOFo98dvCTADbQn713UtKxgS8k/NA2liNIloIaRVMdWaae4ZBz5CUZ7NZhKtdScTIc9lgGkGbHzbD4MOXPwkrM7AWKv9BkoLw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.07.24 09:13, Barry Song wrote: > From: Barry Song > > Right now, swapcache_prepare() and swapcache_clear() supports one entry > only, to support large folios, we need to handle multiple swap entries. > > To optimize stack usage, we iterate twice in __swap_duplicate(): the > first time to verify that all entries are valid, and the second time > to apply the modifications to the entries. > > Currently, we're using nr=1 for the existing users. > > Reviewed-by: Baolin Wang > Signed-off-by: Barry Song > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb