From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D26DC54798 for ; Tue, 5 Mar 2024 21:56:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 25E006B0083; Tue, 5 Mar 2024 16:56:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 234A26B0085; Tue, 5 Mar 2024 16:56:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D6406B0088; Tue, 5 Mar 2024 16:56:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id F24456B0083 for ; Tue, 5 Mar 2024 16:56:16 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id BC2DB807C5 for ; Tue, 5 Mar 2024 21:56:16 +0000 (UTC) X-FDA: 81864344352.12.77527C9 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf11.hostedemail.com (Postfix) with ESMTP id 19D724001B for ; Tue, 5 Mar 2024 21:56:12 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fL42x8YF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709675774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=M4+ic2rqsHCqM2vW2ztqguoqjdqrHfTyc03rg5MCTEM=; b=mFtiI5xwRw5d4WWF8GyZNDnKCG3oc+Ysrzre8vfrMNNJ1G2FlS2QXqFtF8oeXK3cZW9rCv ZTpiROr0tCyczpeTDwV5o9IWDQ+6DFIf82zduU8IHg3ivjJMXg2t/d6RCwanm8RQ19TGY6 JeEWpMzzxtzeB22WKUX2qGq6O1qbjjs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=fL42x8YF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709675774; a=rsa-sha256; cv=none; b=I1mQD+POXZ7VMaxoBstNR+r8FC01bNkyCftX3wvaBqGG04WYuNG89kB7G8beH1mW1tXcC6 pohS+WFyvLvMT0DdD3uuLPXUlXjZhz96BlxlTFoCloEel6VUPwCcviKf8aEX7zCynS4vYq ErhDqKiinzzIbd7sgRCQAvRSPVBkY68= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709675772; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=M4+ic2rqsHCqM2vW2ztqguoqjdqrHfTyc03rg5MCTEM=; b=fL42x8YFxvOljGymbfggHTr57sGQwoOpKo5oCFLbW3u0JIYMvphN3lzOSth4qSeI01ZsW2 mAF5l3EWrA/5zLjf1CAB1pxQrTJz+bc/78fe9HqsZgfgYXE6JZwyEhThD8gmEo6PwSMkX8 iz0DeokiEfDDedbZzR79l+WLRGNQGo0= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-632-L1_PMm9UPrOq6-9lldo6NA-1; Tue, 05 Mar 2024 16:56:08 -0500 X-MC-Unique: L1_PMm9UPrOq6-9lldo6NA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-51325c38ce0so5562843e87.1 for ; Tue, 05 Mar 2024 13:56:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709675767; x=1710280567; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=M4+ic2rqsHCqM2vW2ztqguoqjdqrHfTyc03rg5MCTEM=; b=C7EeG6vLX5GQh+v1hcfuPhNLcCvAVOe2Tj/vdxKavwe3DfnNDApNwkD/9Ibab6RyWB LP9r0S9+kpvm3oeeRWYDqpfoZGrViVj0FMdntPOwyf98YJQIxRTwA0gO67CoZWawGaGZ CRf20O3HyFw4CeWJeGlH0A0vnVx91vNnVElTSj9Wk3KKyyqh2QJ4A6HgnGdEbwGNQDEA dncODcJZLeFfMk1zn69YM6pihDz2phW/HjAK4xn+kVBdm3PTv2RqOl2LtjhW0s3XlKcu L2coUQxc1SgVy1xDlkSXIg2gwFxoZtL7Kk8164Hsk1MBH49OTLqVpuXYfi8gXFdV3aNj UCYQ== X-Gm-Message-State: AOJu0Yxrg5c1Fgu5mm9UR+GCYiU29FaTHvcQnMnBQb2JDfTUgK3yXqkH nf8g1E75254J+8L3QX/JASNvpVOoV+ZeUDD3FjlJLfpukWtKesGoyzjyuubbShYgBPylSd/A5PZ oSKqDGfTN0kLYyqTxuQV58l8DHrKO18X8q4atcOyViajlCCR99blke5Q4 X-Received: by 2002:ac2:4241:0:b0:512:b915:606a with SMTP id m1-20020ac24241000000b00512b915606amr2064117lfl.12.1709675767150; Tue, 05 Mar 2024 13:56:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IHxY1nBX3SKLAknBYvsQ/pCfjKjZV2og4w7RH4xd6U1AxIEKqeA7frnYhixNCYu1SSvItB3fQ== X-Received: by 2002:ac2:4241:0:b0:512:b915:606a with SMTP id m1-20020ac24241000000b00512b915606amr2064100lfl.12.1709675766682; Tue, 05 Mar 2024 13:56:06 -0800 (PST) Received: from ?IPV6:2003:cb:c73c:8100:600:a1e5:da94:a13a? (p200300cbc73c81000600a1e5da94a13a.dip0.t-ipconnect.de. [2003:cb:c73c:8100:600:a1e5:da94:a13a]) by smtp.gmail.com with ESMTPSA id b17-20020a05600c4e1100b00412f428aedasm230912wmq.46.2024.03.05.13.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 05 Mar 2024 13:56:06 -0800 (PST) Message-ID: Date: Tue, 5 Mar 2024 22:56:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH STABLE v5.10.y] mm/migrate: set swap entry values of THP tail pages properly. To: Zi Yan , gregkh@linuxfoundation.org, stable@vger.kernel.org Cc: linux-mm@kvack.org, Charan Teja Kalla , "Matthew Wilcox (Oracle)" , Andrew Morton , Huang Ying , Naoya Horiguchi References: <20240305162744.93431-1-zi.yan@sent.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20240305162744.93431-1-zi.yan@sent.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 19D724001B X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mm1se7pcqqrmh7p46661mr9j89zziam8 X-HE-Tag: 1709675772-367620 X-HE-Meta: U2FsdGVkX19Jpz53YjGaSf8M0nMJovAvnQ23pVBGhkuTjJAHAnpHvcRdwj7bYxShHr1KxF4uXbN3E6KiUqAtdanbyPZaEhmDUHrnYrjche0npcEnBFgarRHJKziz9EFAfjI2HHyNCRUYyyND2u2DGLITflK7Qn9lcueJk94Vg8qbiTbtRJIp3On+UUwH1ULwZWdl2j6iE6scDo9k1tIGEsur+VWIBdhYGhozYAzURoYJ636JC8+SbCMetG1ApITnMWUKW/3AOhdSCGUH/QEUlBkEvSqqNGm3GIDON3TvIuxWZ7v771dHTP8FiLOir+LxUf6NkLkGUxXxWWY6TeiUkQuNNbMq657844lQoBxt2vWiewlEpfdsyp+AqulYow/iOXrtgy3V8AGIsMvk+C2zEACbcg9w/Q1gtR9TuurIJqsaCQxwCbNpM/HXg3EfeXWcyoULpXgLhSoknZ2Fd/ormoHcsVtYFLTaE+ELwM3BO8dDXx9SlRO+KG9vUcpqrNXCcpTFhzbr+RuWuyvH/wLSok5T57BeK+gVnzMn9ydRjnIZmoqy8HxypJp95opUorYCy+tNJ/VkMGpGnx/royY/ENSTBFwQnnQhigdtKTYJQkPHePJ9sKw2XUbDQREa/0BhoAKOFR91I8IJa6einXCTfX6Fljj12a+dl13G/tgGYhPZFsJguTH8SC8pxsv333O/A2pEhTpkEL8Kvqow7btXzU+jQxflsx+F9oi5sH04Tg85MAqd3OeGGrKVd7taFGLkW7eofK2g97KQd9/beD2AxTwbKzprnJUa+qwwjQf0IeECNBrU3w8ikugBE7BdsRWp/HahKeI3MdpBHPdSYJvZYPSpg3h8NrW23iz5qJ5OHazGskYWRJdW5h6Yq3uFIwoKON1rgfr5IIHpCOZJw8VJ3/0T3B3NtGywfLVmkhOCxb77POUCWaZ0h4hDOEpKHh8Ca8qfr7pemkKdWN3KQSw 7X2zpxlc TvIHJE544P9LQG4XFq7Gg2bkG5WWuZYsSoxGB7KFegJjh6cWQuNsLg3Q82RcMjzv8QSXBF/e+5KEb/kbdwrt7QFq79wivyNuMlrYRXushWC5DDIGGIL9rPi3CSE2Z4zW6QoFDixsdFfcSl1pLMZko5NNdFQ730Olwwd98 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 05.03.24 17:27, Zi Yan wrote: > From: Zi Yan > > The tail pages in a THP can have swap entry information stored in their > private field. When migrating to a new page, all tail pages of the new > page need to update ->private to avoid future data corruption. > > Corresponding swapcache entries need to be updated as well. > e71769ae5260 ("mm: enable thp migration for shmem thp") fixed it already. > > Closes: https://lore.kernel.org/linux-mm/1707814102-22682-1-git-send-email-quic_charante@quicinc.com/ > Fixes: 616b8371539a ("mm: thp: enable thp migration in generic path") > Signed-off-by: Zi Yan > --- > mm/migrate.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index fcb7eb6a6eca..c0a8f3c9e256 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -447,8 +447,12 @@ int migrate_page_move_mapping(struct address_space *mapping, > if (PageSwapBacked(page)) { > __SetPageSwapBacked(newpage); > if (PageSwapCache(page)) { > + int i; > + > SetPageSwapCache(newpage); > - set_page_private(newpage, page_private(page)); > + for (i = 0; i < (1 << compound_order(page)); i++) > + set_page_private(newpage + i, > + page_private(page + i)); > } > } else { > VM_BUG_ON_PAGE(PageSwapCache(page), page); Acked-by: David Hildenbrand -- Cheers, David / dhildenb