From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09042C433EF for ; Fri, 17 Jun 2022 19:31:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 794F66B0071; Fri, 17 Jun 2022 15:31:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 71E526B0073; Fri, 17 Jun 2022 15:31:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 597FD6B0074; Fri, 17 Jun 2022 15:31:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 468516B0071 for ; Fri, 17 Jun 2022 15:31:56 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 07ADD76F for ; Fri, 17 Jun 2022 19:31:56 +0000 (UTC) X-FDA: 79588723032.04.ADB5621 Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by imf31.hostedemail.com (Postfix) with ESMTP id A8054200AD for ; Fri, 17 Jun 2022 19:31:55 +0000 (UTC) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-f2a4c51c45so6697414fac.9 for ; Fri, 17 Jun 2022 12:31:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EM4WuQB1JkdTQD8PY45ndgmJsVAA9Yd6J+wbPO6NpPg=; b=TcZ7SsxLlJOf8PjxVePN9jg050m+yfM+JWoqwMqqcRQognupSR97SauP4yE0s235yb ddqXUpJ2jmqQ2cPn0LYI/eUMXwGCnQYZGxq09p1VvIOFWOKnXPLd6CCuPMPvgPP+a5Of YbzaWxRWjHeubq5L+RnC2r7UE+g4xISk26HfM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EM4WuQB1JkdTQD8PY45ndgmJsVAA9Yd6J+wbPO6NpPg=; b=mcZiQR4b9z70OAfJ1M+QnyQ1DgqVWRJkn7BByxFmi/YlkylPdmJbXAiM5MNdft1938 Gg1AYE+0Jo79QQU4GUUvPUadzuINxvozTrlypWExVmzTiJEiYJX92KhAK63TReY16c91 ao5EpDDQCtV4uL4wXFH416GDaT+H9XGmvZePm3o9o2xn2oZAq9J3i8u0Kbsj7fHqjDsB RQJ7oLImBkJhDbLYYHC/jhg2BZIn/pVfoO8V/9YUb4Nj75e4SUOCvABkj7bNRSUneW0K mZqMG+A/uxNNEF1chXX0btId6bWc0y6C5ULlUT9OxJJC+olgx7NokU+HNHaFOuJgu3OP r5TQ== X-Gm-Message-State: AJIora/s11kqUOiP1wgJ1L19971MP69SxEwoLbZEoLHQRUgzubzaxeDo jN0CyXvmVUL0reVPPn36WFiFtw== X-Google-Smtp-Source: AGRyM1udGQRr7r3xRSI/SRpvnZ3d7wdlghukWbcfvBoS9d8ngIokzM5DUrYDRBl24rE/d98H+8gkjw== X-Received: by 2002:a05:6870:6097:b0:e1:a94d:9a38 with SMTP id t23-20020a056870609700b000e1a94d9a38mr6481520oae.191.1655494314848; Fri, 17 Jun 2022 12:31:54 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id w4-20020a9d3604000000b0060aeccf6b44sm2944399otb.41.2022.06.17.12.31.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 17 Jun 2022 12:31:54 -0700 (PDT) Subject: Re: [PATCH V3] selftests/vm: Add protection_keys tests to run_vmtests To: Kalpana Shetty , akpm@linux-foundation.org, shuah@kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220617111019.476-1-kalpana.shetty@amd.com> Cc: Shuah Khan From: Shuah Khan Message-ID: Date: Fri, 17 Jun 2022 13:31:52 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20220617111019.476-1-kalpana.shetty@amd.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1655494315; a=rsa-sha256; cv=none; b=rnPyvCqfYFteqCm4Uc8m13Dd5frB7Bv050pfM+ORFj9Hto5Y+XoCrjdiyP6U2FylO0R+qi 604Glz9X9C/opuikVfexQZwcB1FXB+jnhv45ZAqaOblRSlT5GALzZQiIngVbCF/JsAJQOm 4RFEmDV4U+qtmxv1zSmuWe1SZU271KA= ARC-Authentication-Results: i=1; imf31.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=TcZ7SsxL; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf31.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1655494315; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EM4WuQB1JkdTQD8PY45ndgmJsVAA9Yd6J+wbPO6NpPg=; b=ZPOxeaV6jZ2erEC0IrhVL9v+GFYiPIqT5RBGW02nPTS5nTmjcMw1859tJR8va12w4xWs5M rdsBFDK35oh+NNzzC+m6+zOk2+AlG22kKJsMLm5MobGl3DWLdVhUU+ATCo6FpVU91c4gGT 1Jt2vvqBNDe1HwgEs5/rcNpTh41ANP8= Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=TcZ7SsxL; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf31.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.160.43 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-Rspam-User: X-Stat-Signature: 3hfqcbpi4ntk7z9o7sie31stjcp7d7ae X-Rspamd-Queue-Id: A8054200AD X-Rspamd-Server: rspam08 X-HE-Tag: 1655494315-680851 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 6/17/22 5:10 AM, Kalpana Shetty wrote: > Adding "protected_keys" tests to "run_vmtests.sh" would help out to run all VM related tests > from a single shell script. > > Signed-off-by: Kalpana Shetty > --- > Changes in V3: > Shuah Khan's review comments incorporated, added protection_keys binary check. > > tools/testing/selftests/vm/run_vmtests.sh | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/tools/testing/selftests/vm/run_vmtests.sh b/tools/testing/selftests/vm/run_vmtests.sh > index 41fce8bea929..b19c6b1b84c4 100755 > --- a/tools/testing/selftests/vm/run_vmtests.sh > +++ b/tools/testing/selftests/vm/run_vmtests.sh > @@ -179,4 +179,15 @@ run_test ./ksm_tests -N -m 1 > # KSM test with 2 NUMA nodes and merge_across_nodes = 0 > run_test ./ksm_tests -N -m 0 > > +# protection_keys tests > +if ./protection_keys_32 &> /dev/null > +then > + run_test ./protection_keys_32 > +fi > + > +if ./protection_keys_64 &> /dev/null > +then > + run_test ./protection_keys_64 > +fi > + > exit $exitcode > Why not use file test operators. -x works for this case. There is no need to run attempt to run the test. thanks, -- Shuah