From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F3FC00528 for ; Mon, 7 Aug 2023 15:20:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 228136B007B; Mon, 7 Aug 2023 11:20:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FF188D0003; Mon, 7 Aug 2023 11:20:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C6C28D0001; Mon, 7 Aug 2023 11:20:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EF01D6B007B for ; Mon, 7 Aug 2023 11:20:03 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A70FD120981 for ; Mon, 7 Aug 2023 15:20:03 +0000 (UTC) X-FDA: 81097669086.19.69DEC3D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 49FE8A001E for ; Mon, 7 Aug 2023 15:20:01 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LR4jHktI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1691421601; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ur2QEBvnhc9R1LbW3/XrioNK684qnooApWlEnr1yrJQ=; b=4mtAFWpnuFunl031+77G1uyIaLCks0o6vXZEM5PoUQnSlM7u72h1mawJLhLait0ZV1JU5T mbtGx454RH6ddQL1nVpSm2VYE0If/hWjca9kMlyuClmqQZC/OTtygbkziUhqS0WzPBgZ8l gTQDnQiVliXqt1Icwji1gJXnokiIhEM= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=LR4jHktI; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1691421601; a=rsa-sha256; cv=none; b=xog4wQTPc9d0K18OZRqjvm8dQm1V8oKhzofEL11AaQXnNQ0IXlWR5hQ/KULtYtJID4riNJ oS+Jwt3zE+8+xFcMcorh7OPyIRYRaBNOVb3miwq6w9Ec1OuI+p/OjLZ3REToEsZY3cgDdp il8Lgwm43oSZZPi9jH/vMvRf7a1+/ys= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1691421600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ur2QEBvnhc9R1LbW3/XrioNK684qnooApWlEnr1yrJQ=; b=LR4jHktIirFXc2BNb2IAcH0a/dMxzbj/0Nucu9l0ZiITSTDi1UoWTQmR+ja/lE34sDFnGW Q/IEv9ECQ2tVPbmY6pTRa+zeAZfjxBv1xeF91x+tljHo/IzwDQcVbeurQzKzdtSIqhtlxp Pk+N83ZaPZA7jVk6Tr86nDypZKruq10= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-595-4jeSeYYeP5q_pdxOQ01bbA-1; Mon, 07 Aug 2023 11:19:57 -0400 X-MC-Unique: 4jeSeYYeP5q_pdxOQ01bbA-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-3f42bcef2acso26157415e9.2 for ; Mon, 07 Aug 2023 08:19:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691421596; x=1692026396; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ur2QEBvnhc9R1LbW3/XrioNK684qnooApWlEnr1yrJQ=; b=kvfdd23b1fzGDL+PM94NGJbUdUA/8v4mA7ON3xGZyBTKzpiU7dmYDzntlC3aKWQuWF 0VzQFJ3c2pmFyLBFx6foEceH9NJFza6eXr5MPY7Z4KkFog9t3oTDqXcj6ZCZWO7EGxw8 kVPW487bi9c9c35RuwGzYI/kiRov8ePThLfAlSQ9h25PHwavWMg0ByGJmVttVjIXuhza fcEgLRvFaJnn28g4/FQdiHy8Gtj0oTvljQb95Rrc+HmsLMm22ASQvznxTEEhUW+yjPFM 0y3jfZ20Y7C6pV7soNu4G8sFLQPem6u1oOvUZaUOcZ48Qqd2Gk/ywxbhA4JWsaspq+08 TaTA== X-Gm-Message-State: AOJu0YxkIzv11AMZiwtxGA4uWN8wrfbXlmKcIHxIJr9WR7LJpQrwQAPq 6szByIU/grx4XCWU45vjsZJIPAc0iZxTm+EHz5xPW8vga+lja4WzjysBExKdcnwGo+GNmBMqbDR JU5AcH805MqM= X-Received: by 2002:a1c:4b14:0:b0:3fe:18d8:a61b with SMTP id y20-20020a1c4b14000000b003fe18d8a61bmr6611372wma.29.1691421596038; Mon, 07 Aug 2023 08:19:56 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnUwB0tW9Wf6m5Rtqt8DyX1Fbd31ecrc4s7He58z8puJM2tzhHy8Qy0w8wLCcmNUeGAC9pmQ== X-Received: by 2002:a1c:4b14:0:b0:3fe:18d8:a61b with SMTP id y20-20020a1c4b14000000b003fe18d8a61bmr6611356wma.29.1691421595678; Mon, 07 Aug 2023 08:19:55 -0700 (PDT) Received: from ?IPV6:2003:cb:c740:5d00:5143:1cd2:a300:ceff? (p200300cbc7405d0051431cd2a300ceff.dip0.t-ipconnect.de. [2003:cb:c740:5d00:5143:1cd2:a300:ceff]) by smtp.gmail.com with ESMTPSA id o11-20020a05600c378b00b003fe3674bb39sm11030441wmr.2.2023.08.07.08.19.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Aug 2023 08:19:55 -0700 (PDT) Message-ID: Date: Mon, 7 Aug 2023 17:19:54 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 6/7] mm/mmap.c: use helper macro K() To: Peng Zhang , linux-mm@kvack.org Cc: akpm@linux-foundation.org, wangkefeng.wang@huawei.com, sunnanyong@huawei.com References: <20230804012559.2617515-1-zhangpeng362@huawei.com> <20230804012559.2617515-7-zhangpeng362@huawei.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230804012559.2617515-7-zhangpeng362@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 49FE8A001E X-Stat-Signature: dprgcccqkgjd3a985ocsb8mo7zktyuum X-Rspam-User: X-HE-Tag: 1691421601-345930 X-HE-Meta: U2FsdGVkX18JnxQu4dj5CQPWy9OXXalVlNvT4rbG1w/l2UuJrbFgccHC7hziqH1UPS2cnx8jCHQh21frBNpCNKi2aSEnvRVdAdI2wYJVYHfEE2BFAZ5b3DWAbHs9sTbHaNQmrFfZ4nJCuLrxTCux7K6swswQUrNBkCiOKX7QBWo4Htu6EFyExkivm7CdKfy4OR0E8A9VLrYlijbFUpjQwpCLDUfMrjTMS7799kcSR7OJmx8R3+aE7g62UyDLhzQBXqAvbZ0tGskcOFt7sv0CFr/eUNbEiGGRnKq2sCgYXWrdyKhczkyoMYGTrTT3NigJ2lfsNWT/rUxPsSZUEY9HzI/VRjP8xNmE07A2OmH4VBQtFJl3Ge7yUHN1lc8dbCzKhv2Rwd8BlOmweoNDAJFlx+Fo/VrElzmJJ+yMOknNgU/WWp9B9bWPbYKCH8iVd0CSTyjSsH6HZkI5VsANYTvsCg9o5Qdjv0PoYCQ6ygxvbK90foG5lS65CLmDiZ+v7sqH4HnvH19oal36CkU5P2sMxj1E1+cSEuH58YdxGFlnCI0bnPuiv6tYV44RJrI6NrWV0FHgCBiUz7igHRNK4Me4I4T/QznXzdR9oFhlvqm6lDDS1Vz2Mkq3sZSLH/LyhkwpLKJmQsSyADjIlvIiuJWL84eAl5QFIlyoFgeZkDmFWpNP2xS5tI4+qpRoWHBjCf4LXZIVuon9z8XwtoWT9QwrnOpncgHpzfnFoKYPmM84Y14Q8smS5yZQL0JQoMETLYc0yaV9Z6yWt8NCUOdbwPbdgFVhTwgmZWvza9oHRvw8ENjCIfGLlOdI5md579/zBsgXviqmLVCdtd+7DvnnpQk0VB/7+QlqI/saBQ4Uw3oD2ssdI03euQ6hqiWWcgAS+7d/kdrAOQG4GP+oJCpKS7jqPfhgTZCpDuTKP77ivX1I3KM9dF74tuRY5yVHz4PiR3cDTk/SrXmMWGa4A7aO3JM XhKC8olU up2EUM3g3lheDNnFXCK7Jr4LyCFcZ1OfqqgyoJpkRLHZM+5/Y6zO4f5PPPXEQXAc89jH2n8sdep00oD12K9tQ0Ef4DAqgHciFxf+nDAi7VOOUDDexidsYH9Pkv0UEgr6t2GqsOmBzw6z5SK9Maz1M8MYiv8rAyEMZOXxLAVKUQ1Ecza95614y6Db9Z4aR+ZO02QemK8K/MD0pAvVyWG88DTtjVI/lniHbNtbfQY5+jDeFAGwqqDjwxqnqg2Df3+uawNfrMk0EB5mZVr7qCIsgMkcq+2WLx321w857ZcSiR+UWX6updSqhgzbJsEDbL4YfQtgE+6u6Z9LLJ3WOeG/6Fn0QYogIFowvpQvOZJrIJXNgy70Lb8tNykxQXDGU91672O4tiFWwuFOvrYQevqUomAIwfR5qHcDEmZam3Hth3Dfkbx4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 04.08.23 03:25, Peng Zhang wrote: > From: ZhangPeng > > Use helper macro K() to improve code readability. No functional > modification involved. > > Signed-off-by: ZhangPeng > --- > mm/mmap.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mm/mmap.c b/mm/mmap.c > index bc91d91261ab..35b6bc9c7c95 100644 > --- a/mm/mmap.c > +++ b/mm/mmap.c > @@ -3785,7 +3785,7 @@ static int init_user_reserve(void) > { > unsigned long free_kbytes; > > - free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10); > + free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); > > sysctl_user_reserve_kbytes = min(free_kbytes / 32, 1UL << 17); > return 0; > @@ -3806,7 +3806,7 @@ static int init_admin_reserve(void) > { > unsigned long free_kbytes; > > - free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10); > + free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); > > sysctl_admin_reserve_kbytes = min(free_kbytes / 32, 1UL << 13); > return 0; > @@ -3850,7 +3850,7 @@ static int reserve_mem_notifier(struct notifier_block *nb, > > break; > case MEM_OFFLINE: > - free_kbytes = global_zone_page_state(NR_FREE_PAGES) << (PAGE_SHIFT - 10); > + free_kbytes = K(global_zone_page_state(NR_FREE_PAGES)); > > if (sysctl_user_reserve_kbytes > free_kbytes) { > init_user_reserve(); Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb