From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B73EC6FD1F for ; Wed, 22 Mar 2023 16:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A5CE56B0071; Wed, 22 Mar 2023 12:10:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A0D756B0072; Wed, 22 Mar 2023 12:10:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D49B6B0075; Wed, 22 Mar 2023 12:10:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 7AB146B0071 for ; Wed, 22 Mar 2023 12:10:15 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4E625A047D for ; Wed, 22 Mar 2023 16:10:15 +0000 (UTC) X-FDA: 80597021190.03.E3F6DC4 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf22.hostedemail.com (Postfix) with ESMTP id 1FC79C001B for ; Wed, 22 Mar 2023 16:10:11 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UvU8A7W2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pFtujWUP; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679501412; a=rsa-sha256; cv=none; b=Umtnq5lNtF8KjTy2vWiNzpsQyndaVV4M9n3LFDo4vnfW5Asl1Pl34eUKTU3kq2VB/O+ftZ ciQeE0S4QL0LI2GAL2gAUgvsJt8hPXCWgugHRz1onSyS39UiUSHqt9y6JeCkCoCg2fldvi sfQr+082RXbvRMiXMo73NjDMLtC4A5c= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=UvU8A7W2; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=pFtujWUP; spf=pass (imf22.hostedemail.com: domain of vbabka@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=vbabka@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679501412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1+7eyTKeVn1sl0E1m2LZkECMl7RTMp0jt5zZuoqxsew=; b=0YE0ADDRkhEHAqq9IT3H8v2MYdbNAfJGPauZEOxCDSO6mmaWAQ3FlM4SO8upwjWBKWhDv7 EugrSschDaorsjXosn9pAS1sCpOym2ioXOs374ORRmfRxRWjDB6qG1+UX0MbtK7/WkEV88 EFh1lENAtdR19dNSi5cjOg69uPaeDjU= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7A3B533CCD; Wed, 22 Mar 2023 16:10:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1679501410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1+7eyTKeVn1sl0E1m2LZkECMl7RTMp0jt5zZuoqxsew=; b=UvU8A7W2avxjunPSL/m9XAmogri1XixdGqLj+DBNKVOD0L07rFrG2jTryRX9BvxuqWx+qv GhuA27cWKfkYQnbgQJiLelw8eHrykrPOhoFt9GwHiqbzUh7lLlg3y0CEALMkLhkkG4VzAO KSn+bmx8CE3l9VKh7mLK2TJKP41Vas0= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1679501410; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1+7eyTKeVn1sl0E1m2LZkECMl7RTMp0jt5zZuoqxsew=; b=pFtujWUPfcX+V8RK3RYZdmSAUw6NzcCwQFRSbCSR0ziPmuupZpSCXyE6okiXw0rEZUsPlR CZoVYZtJPHd8ATBw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 4C15E13416; Wed, 22 Mar 2023 16:10:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Q47WEWIoG2TIZQAAMHmgww (envelope-from ); Wed, 22 Mar 2023 16:10:10 +0000 Message-ID: Date: Wed, 22 Mar 2023 17:10:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v2 06/14] init: fold build_all_zonelists() and page_alloc_init_cpuhp() to mm_init() Content-Language: en-US To: Mike Rapoport , Andrew Morton Cc: David Hildenbrand , Doug Berger , Matthew Wilcox , Mel Gorman , Michal Hocko , Thomas Bogendoerfer , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-mm@kvack.org References: <20230321170513.2401534-1-rppt@kernel.org> <20230321170513.2401534-7-rppt@kernel.org> From: Vlastimil Babka In-Reply-To: <20230321170513.2401534-7-rppt@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 1FC79C001B X-Rspamd-Server: rspam01 X-Stat-Signature: rrq67t1cszfsa1j5nkaiecpbo6n7dsey X-HE-Tag: 1679501411-984376 X-HE-Meta: U2FsdGVkX18C7ss06uL4JM1K8vxsB7MkCi3THhYuEc6DprqazVK2mScCmYGZZCdPAvDg+LQvVt4X32MV1uhkCgOJeX12nHPL4G9AiSNE1dmJw3R4/1EQEB85pdBIaY5wu+0FR9wkpXj8PZVdB1r4sFATsuCTIBA51Pdzx0kTWv+cQN1s+WtnIczAFj5/duoiyaEb1kFU6+qip7TuJ0zE9ZJaqCTM6rlgvFqQqTnbx17FcMcjH7nIIbC8ybQKv47IEsvm8QhyI8LzDPHfnqp4Dek6Y8I3Y+bYzXtIsLqFb5MGmRfBxSJ+DjivEMOXtOuV+Pqi9inA85t7Cvt4aMnz29jYonlTDQf5nAe/xNYTBz0gJDBTYaGXjxJRtp26VfTCtv8JoUGWF8JjtVeV3pngYhJNzQNlqEiZdxMZvMYVAxtOSS9i2tX8kTiP8k1La/WqB26/FCCpiqEpbDP5FK5tABjmWxvtrQD1ed5PMLN9UssuLmwnQisNPrp2JATAToh6pz/pElCJklCYH5Rb93M386oC1LXpp3HaD0eczOQV8MX+r1JEx/N+jXDRADZPPEXXS5vakA3V+fNluk6PWtUqsffl9Bo0VdOH2UIAnnamFkPLDdOTNS8w3kICqlvJTHtW/hsx+PqXxFxALjkjT56361Eo28xJcurB+HyXV0wWuzttVBWbuYpHA4qommU8tzB6b4m9ESI9DJXbPtbWKrUoXyJlAjCvRBreSJAlpKCu39bkKse/crQWHcvLi5TOB/VRYjDEP0e6QcJocQS3CyCgvxZQeTJ2H/zZvvJoV0rmTIaKPnEFeB2hRDOfTLm8YvS65G04TiRxNkS3I8t+AB3CriM+hYXwOfji1im1fk3YH3E4crXRIhVdY+35e0nJ/NVG0e2p9QNSmtsmR400o7F9SMs1cG8KmPfJSZAGrlxQG3hyQf894c7HEdz1HVXfeQYw56V0cYnVBp0SBx/tSMc 6veF0um8 IfV+Vw3c/mlR6+Y6PLxdiR+8Uk184CJYCDhgJTkDA+VCcyezp8LOGI+zFpLFfGwGaBc48vi2h8KLKeFRjHdUihJaNhLVS1CNmzcTGWc4tRwxW5qPM1FCdhvLDuQt/dNlxF7CYyfnvKsFK5cdcik323eR/LPMEWIUMSlSDU+hAHC9uh13FH5+4cDHLHTTes+UYzNfld3PYg+Dsmi6FrzSEjNqXO014/h0ukSW343CUwAEn0sPcqPAt5kVS9+YheUiTZpZKILMHDjKxSgbUZlBdnqLspIZsVPaEpCKJCbROVT6EO/+/TM68jc4v+5wzVLSW/VbarbBPx9B7q79hjIUidFiDXQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/21/23 18:05, Mike Rapoport wrote: > From: "Mike Rapoport (IBM)" > > Both build_all_zonelists() and page_alloc_init_cpuhp() must be called > after SMP setup is complete but before the page allocator is set up. > > Still, they both are a part of memory management initialization, so move > them to mm_init(). Well, logic grouping is one thing, but not breaking a functional order is more important. So this moves both calls to happen later than theyw ere. I guess it could only matter for page_alloc_init_cpuhp() in case cpu hotplugs would be processed in some of the calls we "skipped" over by moving this later. And one of them is setup_arch()... so are we sure no arch does some cpu hotplug for non-boot cpus there? > Signed-off-by: Mike Rapoport (IBM) > Acked-by: David Hildenbrand > --- > init/main.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/init/main.c b/init/main.c > index b2499bee7a3c..4423906177c1 100644 > --- a/init/main.c > +++ b/init/main.c > @@ -833,6 +833,10 @@ static void __init report_meminit(void) > */ > static void __init mm_init(void) > { > + /* Initializations relying on SMP setup */ > + build_all_zonelists(NULL); > + page_alloc_init_cpuhp(); > + > /* > * page_ext requires contiguous pages, > * bigger than MAX_ORDER unless SPARSEMEM. > @@ -968,9 +972,6 @@ asmlinkage __visible void __init __no_sanitize_address start_kernel(void) > smp_prepare_boot_cpu(); /* arch-specific boot-cpu hooks */ > boot_cpu_hotplug_init(); > > - build_all_zonelists(NULL); > - page_alloc_init_cpuhp(); > - > pr_notice("Kernel command line: %s\n", saved_command_line); > /* parameters may set static keys */ > jump_label_init();