From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6276C54E94 for ; Thu, 26 Jan 2023 09:32:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E1BC6B0075; Thu, 26 Jan 2023 04:32:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4915E6B0078; Thu, 26 Jan 2023 04:32:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 332D48E0002; Thu, 26 Jan 2023 04:32:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 24A6F6B0075 for ; Thu, 26 Jan 2023 04:32:13 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id ED9D9A064B for ; Thu, 26 Jan 2023 09:32:12 +0000 (UTC) X-FDA: 80396434104.03.3750665 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id BE0B180014 for ; Thu, 26 Jan 2023 09:32:10 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iVtlOVJH; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674725530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wwdoVdvZ1FxySXHtS/y2n7jjp83gxbEJIMQ/l72KDiI=; b=7txUaFjEskpqQTXmXIa62c+vq59JcaZkT/7GnD+op6xFmFo1IOsnzwoY7YpiA/ziY205WB n2AMEeDVSR+0wR//DmUGtOfPkYpX1g9CibvAu11vUno9POtWVKWW+pWD+E3wHDfL1/pb+I 76v3VjTB5UXgbXWIICayHCNV7lge+F8= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=iVtlOVJH; spf=pass (imf30.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674725530; a=rsa-sha256; cv=none; b=N2rnoTfAFjtj24aGMH+TBVGY/gBbRxjFTF1gPyX96HJEjJw9Dd9UgCy9WW6EJ3XNhXTw1Z zKKrtKl+Mb4ThS1opn/EqVRayiLeklwIeT4ZIt5purNii/VgoBkgWQEVfsr4LvsSPdsmk7 i3sqLU+koBD1oLNGZrEowFnD8rnHo8c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674725530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wwdoVdvZ1FxySXHtS/y2n7jjp83gxbEJIMQ/l72KDiI=; b=iVtlOVJHJ+phV5pf989dn5C3e5xfbXeZFsoOIBVNwh7shkOKBypNI2RnvRNiSFqBlE4qDy bwZX+Qt9+H3PIjsrYIlUIJMMVFo0Y1oUrjrOpndBA8Z+Ehhz/1CvYn6aMFJmg2AITnLiWT m1GHSwOHsrnUgZ8SkINGlZNjSeKyDf4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-440-LHuSrr5dPIKrPCXK7DcAgg-1; Thu, 26 Jan 2023 04:32:08 -0500 X-MC-Unique: LHuSrr5dPIKrPCXK7DcAgg-1 Received: by mail-wm1-f69.google.com with SMTP id fk11-20020a05600c0ccb00b003dc271790a2so238579wmb.2 for ; Thu, 26 Jan 2023 01:32:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wwdoVdvZ1FxySXHtS/y2n7jjp83gxbEJIMQ/l72KDiI=; b=WPBzMBA2zK6FQZJ+z2vsDJUzuX1YwvYF40egsHBWUCgCJq2h7gAPdq8T/jWHQQzVSX 8Fek3SFfl+1P5qhOTrqDuSnBrJlakBCaB9ZnSxNC/2do7wfxCTnroCMCtP0gB+RetkMV 0tz5Cz/Jbd6lb/rpiGhTQU3jqApeDKXe7VfgKQdAdvBqPWfuljredhvzCMqgXm3vH2tp V0acWXQah07xy5z82AaSAUW/feKSiVyFdDZdR/HkqbAWyBK5YbMH8hZH7cN5gdFJA/DJ TxRCLJ85hEDGQQSEMdBeIY0lKzZfC6IB3E5qAMva6AbVu8ET2QAiyK0tGljqEGigCpej TGKQ== X-Gm-Message-State: AFqh2kqfjTQaBZea4/lUTXuHJ1CCWP0PB3Fqx44jvhk0RhNfokeh38hG czp/yIpTre5TXoR2WGEeBanyddEIBgckXqhu+pRUBnixosifqTZfIysfaqkhLLVq1nPMKkXs6w/ vLwooz4Y3T1c= X-Received: by 2002:a5d:4350:0:b0:2be:5366:8cdf with SMTP id u16-20020a5d4350000000b002be53668cdfmr19139270wrr.20.1674725527625; Thu, 26 Jan 2023 01:32:07 -0800 (PST) X-Google-Smtp-Source: AMrXdXvuEnatbeSNJHS0IKM41wypa1ffgMRJyS1j0d/4+OLyN2ZtqLoQlAGksy5c3U4wNl1YCZjPqQ== X-Received: by 2002:a5d:4350:0:b0:2be:5366:8cdf with SMTP id u16-20020a5d4350000000b002be53668cdfmr19139245wrr.20.1674725527332; Thu, 26 Jan 2023 01:32:07 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id l13-20020adff48d000000b002366e3f1497sm784664wro.6.2023.01.26.01.32.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Jan 2023 01:32:06 -0800 (PST) Message-ID: Date: Thu, 26 Jan 2023 10:32:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v10 5/8] block: Replace BIO_NO_PAGE_REF with BIO_PAGE_REFFED with inverted logic To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jens Axboe , Jan Kara , Jeff Layton , Jason Gunthorpe , Logan Gunthorpe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Christoph Hellwig , John Hubbard References: <20230125210657.2335748-1-dhowells@redhat.com> <20230125210657.2335748-6-dhowells@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: <20230125210657.2335748-6-dhowells@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 3yz7pc7poqd9m5mzftb4i65eh8orh8jw X-Rspamd-Queue-Id: BE0B180014 X-HE-Tag: 1674725530-599434 X-HE-Meta: U2FsdGVkX194uoP0fCxKCXtlSrVuicn0sQdY9xfm66lcbad5OpXH80VQRP8SiOO2Gn4dF85dO+mj6K/kGREbVVc7byqd9/kNTBjAokosnJNhkhq30UnPVzzbua+YshL62FTwdmFrRUtuAzQsBl6s3R2SqCkfT6wZ1pKcLPJr4Rjv2Opfzm7UWjS6WdPh1iFOHxNHviUrGcg8uBPydIgKubt3kLwou8vo+7/KSg847aZnHvBMTvLC0KBQbvk5W4oBioKz/HmsUgnLxJrDB3Xgb+NrKAKmjeBf1a7VRFwE7RFTgmPMsjAXFBdeKEzIAjUokxkgdU/zeGIzxmJf93QRMTrVd8FIggo2OOe8SI3XFg6rdC2guBZq2tQW/HZOAQ6+YKfqYx6kLviaijyK6JUEAmvfzGN/dE7N3v/whIJB+WZOW9T1qFUJVcWXo+dq88jd/08WclB2d+BFqstBEj1DlLl67RzsRUGrHbBah1MD+VPhcWjtVoyh3fhHqjqYP97bvDHFQy1TfiAoO8NSsL2XdspqIDMV0Os5Bjm69vFZpdL3XC1Gs2i9m3jtIBCkTeZDhovuu/w8pMMsUSzels1H/2mLJrPhT2zf5nl7iaeB+MDyCqUPQxuzGzY4vgTUSIiMYb7Qo0SQuQvIZDw61o0LaxxjNu7pXv1kqLbf3WvcT7z9zaszkJl4X8Ode0IK9cSeCGyvMcDPsVCTaaoibZogDnkkstUKZJjiQ/NX3dAa6fAPrGChKtSc9MTldCxeypd4GnGqon44q78h9Usu2lBpXXzqhEgGN5g4d1yclM1IZ6bvUKWOeKsdAes5yzcpvZOlViFzaq/kZ7grrZd4834C9bVoVV+W7a/CzX8mEgK93XsV1hWvT8yt9926oXjgjRkDbfDPxDVkDnrn7OyY1c5CcU06nIALhj2+4SuoupvUfLdfMKY2F6zYSnB38Cy4On+ubSIBERl6HOhpzED+wva 0BY6nndH gpHOxKPWHwxToTuTK6tfAZhKM01msrz+VIq/+jRbxGddCLTcIyToWYGJuVwe+9HxDelvzVZrR50FJ1S92MS3FNI8daHrCB3pkf+/Lv2e6w5T17/eR+IUnbRcXGcYWogfEnOJJbp+kKcR6VFbo4mdZC3ZdhBsUe9on7Ect2Uo4gKQa9HnwUVz6JG6CjwCyiQs5MccDMo4+ITv8AYJsBFyC+RurNDwZPM6n8QMN9fLZismOiDx5+RkoDAm5xaQQRsX7ROJ2oaD+W527JNj+IdMeyzEjAKQGELXbcZW6d7EyjnZxXg1T5cT8vQ5hLEeOSUHBCsUrkBj3P6pCpBRvtB2cbRZnSDifHSJ2LkDs6QR4/C7/+3ZHC/bTdmsEo2YLMsoTX4zvZuPGLYNeFqxSgJzXuUR2/ACy1R3qY0DPgRT3sY+LgED+HwyE/4rnY6rB/s3BpTkcJtbfgC1wTLUnR190GWfMz2CRT6Ga4qTjVVE211uvh/ttVCZjkokA1KXoTDlu6zOhcwMMnhGkPVoVfQnr3chgb+7xPD3WRMAK30fYCq5Q/CoyG1Qm+F47m3iUlnzcQU1szMwXeVFnv3/RKIj8XJT7iSEcipSA6qOgow7J3/hB1qqafV15LXSeh66r/tAuu+GSzoTiL6wPcK8cL52ZElIYuydImygBZNdpJQsil56CpdAndWd9fgz6WyGc5NjW9zDG+S/lMwQkSCofiCPf0XARrJn98LiyJ4t9 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 25.01.23 22:06, David Howells wrote: > From: Christoph Hellwig > > Replace BIO_NO_PAGE_REF with a BIO_PAGE_REFFED flag that has the inverted > meaning is only set when a page reference has been acquired that needs to > be released by bio_release_pages(). > > Signed-off-by: David Howells > Reviewed-by: Christoph Hellwig > Reviewed-by: John Hubbard > cc: Al Viro > cc: Jens Axboe > cc: Jan Kara > cc: Matthew Wilcox > cc: Logan Gunthorpe > cc: linux-block@vger.kernel.org > --- Oh, and I agree with a previous comment that this patch should also hold a Signed-off-by from Christoph above your Signed-off-by, if he is mentioned as the author via "From:". I remember stumbling over that in submitting-patches.rst ... -- Thanks, David / dhildenb