From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5693FD1CA15 for ; Tue, 5 Nov 2024 02:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87BB6B00A1; Mon, 4 Nov 2024 21:31:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B37976B00A2; Mon, 4 Nov 2024 21:31:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FE7F6B00A3; Mon, 4 Nov 2024 21:31:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8281F6B00A1 for ; Mon, 4 Nov 2024 21:31:01 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EBC838046C for ; Tue, 5 Nov 2024 02:31:00 +0000 (UTC) X-FDA: 82750462914.30.F19DC45 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf24.hostedemail.com (Postfix) with ESMTP id A9558180004 for ; Tue, 5 Nov 2024 02:30:54 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G5Mry4/K"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of koichiro.den@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=koichiro.den@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730773691; a=rsa-sha256; cv=none; b=1QtLCwsXzMyhxF874jhIh9s4NXkUtVZ7N5HS715HYTaXvSDhnzVMDyybiwsUXQwgGdJADl J035n48ndG2ENM4SwQFQejpPis0cQwcU2vjWfH0WV26JNozdT3cJiVBwoSXsll9BMjwQxv Ydtj7PQoJB6vyme9b4qwP3ka3oB+1fg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G5Mry4/K"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of koichiro.den@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=koichiro.den@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730773691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X2P1a3dRdV3xHFpFY4jxvzlaleVlDKjflmju/CEhpUI=; b=tUXs1R1Z9jvHxKhWrPeKNF4Bim1dDZU079oIE4v06D10RJwdxBOpDQjpxnVWE0FGMlvefN Lal+zsqPw7eMMFVNV9pdHjNw73HcvhQUYZRGDNn4XhFrHFCuLmOoQ/Xr9qUKPwCq99fsGz jxrs+8tfrHegmnncRLYqVKPIN8gOIDM= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7f12ba78072so1445114a12.2 for ; Mon, 04 Nov 2024 18:30:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1730773858; x=1731378658; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=X2P1a3dRdV3xHFpFY4jxvzlaleVlDKjflmju/CEhpUI=; b=G5Mry4/Kx6krm4CRG4D7bv2hQ+Oid8aoqSDyQKEi7QobKTsXIX2MThTlVOdzZHw0z7 4KFayqk3YTDKlwwdquG9pxaviok6eSmD/BFXMdidmZQJPAxKyDwVZbs5KwOipWMNIrb8 LQVQPzey0MGTiCGX21UT9uPZamtniprmn9nDnMk1NxO9QjTrrvf5We2qUZE+ZnNLw/zu W4aJf3EMwapKVxIkM8xdpYvvTfbekPmq/PNvcsigzGJ9nl77Z3LN51Eq/2wMd5tsP6Gd T/y4qnmYzUkZTbNq64UoU++smtY3fdfC/SUMumgwX2gkd0q8INh/97B5FeHonTpFwvxF 5clQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730773858; x=1731378658; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=X2P1a3dRdV3xHFpFY4jxvzlaleVlDKjflmju/CEhpUI=; b=ssifz+Y0XJWh3a4WeyrX84ZmYoHwyLK1h+l4nE9+ecWzn05sTXbtM8SkoEqAHkxtef x/6LcT3diM9zfdb5Th5+OeqyveGT32VKTTlOcYgsAIyfZZ9GcxMn0TIs7bl7hEDqpt23 a7KCS8cYPYf2Ht+oJ5MN05PHm2dpaOmzjctbN4rvv9VG3pcWj1cFBMKbCZWXRTHq2EhB ZFLfWBTIXFH5Wig/9lg5qBZF88YJw189HHSB6dGDUbOPGFZlbCkGBZG5oze0NtZnn+Uo YPeQ6a95R2YCx8J8sNYGuaCzmo3ohu5klP/7sfg9SJSHdSwIhYfUprCuylbtmVBj0XEF FMJg== X-Forwarded-Encrypted: i=1; AJvYcCXmJtw/qe/2MXJTTjso+MErDSz+0motNSei8sXC5tRnIrzkoLPk3fi8x4TJKtatzWksfNEWddqNTA==@kvack.org X-Gm-Message-State: AOJu0Yxe3V+q/se4rXENIQgG8YDeYO5PI6BGI1dUoC4GZtla0ovQLipu C0jK8jdEgjWU1yN0yBv/rO8cABaWbE+jflEfmAxzbeIszO4pfrfc X-Google-Smtp-Source: AGHT+IHas9AFF3rpn/hlEB9XmENylzBx4gr+WW3R1HvtT5vIR5jCsZAF6ErjjvCUZGWF8PyDEzUuDw== X-Received: by 2002:a05:6a20:439e:b0:1cf:50ce:58d7 with SMTP id adf61e73a8af0-1d9a8404bf8mr47545628637.29.1730773857770; Mon, 04 Nov 2024 18:30:57 -0800 (PST) Received: from z790sl ([240f:74:7be:1:54ee:9253:695b:4125]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-720bc2c54f1sm8326622b3a.121.2024.11.04.18.30.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 04 Nov 2024 18:30:56 -0800 (PST) Date: Tue, 5 Nov 2024 11:30:51 +0900 From: Koichiro Den To: Catalin Marinas Cc: Vlastimil Babka , Matthew Wilcox , Peter Collingbourne , cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, akpm@linux-foundation.org, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, kees@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] mm/slab: fix warning caused by duplicate kmem_cache creation in kmem_buckets_create Message-ID: References: <20241104150837.2756047-1-koichiro.den@gmail.com> <8202821f-05bc-41f8-9de3-bf78899a7c7b@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: 3qknjhss63a56myzk9c7ejd5kygiseyo X-Rspamd-Queue-Id: A9558180004 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1730773854-968388 X-HE-Meta: U2FsdGVkX1/D2sQtd8V/TtKzBPusqJs1qsn8AVS9/Oih0ACD7DwJeL+u/V7bgQijCQYTZXCwdS3XDNXpWw9Ma3+aGQ7xWI1Ou3DcvVzlf8KgaeJ9fMzXnngNH4ac6iMZSVvm0hQLut9creDlUEvoraz1QmQQq9XmHn4zSKlbmpRe70oU4th2hlhL0gvlFBwbAOC5STVBLKvtirpyu3lydfbdQwcFPALIQkmmS0VdD+fQTSALegRyE10UNOmv7daEKv/LmNy9zbYRH86Xnk1FhdIaQOqqfft5K1JthaudYycdZU7/azMBBDWlxohUh7rFic/vhaWJr0hOHWD0jeMJNjyJvm7z/Q8cE/BnKX08hVxFb2s16lFPeV3VMro9Uu6tkVNPOupOSEUZEEsHRGreNcCF3KfltgH5o5DjH4ER/zVRYHujAg16S1p4Xd6hcJqew88+NyEeh15iMUju5tWYHjSEgSYybbK7TZ1Z0nHYpaO/gdqQNCsE4g1AI58cMuocfa0ClyI7OdHBPedXfj/3kGFQ+OrRn4pVfPOLeN3WGoUyeJeItQOIlEjWOv/2Mj5vqAFtv48HLTJ8QXm1cgaLaOkizI9GANIEmUgNSQV8bAv+7vI5pRWt529vUy40XRt8e+CrNW8+XFvsM6njWAvhx05a2SsNvYP4qwJUoDsJRi4G31a8D4C9Nd3bFlM1yU0n2jEjip9hMxgXrELFHiSZhHYQ19uj5TilbEWvQ5qkgRkxnlySYyN8Ch4nku7WhprNlrbaARr6vay8EmpWGLG+N5Tqkx14kZktcgxhWtAkBEe918A1Fy5dMqrBYfsQ/JFnQ7ZwGqoR2hDIIbW3AMrH+dAngBXmiBT05d9NsFrsdU7huOq9hDY+MI58yjtXsucYiKaFtVaHAuRSooe1PJ5qyow4lNQY8BKOuwp56QOysYA3qM4OTtxOChoP4z6bu3caw/jgLsRc78E/7u1AEYs R3BI55L+ h2hR4jvLL3M4GyWevj47c/Yvs/Pk1137ZPoY0209cvw+vbHDlWmT07fiwIYoOjza0rXTGnmprKU1xd7bx8i7v2jl56PK9l/Q15bGEzj0FODYrlh36cHJkYuFsmvSLEno6iGrUat0b34WMCvn7a57z9ZjfnP4SnzpzclOaIxjUBBKd5flzj20iJ99gSGjBxoFRnIFAP0tmvhFKI8VqVse3ovSEq/GGHxMWp6c4/kYV2DDG6YddHHAkpe642dk1gkjrbNIBDakJRvwfoFcWPsRdWkSNlvH89V4xWPbrjn/A6Keup9VfasuolAsF3yybizPGF80OH5JKyUHiXKXWnUg0N7KDnXIutjIzCqiTMU4a99gw040xmd1h/80aabeEYYaPg/WMmdWcPdHF35khL2BMfG15BbIGh7NMKwqATZaYOCD+r4bayS+mAhtwZtAiXeuqwFkNMRLvyHOTw6V/ggpVJusndazWmINO1Fd/j9mEJkzDqykLuYnJGbbxMin7u3ryCjnpYNcqOqxiNZAQJjH6HqZfMdajAOsKFVXI2EEalRAIBWAaT5hQIc5mq/QadspsXcxs0XmsZ4hzlX1+fjZ3ZeiDZVD7l5RxENTK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 04, 2024 at 10:28:37PM +0000, Catalin Marinas wrote: > On Mon, Nov 04, 2024 at 10:22:37PM +0000, Catalin Marinas wrote: > > On Mon, Nov 04, 2024 at 07:16:20PM +0100, Vlastimil Babka wrote: > > > On 11/4/24 19:00, Matthew Wilcox wrote: > > > > On Tue, Nov 05, 2024 at 12:08:37AM +0900, Koichiro Den wrote: > > > >> Commit b035f5a6d852 ("mm: slab: reduce the kmalloc() minimum alignment > > > >> if DMA bouncing possible") reduced ARCH_KMALLOC_MINALIGN to 8 on arm64. > > > >> However, with KASAN_HW_TAGS enabled, arch_slab_minalign() becomes 16. > > > >> This causes kmalloc_caches[*][8] to be aliased to kmalloc_caches[*][16], > > > >> resulting in kmem_buckets_create() attempting to create a kmem_cache for > > > >> size 16 twice. This duplication triggers warnings on boot: > > > > > > > > Wouldn't this be easier? > > > > > > They wanted it to depend on actual HW capability / kernel parameter, see > > > d949a8155d13 ("mm: make minimum slab alignment a runtime property") > > > > > > Also Catalin's commit referenced above was part of the series that made the > > > alignment more dynamic for other cases IIRC. So I doubt we can simply reduce > > > it back to a build-time constant. > > > > I principle, I wouldn't reduce it back to constant though the 8 vs 16 > > difference is not significant. It matter if one enables KASAN_HW_TAGS > > and wants to run it on hardware without MTE, getting the *-8 caches > > back. > > > > That said, I haven't managed to trigger this warning yet. Do I need > > other config options than KASAN_HW_TAGS and DEBUG_VM? > > Ah, I was missing SLAB_BUCKETS. I'll have a look tomorrow. > > -- > Catalin Thank you for reviewing. I just sent v2 so please take a look at that instead. v2: https://lore.kernel.org/linux-mm/20241105022747.2819151-1-koichiro.den@gmail.com/