From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A92D4EEAA62 for ; Thu, 14 Sep 2023 18:45:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E07F6B02CE; Thu, 14 Sep 2023 14:45:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 390416B02D0; Thu, 14 Sep 2023 14:45:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 27F2D6B02D2; Thu, 14 Sep 2023 14:45:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1817A6B02CE for ; Thu, 14 Sep 2023 14:45:54 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D3E7EA0F4D for ; Thu, 14 Sep 2023 18:45:53 +0000 (UTC) X-FDA: 81236082186.10.32118BC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 849B710001C for ; Thu, 14 Sep 2023 18:45:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HrsllLxi; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694717151; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Yvl0oZS06u+Mc5pUy8196yl56j2FK2OsnzUd+32T3ds=; b=7zn30m3X6TVJ7iKDp4szokpgL9U9hBtZbPd0V6LJdzK/YmvKYFdKZKb4LUHr1hkIUzlIQ/ V2bfjlQvELbicV+ihgqRf4XSptOoQnABDHoM+K7ZbHfvTOektdVuVwnXGqnxoN/0vmKmdo kjYuaEj057L8dK3Delf/ykK5JmJLcWc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=HrsllLxi; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694717151; a=rsa-sha256; cv=none; b=qmxDEa6Q26xznns4Z6sh8E7f5ihr5XwVfLF31pRRMEwkCpH7yV8RFC/d5/PEonjDeYnev3 ESVhuEj+CBFVWheURmXbd0bJLGTuv+qMcbq7AdlDC858oJrTgfasxcyLQwRSX8aGQ/S7Fz 3GkvF5/2ZFOAWG5F4YGg+Xs4OvuQzts= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1694717150; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Yvl0oZS06u+Mc5pUy8196yl56j2FK2OsnzUd+32T3ds=; b=HrsllLxiNsps6W50G39kVju8X/uMt5KsnakajWr9WuPgasjrqcU3wHbFK3vF25psp8OpY8 zZUXYRt7w7OjJPGjhwmkw+wbvvoGrm2O3KOY7Zi4uONFOX5A+dzlRwYSFS3cdb363a063A +UOMuEu2TC6xJFKbkvXtYcU9ofD6Xb8= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-286-HbeXPAnpNwi313wlVhDlXg-1; Thu, 14 Sep 2023 14:45:47 -0400 X-MC-Unique: HbeXPAnpNwi313wlVhDlXg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31c5c762f97so913790f8f.1 for ; Thu, 14 Sep 2023 11:45:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694717146; x=1695321946; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Yvl0oZS06u+Mc5pUy8196yl56j2FK2OsnzUd+32T3ds=; b=n4Mv4q2/f2RI+lPCT/blsZTNI+rYZfosiomeDbjdfjbsQnlk7s7etaP3bspa8sJDPR 7/8eqEDamVfbz43KF4la6S+kayGiBtO4CcZjL9jrftzRYIpm40RFKFCstdoDGIn6tNWC MfMkTu4GOxKxAeujBLVwgcyMarAqAzsPazDJ7P2eWUU6OJOmLVEFKF9vX247+M0Xgc83 nE+L5eoM5d9kX5rJ0zCBAL1ktG0BvLzM0F7Ivm4cBzF4gTIk3p+f0z91NYVgcUk2nk0g Fw8NBUJcj475+IU3zH6ca+RN5Z7wGV21YvFCZjq8wYYJFgbxGnWacD7++hvwqjlG1iA6 ZxJg== X-Gm-Message-State: AOJu0YzBFaKF5KDqCYlaTC1xaFPNMVQUaZ0FQt0I0Wv9Ci69gFKGpFAV U2hCU+A4A+TFzlr/BTtR8X1mjEAv61OwZvt0N3KVZSIV1vHRlOA8WAb7V/IUr+6YP5KeIjMFEAZ iQhJXQj7Y7Es= X-Received: by 2002:a5d:6603:0:b0:317:5e5e:60e0 with SMTP id n3-20020a5d6603000000b003175e5e60e0mr5665428wru.28.1694717146327; Thu, 14 Sep 2023 11:45:46 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF5Q3PlMjzGnGFHx6HU3sWTqn5GaqBgVvM4/5Qktf8taBcPNuKuptBpP34W65Xvm7xkb6quGg== X-Received: by 2002:a5d:6603:0:b0:317:5e5e:60e0 with SMTP id n3-20020a5d6603000000b003175e5e60e0mr5665391wru.28.1694717145824; Thu, 14 Sep 2023 11:45:45 -0700 (PDT) Received: from ?IPV6:2003:cb:c71c:600:4630:4a91:d07:7095? (p200300cbc71c060046304a910d077095.dip0.t-ipconnect.de. [2003:cb:c71c:600:4630:4a91:d07:7095]) by smtp.gmail.com with ESMTPSA id j15-20020a5d604f000000b0031779a6b451sm2408478wrt.83.2023.09.14.11.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 14 Sep 2023 11:45:45 -0700 (PDT) Message-ID: Date: Thu, 14 Sep 2023 20:45:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 2/3] userfaultfd: UFFDIO_REMAP uABI From: David Hildenbrand To: Matthew Wilcox , Suren Baghdasaryan Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, brauner@kernel.org, shuah@kernel.org, aarcange@redhat.com, lokeshgidra@google.com, peterx@redhat.com, hughd@google.com, mhocko@suse.com, axelrasmussen@google.com, rppt@kernel.org, Liam.Howlett@oracle.com, jannh@google.com, zhangpeng362@huawei.com, bgeffon@google.com, kaleshsingh@google.com, ngeoffray@google.com, jdduke@google.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com References: <20230914152620.2743033-1-surenb@google.com> <20230914152620.2743033-3-surenb@google.com> Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 849B710001C X-Rspam-User: X-Stat-Signature: b9zfwc7fumphcmpybkyrqnte4pugpwfz X-Rspamd-Server: rspam01 X-HE-Tag: 1694717151-424321 X-HE-Meta: U2FsdGVkX18oMYw/ucxDZSZP5vljiWqWkSmMTN//HzBC6dLYw5kBNJRbAu4ClWO9SmnGKQTICBdlGmpDEZn9GFqb9PeZTUQ3dX6izQigg4l/mOvMgjjoCRI0Cwqqd2NHabVmVVXDzGLRyt/pUaAE9Wlmg/rSzT9+aHwjkbO0fomwOHS2iao6gz0UDfuDvlc8nOrxDzZrPt7JWR0v9KfqO47H+5OrxfnX4eHUaxoO3qM9lYCF4bLsDi0Sa4LzAO9J3kY/Sw/rbK+CVPvHkpu3+22FG8BvrTc45AP/urvohg9guQgVg+yMBWu1ulbRVtdGCKKYJmxCZvcTKF/zLcnuyTq7NYPqzd9Gmj1SaEFKRFzDOr06IRY0MsPqy2Ocnao6ksQUqS4h7mAQpQK3hTHxpg7PEBeeKJvb6jYDHd0uVMvg1UMqN1G7Ybj5KZPpQOj5Di0rcBzy+qjFwz00E4wrgIE8/IE0pX77C4UgT0MNj7ZS2Q9Z9LRIJBhASDDtuYOEaCZIhlhO0tyWs2uHdssFJG0yzJhpBj1aihxFM+Q1Jhhc+H6cz3p4JNZCDWhaAL7R/mSd7cicD7XXVVvNa0neOnZIKrTUrVJQSRbPWOLaKLL50wCb3/Pl+mTzISUhBHSk8yQvAwXos8LeBTw8CE/SMEQmNR0Ih+JxOvAo1SfHYoLr1IxjRch2SCdGBa87hdmiLyblqb4vdnRF5GqsKtqBDOOOnJR9Bgo9sTb0jzVLT0ZPpt2QNG94HCRJR1vTsTyCGCNfbFUu/ZIpu4tVLSTmeePS82sxcyIfHNV0d8YIXKoadiZY+lgqDOFVPZqKrtFte+hm9am12Xd7gkUYbuZ7JWAyArvAYU4VwYMCQ9QT8SNl7KWMST9Kg1yOETXNi5mNe9HtFg65slO865bXjAWWRlicyUvBk+AgTuRv4bsgD2mJxHtDoSAbVTwDEMVron4fIyEShRbQKwM9gpHYH7u 1O2lQez6 +ddzJSrtv/7VyLP580BhTKsjYfCvimJRnc9+VCc3mqt1j15Vrj35/T9P8IpKZ8hyv+tsyxQ1Y1li8NSZ9e+nhix7fMRdGEUKkKkOehoNFG9VqPeUSIj3oyNRScsrNyfhspSDT4f4aY7ccGhgrXdaFLxq4MpPCdtKVZDyObrIXa2yv4f4NldWxc7nh7Bhqx2CwQ4Xp614KJKVrKCXeoY4LIpifKdUBaYaPBvGxeNGAM9uJi6THpvW2A/lBQEeNR5G8d/37h4GZFRuul/yV3BFPwWgFyUyOXXscFjOQ+H1fAPaCdsXFF3oECL+2QbTjD6p0hR8MfWvrexMYWPAuy+l7QidA7MBYwYtA+Z4xVYNsAHBsuGIs5jNv/IGDIgGhvvPHqsgXdhn30ZBFGsIs3xZbRyne3moRLAEwQ57uReXoMDVNJO4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 14.09.23 20:43, David Hildenbrand wrote: > On 14.09.23 20:11, Matthew Wilcox wrote: >> On Thu, Sep 14, 2023 at 08:26:12AM -0700, Suren Baghdasaryan wrote: >>> +++ b/include/linux/userfaultfd_k.h >>> @@ -93,6 +93,23 @@ extern int mwriteprotect_range(struct mm_struct *dst_mm, >>> extern long uffd_wp_range(struct vm_area_struct *vma, >>> unsigned long start, unsigned long len, bool enable_wp); >>> >>> +/* remap_pages */ >>> +extern void double_pt_lock(spinlock_t *ptl1, spinlock_t *ptl2); >>> +extern void double_pt_unlock(spinlock_t *ptl1, spinlock_t *ptl2); >>> +extern ssize_t remap_pages(struct mm_struct *dst_mm, >>> + struct mm_struct *src_mm, >>> + unsigned long dst_start, >>> + unsigned long src_start, >>> + unsigned long len, __u64 flags); >>> +extern int remap_pages_huge_pmd(struct mm_struct *dst_mm, >>> + struct mm_struct *src_mm, >>> + pmd_t *dst_pmd, pmd_t *src_pmd, >>> + pmd_t dst_pmdval, >>> + struct vm_area_struct *dst_vma, >>> + struct vm_area_struct *src_vma, >>> + unsigned long dst_addr, >>> + unsigned long src_addr); >> >> Drop the 'extern' markers from function declarations. >> >>> +int remap_pages_huge_pmd(struct mm_struct *dst_mm, >>> + struct mm_struct *src_mm, >>> + pmd_t *dst_pmd, pmd_t *src_pmd, >>> + pmd_t dst_pmdval, >>> + struct vm_area_struct *dst_vma, >>> + struct vm_area_struct *src_vma, >>> + unsigned long dst_addr, >>> + unsigned long src_addr) >>> +{ >>> + pmd_t _dst_pmd, src_pmdval; >>> + struct page *src_page; >>> + struct anon_vma *src_anon_vma, *dst_anon_vma; >>> + spinlock_t *src_ptl, *dst_ptl; >>> + pgtable_t pgtable; >>> + struct mmu_notifier_range range; >>> + >>> + src_pmdval = *src_pmd; >>> + src_ptl = pmd_lockptr(src_mm, src_pmd); >>> + >>> + BUG_ON(!pmd_trans_huge(src_pmdval)); >>> + BUG_ON(!pmd_none(dst_pmdval)); >>> + BUG_ON(!spin_is_locked(src_ptl)); >>> + mmap_assert_locked(src_mm); >>> + mmap_assert_locked(dst_mm); >>> + BUG_ON(src_addr & ~HPAGE_PMD_MASK); >>> + BUG_ON(dst_addr & ~HPAGE_PMD_MASK); >>> + >>> + src_page = pmd_page(src_pmdval); >>> + BUG_ON(!PageHead(src_page)); >>> + BUG_ON(!PageAnon(src_page)); >> >> Better to add a src_folio = page_folio(src_page); >> and then folio_test_anon() here. >> >>> + if (unlikely(page_mapcount(src_page) != 1)) { >> >> Brr, this is going to miss PTE mappings of this folio. I think you >> actually want folio_mapcount() instead, although it'd be more efficient >> to look at folio->_entire_mapcount == 1 and _nr_pages_mapped == 0. >> Not wure what a good name for that predicate would be. > > We have > > * It only works on non shared anonymous pages because those can > * be relocated without generating non linear anon_vmas in the rmap > * code. > * > * It provides a zero copy mechanism to handle userspace page faults. > * The source vma pages should have mapcount == 1, which can be > * enforced by using madvise(MADV_DONTFORK) on src vma. > > Use PageAnonExclusive(). As long as KSM is not involved and you don't > use fork(), that flag should be good enough for that use case here. > ... and similarly don't do any of that swapcount stuff and only check if the swap pte is anon exclusive. -- Cheers, David / dhildenb