From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF090C47096 for ; Tue, 1 Jun 2021 09:02:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3B9B561375 for ; Tue, 1 Jun 2021 09:02:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B9B561375 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A655A6B00A3; Tue, 1 Jun 2021 05:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A3D2E6B00A4; Tue, 1 Jun 2021 05:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 867C76B00A5; Tue, 1 Jun 2021 05:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 532A06B00A3 for ; Tue, 1 Jun 2021 05:02:22 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id F07FEAC08 for ; Tue, 1 Jun 2021 09:02:21 +0000 (UTC) X-FDA: 78204563682.21.E8E30BD Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf02.hostedemail.com (Postfix) with ESMTP id B28AA4202A1F for ; Tue, 1 Jun 2021 09:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622538141; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lTj0e2ix7Em5ReRBGmBE8UcFjJXaGmDtfxA9DwPKs3Y=; b=W1OR/xcaL1co7Zzd6bSx8uWsj1PjaOqEOmwsDiB6p9c9pXFWy1QrtzsTUhEYdfJQlrDkrk DWkYOqBN6KaIC7vLWtxyBEYPDAMqOzW7VW+amL5PeCNG4SgdlfyyFdFuVk9sSJF9iCIKsO kLVmSf2yI2YpmTQc6O/gfCd3/VPcmcg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-520-bn5YkkGEMkW8IXdb3PHNRQ-1; Tue, 01 Jun 2021 05:02:19 -0400 X-MC-Unique: bn5YkkGEMkW8IXdb3PHNRQ-1 Received: by mail-wr1-f69.google.com with SMTP id c4-20020adfed840000b029011617ea0440so1570600wro.10 for ; Tue, 01 Jun 2021 02:02:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:references:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=lTj0e2ix7Em5ReRBGmBE8UcFjJXaGmDtfxA9DwPKs3Y=; b=EWOFine6QDnWUBOnGTUAmPtk7Sj5EtFhNvIu23x6zQpXh93BMi6w8atHwIBD1x70P/ FLRrS1yf5uXhrIwmHymg/cK7xANgfoIp1X7HZhIyvfauISiaoV+UG53ERo14tKI0tgSI lLSp9GrktQGwlo5rF5WWV8eM6u4Nxhea62DFKgZonXv+UjnJ3fZlpoZ5j3tCM4Y1T2Jf ualyChCGRZOiy/vfjdBMB+dctIyH0b0od5P95/Q3gmkx2jGzQJgfcjZGJ1s8w5Fj6kNq VEWrUntjIU0JBFzCD/U52pFU6VU/RnL1zjcDdPuY368DFWgmQpdztSPws/W+tCQSoK8I piTQ== X-Gm-Message-State: AOAM532KfsdWPX9HrqcFZ7Poqvw/cncyHdF64ZhLojXbGDNog4lnFWes tAGRiP0nOASBy38z0EmGIQGgoCfuf1PUOWZNkFluArUIRbAc24EtA02lyZLOZZuSpCNekfMpH9B VN/E/PzQaSP4= X-Received: by 2002:a05:600c:47c4:: with SMTP id l4mr3421530wmo.145.1622538138391; Tue, 01 Jun 2021 02:02:18 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzye8Yw+0bLOb0SBvbHwXC4HYmyiMFfH3IyzfuxKInF6JuzngzXM+aezXKoW/iZU7+Z69Ow5A== X-Received: by 2002:a05:600c:47c4:: with SMTP id l4mr3421493wmo.145.1622538138179; Tue, 01 Jun 2021 02:02:18 -0700 (PDT) Received: from [192.168.3.132] (p5b0c69ce.dip0.t-ipconnect.de. [91.12.105.206]) by smtp.gmail.com with ESMTPSA id 11sm17960058wmo.24.2021.06.01.02.02.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 02:02:17 -0700 (PDT) From: David Hildenbrand To: Mike Rapoport , linux-kernel@vger.kernel.org Cc: Andrew Morton , Catalin Marinas , Christian Borntraeger , Heiko Carstens , Mike Rapoport , Russell King , Thomas Bogendoerfer , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org References: <20210531122959.23499-1-rppt@kernel.org> <20210531122959.23499-2-rppt@kernel.org> <1efc386c-2cb4-164f-7194-497f142f969f@redhat.com> Organization: Red Hat Subject: Re: [RFC/RFT PATCH 1/5] s390: make crashk_res resource a child of "System RAM" Message-ID: Date: Tue, 1 Jun 2021 11:02:17 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <1efc386c-2cb4-164f-7194-497f142f969f@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: B28AA4202A1F Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="W1OR/xca"; spf=none (imf02.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 170.10.133.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam04 X-Stat-Signature: cr86ch79ncm9c9p866t4we54chq4yjps X-HE-Tag: 1622538134-657229 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 01.06.21 10:45, David Hildenbrand wrote: > On 31.05.21 14:29, Mike Rapoport wrote: >> From: Mike Rapoport >> >> Commit 4e042af463f8 ("s390/kexec: fix crash on resize of reserved memo= ry") >> added a comment that says "crash kernel resource should not be part of= the >> System RAM resource" but never explained why. As it looks from the cod= e in >> the kernel and in kexec there is no actual reason for that. >=20 > Are you sure? >=20 > Looking at kexec-tools: kexec/arch/s390/kexec-s390.c >=20 > get_memory_ranges_s390() wants "System RAM" and Crash kernel only with > "with_crashk=3D1". Your patch would change that. "Crash kernel" would > always be included if you make it a child of "System RAM". >=20 > Further, get_memory_ranges() and is_crashkernel_mem_reserved() look out > for "Crash kernel\n" via parse_iomem_single(). >=20 > However, parse_iomem_single() does not care about ranges that start wit= h > spaces IIRC via > sscanf(line, "%llx-%llx : %n" ... I think I'm wrong about that one because I read "Input white-space characters (as specified by the isspace function) are=20 skipped, unless the specification includes a [ , c , or n specifier" So having it as a child won't affect parse_iomem_single(). --=20 Thanks, David / dhildenb