From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32701C433EF for ; Mon, 25 Apr 2022 20:03:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B1FD46B00A9; Mon, 25 Apr 2022 16:03:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ACF0B6B00AA; Mon, 25 Apr 2022 16:03:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 998326B00AB; Mon, 25 Apr 2022 16:03:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 89E6A6B00A9 for ; Mon, 25 Apr 2022 16:03:08 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 69E8E2058F for ; Mon, 25 Apr 2022 20:03:08 +0000 (UTC) X-FDA: 79396475256.20.2369855 Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) by imf21.hostedemail.com (Postfix) with ESMTP id 3B8E01C004A for ; Mon, 25 Apr 2022 20:03:05 +0000 (UTC) Received: by mail-il1-f170.google.com with SMTP id r17so10077909iln.9 for ; Mon, 25 Apr 2022 13:03:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=6IUFVGvfVxw7l6YMhU424l8XqBpC7fGs6gju1QrjU6I=; b=b3u4xyXqePElE6uzOsARKY8+PI4TX3Kfwz1v+pt+aDBG6YYxf8B4BFF122dVgsWa0G wTroXZKBEgXygfLWgFZ6duEffBwEcqbKlxo2oXvU6f5+c465slS+cKlD6utjJ9VRtGKz E23GQlTrmCfcHJ2Lo22SWt5mHhkrQ8ecf4i5M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=6IUFVGvfVxw7l6YMhU424l8XqBpC7fGs6gju1QrjU6I=; b=sKQUOCM5gQot6FwReGQhnxrWnWRMxlR4bNmu+HVoZP1ov8Ruk8O/quV3+aFaUHAqXX oqTivz3EGF2JeTelN1HoA4TcRPxSIx4mHmfKhK6LG0T9pj8mGdNBCqr9vmRLq3tB5E71 x1U1XakuywhUhQOJARABgYnOrk1X6Ch9vBsSpCFBFxmSKJ53029/wOSD7n98N28w5DOc XncXPiQikg46JUDViY3L6LNRrOmHIS1vp6Dwn2ads4p8mbzU7mbrQx1vh1rnEABFXk5U ybR/KoxsAnq4dKkIzAHi4W/zdSCTVo9mHGRbe8mfrhb2RkUgALc+sdGFE5Zlis/sTiCY pifg== X-Gm-Message-State: AOAM533Cl1U26TfzpXl81SBzbtwGN+l1gNZOEKoCSpQbW2ZOI1f7Uzs4 VwPj7aVUoJ70R+tvleWVRx1EGQ== X-Google-Smtp-Source: ABdhPJz7jabMcQMahAgzEB+tpsiYw2q8m1KcTY1nfihf3Zk6kiyb14v45rF0wOE1m6bpHahdMHyESw== X-Received: by 2002:a05:6e02:190c:b0:2cd:9331:2750 with SMTP id w12-20020a056e02190c00b002cd93312750mr3026582ilu.214.1650916987125; Mon, 25 Apr 2022 13:03:07 -0700 (PDT) Received: from [192.168.1.128] ([71.205.29.0]) by smtp.gmail.com with ESMTPSA id s8-20020a056e021a0800b002cd8179e7a0sm5202881ild.16.2022.04.25.13.03.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 Apr 2022 13:03:06 -0700 (PDT) Subject: Re: [PATCH RESEND] selftests/damon: add damon to selftests root Makefile To: Yuanchu Xie , SeongJae Park Cc: Shuah Khan , Markus Boehme , Andrew Morton , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , David Rientjes References: <20220418202017.3583638-1-yuanchu@google.com> <93c3f9b4-7e14-858b-bf6c-23e4f3bec232@google.com> <31edb348-d802-0ee5-c13d-a9ef17b2ea8a@linuxfoundation.org> From: Shuah Khan Message-ID: Date: Mon, 25 Apr 2022 14:03:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <31edb348-d802-0ee5-c13d-a9ef17b2ea8a@linuxfoundation.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Stat-Signature: 5buwety1p7dh53qoau8fymuiwsfnxdyo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 3B8E01C004A X-Rspam-User: Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=google header.b=b3u4xyXq; dmarc=pass (policy=none) header.from=linuxfoundation.org; spf=pass (imf21.hostedemail.com: domain of skhan@linuxfoundation.org designates 209.85.166.170 as permitted sender) smtp.mailfrom=skhan@linuxfoundation.org X-HE-Tag: 1650916985-438703 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 4/25/22 1:37 PM, Shuah Khan wrote: > On 4/24/22 1:35 PM, David Rientjes wrote: >> On Mon, 18 Apr 2022, Yuanchu Xie wrote: >> >>> Currently the damon selftests are not built with the rest of the >>> selftests. We add damon to the list of targets. >>> >>> Fixes: b348eb7abd09 ("mm/damon: add user space selftests") >>> Reviewed-by: SeongJae Park >>> Signed-off-by: Yuanchu Xie >> >> Acked-by: David Rientjes >> > > Thank you. Applied to linux-kselftest next for 5.19-rc1. > The test builds with warnings. Would you like to fix these as well? make gcc huge_count_read_write.c -o linux_5.18/tools/testing/selftests/damon/huge_count_read_write huge_count_read_write.c: In function ‘write_read_with_huge_count’: huge_count_read_write.c:23:9: warning: ‘write’ reading 4294967295 bytes from a region of size 1 [-Wstringop-overread] 23 | write(filedesc, "", 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:378:16: note: in a call to function ‘write’ declared with attribute ‘access (read_only, 2, 3)’ 378 | extern ssize_t write (int __fd, const void *__buf, size_t __n) __wur | ^~~~~ huge_count_read_write.c:25:15: warning: ‘read’ writing 4294967295 bytes into a region of size 25 overflows the destination [-Wstringop-overflow=] 25 | ret = read(filedesc, buf, 0xfffffffful); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ huge_count_read_write.c:14:14: note: destination object ‘buf’ of size 25 14 | char buf[25]; | ^~~ In file included from huge_count_read_write.c:8: /usr/include/unistd.h:371:16: note: in a call to function ‘read’ declared with attribute ‘access (write_only, 2, 3)’ 371 | extern ssize_t read (int __fd, void *__buf, size_t __nbytes) __wur | ^~~~ thanks, -- Shuah