From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4CB54E7D0D2 for ; Fri, 22 Sep 2023 07:19:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFEA86B0200; Fri, 22 Sep 2023 03:19:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DAF1A6B0252; Fri, 22 Sep 2023 03:19:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C4F4B6B026F; Fri, 22 Sep 2023 03:19:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AD8CE6B0200 for ; Fri, 22 Sep 2023 03:19:35 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 837711CA0E7 for ; Fri, 22 Sep 2023 07:19:35 +0000 (UTC) X-FDA: 81263383110.29.4D13D42 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf10.hostedemail.com (Postfix) with ESMTP id DE9F1C0002 for ; Fri, 22 Sep 2023 07:19:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695367173; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p7LOrujP0YKYTt+K1v6o+bZW8+4gi5J/H9/JpznARtM=; b=0BEHPek3L61Eiqx6TgQvpBS2HxYNFcjKI018QAx+N+LQvHzMBdZHXqBrN5h0IYbrNMLQrY /PXG/HyN7XJ4MRLGuH/K+NSK+ohAcELmh+xOn1OxhQqwNgFLiniyYcyXB0/dbVo1nJbzwS 2QlbAIgvgPRGdEQpghvE6e/27R/G9Xg= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf10.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695367173; a=rsa-sha256; cv=none; b=z2LNs65pYTO2gqp64r3+r6Nf384wza4gImpLdqD8LMQiKqC7gq9M+Zt45/NQBep+IuwcS7 8DWUN+IUbehgVDtqzBYtmG506R4l6NNZTMS67f9RXZGJjhQfQ13bo0iOu0MIAospbC8F9E GpdWG+CB7QjjwckyfWkCCrLM0cLJJe4= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C9E51DA7; Fri, 22 Sep 2023 00:20:07 -0700 (PDT) Received: from [192.168.68.106] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 11BBC3F5A1; Fri, 22 Sep 2023 00:19:20 -0700 (PDT) Message-ID: Date: Fri, 22 Sep 2023 08:19:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 2/8] powerpc: hugetlb: Convert set_huge_pte_at() to take vma Content-Language: en-GB To: Christophe Leroy , Catalin Marinas , Will Deacon , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Paul Walmsley , Palmer Dabbelt , Albert Ou , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Gerald Schaefer , "David S. Miller" , Arnd Bergmann , Mike Kravetz , Muchun Song , SeongJae Park , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Anshuman Khandual , Peter Xu , Axel Rasmussen , Qi Zheng Cc: "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-parisc@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-riscv@lists.infradead.org" , "linux-s390@vger.kernel.org" , "sparclinux@vger.kernel.org" , "linux-mm@kvack.org" , "stable@vger.kernel.org" References: <20230921162007.1630149-1-ryan.roberts@arm.com> <20230921162007.1630149-3-ryan.roberts@arm.com> <9864a7eb-004d-14c6-c2bd-bb9333fe67be@csgroup.eu> <0958d813-15f8-5ed5-1e20-08b8feb465ad@csgroup.eu> From: Ryan Roberts In-Reply-To: <0958d813-15f8-5ed5-1e20-08b8feb465ad@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: DE9F1C0002 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 437aiur9z89g349tpajpt77hpwmcd8eh X-HE-Tag: 1695367172-13221 X-HE-Meta: U2FsdGVkX19BErx5Ax63wzA5JhaEdPogdXNfSm14+cIbMMVvSucJy/ECrRWO7rPJx/0sjbaXN2XddZCbdb7dsjQyxIAPGA2BlPbIcK2laTa6f8jyLoqMwBswrvXiEg0N2OOM3PtOn5dWTmaVq3tLoYSPG3UIn6FNIv5DW4cUClUHEaDdZDwKCmLh5treXmcVvl4wnmjGdwS8aPbkNMiZhdbFQL/WTgXnqWNRhigR0xaVb6Xv7hdvfveTkpG3oPy9dyhmTwcARoKueNr3L6FT4hyOPUuJg0f653qUn6TYqkUGGwoaqEYvQWHFGzlQYnmSWL10aHtn1G+b2cIi0tvGnhYeZExnXUap3kHg0slmW7uXRyRjgGjwA345mGNPqN8ln9Pe2tr/WKCkN04h5TLusdQjqQpTHOhAF2ElSBC1Pbfx6ogox46tqqtX7co4r2Xfjvti21Z2gCG/ZmvUl2H2YnQqMqPOfWg3sk6NKx9N4uIBiciNZUlG5eOToKnFSzFGBA5jvFX/mQAoo4SbHdxEzfXfV7QqizPed+WqHV4G6DFKkEIjnzg+YokeyTEKXwGkx948gH87m5c1iR4mtBvlh0yxWib3Q78CWgp/J2PVYPMi5YlZaXiGLUFyeD2ABEUqkgRuDVSxWJZJpBDYLFVODlSg5kYbYXhNkqNpO1PVOS+NlnDla56x2nvIlzrKftfwJITGH2AhbrrzvVSQFm9AxvvQJxUVF486LnD/pyugsH6KiKHy8W5vQmRc282xQezs0p33Vvdxe0plANj5M5vi9jedRprAUWVEGI0PIqRlXqr9c53XOhHOw5DKow3c0+PHN0RBzE1Btt7gEsuB3VVV7B9EEfNLbcAddNEHSKCyG/iC1eSYNhbv67mkFfG2XqB6mN+n/FDDYONOtFa7cg7YFniBux19RR9KHYDkMUKx0Y7P4v05ewDlwhaOjZFvVXWfzIcIYDS/CdfSFdAVLCf Pidf2Oor +CREM0sQpsalP9bUoNbWl6q1KsbH5gfx1NABplo5iVe3n9qny4ALNKZABdFOHloD49gIwlCvZGtmIM11AAqnIXT3mNy7TgDROuTCGNVTYe73M27iqQOdFQZYX+nPYwatTcs5J7aXCWrNExGkHYU4WJ9Wm///ZkIw2nvJqz2MC4en4m48tzhwp9SRhdb4Y5JCEV9udFWMTzJNUxFkwDdzhr1jDYUPFp2IOeZ0t+QzI2Hodg3o= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 22/09/2023 07:44, Christophe Leroy wrote: > > > Le 21/09/2023 à 20:43, Christophe Leroy a écrit : >> >> >> Le 21/09/2023 à 18:20, Ryan Roberts a écrit : >>> In order to fix a bug, arm64 needs access to the vma inside it's >>> implementation of set_huge_pte_at(). Provide for this by converting the >>> mm parameter to be a vma. Any implementations that require the mm can >>> access it via vma->vm_mm. >>> >>> This commit makes the required powerpc modifications. Separate commits >>> update the other arches and core code, before the actual bug is fixed in >>> arm64. >>> >>> No behavioral changes intended. >> >> This patch doesn't build, allthough I have also applied patch 1. Is >> something missing ? >> >> CALL scripts/checksyscalls.sh >> CC arch/powerpc/kernel/setup-common.o >> In file included from arch/powerpc/kernel/setup-common.c:37: >> ./include/linux/hugetlb.h: In function 'huge_ptep_modify_prot_commit': >> ./include/linux/hugetlb.h:987:28: error: passing argument 1 of >> 'set_huge_pte_at' from incompatible pointer type >> [-Werror=incompatible-pointer-types] >> 987 | set_huge_pte_at(vma->vm_mm, addr, ptep, pte); >> | ~~~^~~~~~~ >> | | >> | struct mm_struct * >> In file included from ./arch/powerpc/include/asm/hugetlb.h:13, >> from ./include/linux/hugetlb.h:815: >> ./arch/powerpc/include/asm/nohash/32/hugetlb-8xx.h:49:45: note: expected >> 'struct vm_area_struct *' but argument is of type 'struct mm_struct *' >> 49 | void set_huge_pte_at(struct vm_area_struct *vma, unsigned long >> addr, pte_t *ptep, pte_t pte); >> | ~~~~~~~~~~~~~~~~~~~~~~~^~~ >> cc1: all warnings being treated as errors >> make[4]: *** [scripts/Makefile.build:243: > > Oh, I realised that it requires patch 6 to build properly. This is not > good. Your series should be bisectable, that means it must build and run > successfully after each patch. Therefore you have to squash patches 1 to > 7 all togethers. Yeah my bad - sorry about that. I thought it would be better to separate the changes for each arch. But as already suggested by Andrew and Catalin, I'll squash the first 7 patches into 1 for v2. > > I'll send you comments on the powerpc part in another mail. > > Christophe