From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 588D7C5B543 for ; Wed, 4 Jun 2025 12:17:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E77918D0014; Wed, 4 Jun 2025 08:17:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E27DD8D0007; Wed, 4 Jun 2025 08:17:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D17258D0014; Wed, 4 Jun 2025 08:17:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AF6578D0007 for ; Wed, 4 Jun 2025 08:17:14 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3056AC13E3 for ; Wed, 4 Jun 2025 12:17:14 +0000 (UTC) X-FDA: 83517617988.26.6B25D93 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf03.hostedemail.com (Postfix) with ESMTP id 5D38220011 for ; Wed, 4 Jun 2025 12:17:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749039432; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aBn9odGemQ8H1h/iKx8th069GjYwNfk2nw8qOruwTWE=; b=u/e6L2oIsMO2JVrKPg8n48eOXG7rxnQkHBdBTsmNPCxABnOEjgZDpbrpUWHqcPFfKhaWh7 NM36BudoSFDJmUBFoa+5Ce1uOKJXMy2Xq7ZA9tjXE6FH9vs+EKn2Dm5ga01IgiBLSD8EJO C9Xz+fN8gjPZO2DGAgBRXiNXQQBB1nQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf03.hostedemail.com: domain of linyunsheng@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linyunsheng@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749039432; a=rsa-sha256; cv=none; b=NivTvamFvVwM2idD3A0L8+UUfz8LvfOQAALBux7AlCbAIV56Yrs/CRMBiDExyN4Fmvl/qi wL1KPKqceXcSnmC/hsENE192+7UF4sttz7ZRivPG4kPW8cYTbt4zoXA9Zz4irU9Xt8bDlS rR5XNLjq0IxVzMfWtWG/q4ks+Y5DnEg= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4bC60Q6NdBz10Wct; Wed, 4 Jun 2025 20:12:38 +0800 (CST) Received: from dggpemf200006.china.huawei.com (unknown [7.185.36.61]) by mail.maildlp.com (Postfix) with ESMTPS id D39C91400C8; Wed, 4 Jun 2025 20:17:06 +0800 (CST) Received: from [10.67.112.40] (10.67.112.40) by dggpemf200006.china.huawei.com (7.185.36.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Wed, 4 Jun 2025 20:17:06 +0800 Message-ID: Date: Wed, 4 Jun 2025 20:16:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 1/3] mm,slub: Do not special case N_NORMAL nodes for slab_nodes To: Oscar Salvador , Andrew Morton CC: David Hildenbrand , Vlastimil Babka , Jonathan Cameron , Harry Yoo , Rakie Kim , Hyeonggon Yoo <42.hyeyoo@gmail.com>, , References: <20250603110850.192912-1-osalvador@suse.de> <20250603110850.192912-2-osalvador@suse.de> Content-Language: en-US From: Yunsheng Lin In-Reply-To: <20250603110850.192912-2-osalvador@suse.de> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.112.40] X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To dggpemf200006.china.huawei.com (7.185.36.61) X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5D38220011 X-Stat-Signature: 9dfbimpdm9gogndz951yhom8b5xowbbf X-Rspam-User: X-HE-Tag: 1749039430-979710 X-HE-Meta: U2FsdGVkX18yEs93c7pW4nAo2T9quXvo0YQQ44wrVYIZCLzYQ6P1/7jS8xzWJ7ECjtJjIh2wMkovJh9ZOZUeDtceQ0nFEQa78pvjbG2oDMGGODLCe/fiwnAj4VgDmsV8PF/QJURoFHUJeGCxqDM8jdKlh7PPSVR5R7yCSQkr8bSHAlCdZDn3Xhf05UYfb4xe8aQE2PxFIOMJ3depQ2vmqkUgmljWRA4JPY4rHASN3Uw6477Hkq/mh96Wb3wlS20aoTJzsZxbN2FpOZldDsvTWkMrVF0Mt5WG227hqJ1xUV1qQcQBcAxDYfcb+B0NJoZYh6U4zV5nI0pjnVXD3o9AmAlDswwINdQBiHc8BblIViIprP/wstRnNyGiBpenFUYVx0LkKJhX+gQ4VzNBjuSy5IdHwGVfX0zeG8wZ/RmOoSXuMzzxu2peBCMcEtVJacTgAmqOTWkO4DU8yXp+KbbiKTqPK4NvyMOT+oxFvlOMUwvvWVonYcBhwTG4osZA9GUw5MGUU/3s+Tz7LDAVPdUfphIo0pDkPYRHhN4s2Lg/LqhZ5u4Fj8a0vC/Ww9eOxAz9IjmB1aEPQGxAGapNy/s39SKPoqBYF5gXzHsl69k9iUKPWsQHrYuTJkkt8uQLe5JIeesz3bA+nyb7f1/7t4uPAhupyCktt6ZT6qE82626e79HNeQKbKPnFx/aH9jzAkay21kVGsxzuJNnfON/dEGfKgWuZxfwLn95dZPhGtRIis2XNHY2eBjWCWf1Oq9/sQ83+NiTSQcebYT6/4yUmvfSZ92b2dTYbFo8Cwyt/5IU+P6i0pk4CVWXj6TYUc6gvMVEXlqpWljdAygJL6AT/dnldAVQ2ZWCa+QmI5lvuhFsJ+DcThxK0V1VndiupgnD+H1esFHCY0cmpt2P+RPqIzEu8HqDqCc3unq3KtYrvMLR8oUIOyL1BdYWT3jaW8djEzM2mMN46io7TicRrCdpv37 nGon9JSM 5l8LW7X1Mo3Pu2H7k/mdWnQwjLMtrOqXGzpaLZX0sIibV+aqk13zGp+czc9A3uzMdNJznwNV8VokDIltYQ8IoVO8Oi9H/hQcmlIAAEdr8YF2edYrFZyFwIK/YkSD0/vjFjo4Z8uGBXn64aVXpj7XVUgdaoz6b4bBd69aCapt3+Ud6izOOaFZVpkvu0CArPp9nvMw5SlOnl29V++LYHhNT63DOJdprn9T7agQC8wcf/gGmx9qL5DdVIkiSjOWh/4MEPmyCFj+gb6jkhML4IkgU9z+brtUV3KfNMAn65KAbSal1yRdoVN36A8ub7Xiu69SP2dee/RQaB1rHp5GHWHQ0zB2Dretj7TYw6rK4jMBB186ET20= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2025/6/3 19:08, Oscar Salvador wrote: > Currently, slab_mem_going_going_callback() checks whether the node has slab_mem_going_going_callback() might be a typo here. I suppose slab_mem_going_online_callback() might be the correct one here. > N_NORMAL memory in order to be set in slab_nodes. > While it is true that gettind rid of that enforcing would mean > ending up with movables nodes in slab_nodes, the memory waste that comes > with that is negligible. > > So stop checking for status_change_nid_normal and just use status_change_nid > instead which works for both types of memory. > > Also, once we allocate the kmem_cache_node cache for the node in ^^ seems like a minor nit, an extral space for the above.