From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E64A8C25B4E for ; Sun, 22 Jan 2023 11:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79E5E6B0072; Sun, 22 Jan 2023 06:54:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 74D546B0073; Sun, 22 Jan 2023 06:54:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5EEBE6B0074; Sun, 22 Jan 2023 06:54:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4F1EB6B0072 for ; Sun, 22 Jan 2023 06:54:21 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 950BAA022C for ; Sun, 22 Jan 2023 11:54:20 +0000 (UTC) X-FDA: 80382277080.06.55F032C Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by imf25.hostedemail.com (Postfix) with ESMTP id A98F7A0003 for ; Sun, 22 Jan 2023 11:54:18 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=agLJLLTV; spf=pass (imf25.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674388458; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SufkmAjwbNPzx+QZI0to5Uf48TUW+IZPLNjbNqCZpfI=; b=Xjga2oXCqA/Cvh4jdhzjfH7YX2YDbra5NheTXlk3lC0NRL1zN3/UE63UNK/kP08+8U8Z2U Sg9u8OTKRuHQrH7elO7DvYx4l30AZNsIzr3itW4R34mEXaWPv3evcFSJyu0URVjXbpRoWh lx7KWOamOt5/AcyMBU7KzdJSewf6xf4= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linaro.org header.s=google header.b=agLJLLTV; spf=pass (imf25.hostedemail.com: domain of krzysztof.kozlowski@linaro.org designates 209.85.221.46 as permitted sender) smtp.mailfrom=krzysztof.kozlowski@linaro.org; dmarc=pass (policy=none) header.from=linaro.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674388458; a=rsa-sha256; cv=none; b=isVPSseT07s4E2l7N2/0k3YirusfPtYGJgPGPgI80xFxXbGOzW2Nc5X1SuEFvV3E0BHu16 5pK0Dt1rS+fe6/361en5v8lbppGCC6cJ1GA5igtbP+MLQDRrR3iUi3yfqBiGw50sPB3CPP GQ/m/X9ZaZfMWkB2JO8/hoYAyGp4AEo= Received: by mail-wr1-f46.google.com with SMTP id h16so8443276wrz.12 for ; Sun, 22 Jan 2023 03:54:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SufkmAjwbNPzx+QZI0to5Uf48TUW+IZPLNjbNqCZpfI=; b=agLJLLTVda4vzbo+pBm1nc5uVfx6hrGX4HQkgIojkD/1cyQqIJv/dW6ozQQZxh9acO 0GIArSOuUVD0jo2VEYapOBIRUz5rU0ickudZecB/MxBJcXysLhAmHyMc4oBteDTIVZMP gWC6imLaRflwc3jb3Je1wClPZlQKNp6xyUYD3v0X33auCHxc+qD/ZA/jJBtt4IwIx7rF gSScl4TsJrIet9k0uAS97cSICY1543XxKH25XG+KtqbOQ1xwZB+O3y7k0SPxq0AYdW3y nsmpTPaZyS0wpbBSnQCu92eqyFbTR8SK3YHX60WCqpdfFl3mYAplQ0n+AxAh2HMkH8Q8 TEWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SufkmAjwbNPzx+QZI0to5Uf48TUW+IZPLNjbNqCZpfI=; b=RIZMBPLgPdxZnUF58Mz6SI7bzS3zUYr7Kwjba6AEFyarAiURYbMWeen55UbxlH0Iah pVsS9/1ZNy/TvbVzTGKpE3R6qaphdSIzVLd3p11qnvWKyPPqJYVx3cL8fxGk+0l2DvkV AFRgOc0mY1g60NEBG+28F43HHGc+EINuK9sLyrQv9Q4BVSjHZQiVB2RN1Cp/vUF/I6cj tpqTvR+l1PA+GtquZGkdOYTbEdvwZWJJ4GICGfmVupGY1Y7bPYW9XIocvQOnYhfdi50a Xdv/TW1LsX7b3CqwrSACkLVHZ7eW/1M6tX27wc79WxBHR/HVYg0vC30IVQKwNtd+jNeq 2YlA== X-Gm-Message-State: AFqh2kr99gMNYCXRzLkr67V+HUBjE8+/zLrXBt0U+Th1kQsTosV4BqwB Vv5nO2WJ2nZRWZH3Tblxv6xGtg== X-Google-Smtp-Source: AMrXdXt21M3CsHbnhN4nC75KtRaK9snE7H1KnN8u8SuCQjR3lZXo7Zes1x4/j1347YU7bM+ZYlALNg== X-Received: by 2002:adf:e9d2:0:b0:2bd:e6f5:5122 with SMTP id l18-20020adfe9d2000000b002bde6f55122mr17418436wrn.65.1674388457426; Sun, 22 Jan 2023 03:54:17 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id ba9-20020a0560001c0900b002b57bae7174sm2174746wrb.5.2023.01.22.03.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Jan 2023 03:54:16 -0800 (PST) Message-ID: Date: Sun, 22 Jan 2023 12:54:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.0 Subject: Re: [RFC PATCH v2 30/31] kvx: Add power controller driver Content-Language: en-US To: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Jules Maselbas , Guillaume Thouvenin , Clement Leger , Vincent Chardon , =?UTF-8?Q?Marc_Poulhi=c3=a8s?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan Cc: Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-31-ysionneau@kalray.eu> From: Krzysztof Kozlowski In-Reply-To: <20230120141002.2442-31-ysionneau@kalray.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A98F7A0003 X-Stat-Signature: ggw3975jdguauoqo57syeyc97ay7sfg1 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1674388458-393145 X-HE-Meta: U2FsdGVkX1/DWlPdWTeEqWavB4cecJzGK57vA4/EME4qYQTgMuaawPSjTuu6Zkw6Jmk9bXDQl+FgT88YjzDRCOCQ6qpt6zgCv10+A2mgM//L4MbmjawuQYNaQsu8IHRms6mlC6X4L0zIg9h9Q8Q7dD+JJcdbPl/ksWrR0QXBU2USZ1agywPCHOswmx7Z7OcroD9pJgFK/2xYteJbhAVPJDrXWXHDXvnZ7RsW474nmZaklgikaFel5m736NhQsZ1Gdp7CYJeUX6rM/4Dg3udAL5k8JfcZp1ZrCD9EDKfH83nerujI2oksINtpeI0mOKHIZPrhWM7vq+Ye0l+XWpz8APKvAbvsJmLAe/no+LGA5MQCXUEN68mdSWytBoysrhOS+KgBgaiFxgZZqiMqvGGeCHu8zlcpI+9XCb0/Bj2+rvhl8mAFpNimqaAX9SywDRdc5Lb7aywimdM2F+5PhOFb0Jsy6Ju+qbjecMkonyv/V5jSkx1psbOHIGqEmDqxhW89tz4w1bYK1Zx8/7otEj3yYBH4pO9c+xqczjeOim6dDRF8sqW6iMlv9MBQG8qsfStRMzLPJoMeKElrcoEcBjrUqiFuAvhmGYCCnpnewLpTfGqAcFPt4zMaIoZanrHNwJypIVCvo8V+zaPP3phG/7Vsag5T3bLwChX2DxjwmW1IO8zk+SeR3GiU9GCSsH1ht2nWgYvtw+EsT6Jg/e2lA692GiDwlc8d8FjeRdiGV4L/GQ1DndfnM/JzXUA7IJ0s87OAcmks7fAqZ02sqVZWQsa9Nu8WSCCSTqUOq8nOZWeFFs9ox2SqdzA4TDm4f2zYjyg4rwuXMvO2K1u0nYE2y4hCi5Sko6evVRjQJsGuN3VIMqa68/ijFXDJ38qaUIoLI0bT1dIfOuduDlnUJ+rGyc6fVnCvwi5f8dBFNmZWpk+0twtYJB6E8gU0DoAW93CqL9CO2cOEnsDbrZSUUgKtsFn 9UFiBls8 QPhYCQopHVqBXWH1HA2//VPaErrcYX+jYk0Th8tYMFxVeZVwleqZUeFgvjewlIR1xENSUxqCuo6nwSn6kZ3b9oq4QRHGiZD+Eaf+SOiJdCwVKYsExU+KFbkuRkpcODhlZYvRfdq9UoArhHu2o+vSFV292hVZwkfh2TL3nADhEHFoQEhjCZ9rt6/yu8E8MDQtHQjJjC712UoNtImsiejGni+30ZzM+G3FFF/RG4xBkNl+cvXmVMRStOEWHziP7S6iBJQ3OjW/L5lfu6c7mclOgmtLJGtc+Doypf8lrJKLpVhIKxV7CDJrlHie8KV8oUh9ZQjRsy5oSP1S93FwoZAJSpYvClYaYyUYdnZ585Pl3MPt5BWOBag5wqZHS7AmjpCtjEhQN95A3Q0hYdSaSqtzrAVdZne/gHbso6HECQVfxDJyeb451EFrrS5m057wjmTOz26sUthlG8dbXMdkF1o9ZPEUqFWIV+9PB4yNGZLi3m+uMDlBMgfbPl/m3+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 20/01/2023 15:10, Yann Sionneau wrote: > From: Jules Maselbas > > The Power Controller (pwr-ctrl) control cores reset and wake-up > procedure. > + > +static struct device_node * __init get_pwr_ctrl_node(void) > +{ > + const phandle *ph; > + struct device_node *cpu; > + struct device_node *node; > + > + cpu = of_get_cpu_node(raw_smp_processor_id(), NULL); > + if (!cpu) { > + pr_err("Failed to get CPU node\n"); > + return NULL; > + } > + > + ph = of_get_property(cpu, "power-controller", NULL); > + if (!ph) { > + pr_err("Failed to get power-controller phandle\n"); > + return NULL; > + } > + > + node = of_find_node_by_phandle(be32_to_cpup(ph)); > + if (!node) { > + pr_err("Failed to get power-controller node\n"); > + return NULL; > + } > + > + return node; > +} > + > +int __init kvx_pwr_ctrl_probe(void) > +{ > + struct device_node *ctrl; > + > + ctrl = get_pwr_ctrl_node(); > + if (!ctrl) { > + pr_err("Failed to get power controller node\n"); > + return -EINVAL; > + } > + > + if (!of_device_is_compatible(ctrl, "kalray,kvx-pwr-ctrl")) { > + pr_err("Failed to get power controller node\n"); No. Drivers go to drivers, not to arch directory. This should be a proper driver instead of some fake stub doing its own driver matching. You need to rework this. Best regards, Krzysztof