From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FA06C04FFE for ; Wed, 8 May 2024 10:48:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF5946B012C; Wed, 8 May 2024 06:48:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA51F6B012D; Wed, 8 May 2024 06:48:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B93CB6B012E; Wed, 8 May 2024 06:48:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 9B85D6B012C for ; Wed, 8 May 2024 06:48:45 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 322301C17BC for ; Wed, 8 May 2024 10:48:45 +0000 (UTC) X-FDA: 82094905410.29.3D09A4B Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 74C742000B for ; Wed, 8 May 2024 10:48:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1715165323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vRDYDvm31hppZYjwiYt/4yttNbELs51oojSOt3t6fqU=; b=ZfvAS+ANsPXLjUOKH8KX9sa+342R+MgoyK3Mu3tIHzGmFLJ8eT02ox3O07HCCiCDEWBbIt 34UztkJFKaoPXG5/170Hf192kjYC+yNe7ZWZY6EchssrfkPH/feGLCSlJ/giPG9UpITur+ /MLocpK2fDjOWVUF9lNDYRSArpJsWFE= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; spf=pass (imf13.hostedemail.com: domain of ryan.roberts@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=ryan.roberts@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1715165323; a=rsa-sha256; cv=none; b=3SLkLTVRafsCzCiroGzXOs37+Sf95Uzd/937o1WazZZc0F38pt1I8LPlNQkiYzHQQ+mvFR x+uaVzlILHMRm0cdlroJSfWzDSU4jQFjZN9yCFDdYKvszDGS6XVXpkESEcbFEGRClGkXqg rUFVENTn+ZDQa71wlz8nvCkSH5DOcTo= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id AE1A91063; Wed, 8 May 2024 03:49:06 -0700 (PDT) Received: from [10.57.67.194] (unknown [10.57.67.194]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 576633F587; Wed, 8 May 2024 03:48:39 -0700 (PDT) Message-ID: Date: Wed, 8 May 2024 11:48:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] mm: shmem: add multi-size THP sysfs interface for anonymous shmem Content-Language: en-GB To: Baolin Wang , David Hildenbrand , akpm@linux-foundation.org, hughd@google.com Cc: willy@infradead.org, ioworker0@gmail.com, wangkefeng.wang@huawei.com, ying.huang@intel.com, 21cnbao@gmail.com, shy828301@gmail.com, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <6b4afed1ef26dbd08ae9ec58449b329564dcef3e.1714978902.git.baolin.wang@linux.alibaba.com> <30329a82-45b9-4e78-8c48-bd56af113786@arm.com> <0b3735bc-2ad7-44f8-808b-37fc90d57199@linux.alibaba.com> <5b23a706-5fb3-41b4-ba2e-d38a29b51820@linux.alibaba.com> From: Ryan Roberts In-Reply-To: <5b23a706-5fb3-41b4-ba2e-d38a29b51820@linux.alibaba.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Stat-Signature: jygtscztfnk8izhp6wnhwuze7db7bmdr X-Rspam-User: X-Rspamd-Queue-Id: 74C742000B X-Rspamd-Server: rspam05 X-HE-Tag: 1715165323-741456 X-HE-Meta: U2FsdGVkX18xSLWjwhcZ2M2uEyVYoDj4alUmxvgM39/EDGugJ/wHZ06XKGdSFcs2bGPMASmk2QK5fYwzhBhJE1cuOOsZx8Msc/OggHKEwZu5qFHMTIx3L7jhRAhIwL+ZvkSH/y9VR0lA0ShDWJIgo84yzCh1da6O1g3QwnBFs50agO9D7Zu20EU3tjEODdYFYwPW7Cz6M98uwVGm3S2HDZZ2dK0ZY2wNCogAnwrtvIxL4riQtItEwRmQtFYg3rruMuOuzEai/je3tHsRW9r5CMjHHfAh6RVBAkEUdUTtWgiODHikHJ77btNOoX0oRh8Dtfg7xxoCjgwce55xg4NN8je5Dvf2ww6fIfFaPuINolvOOY81EbhL7RSDxjTqBQYbZNdl3FFoa/0aNTnTRL91GKlJGlHIjy3jVqpTQiBmvyUR3o2XRV813TwB2JZQnKjCLiBxMUxa3UiurRqaCXxSn+UhXTRFge5doXF88hKgY+x3BXM1oP32nEdfHudYeYPhfRwDRPXvjrpviVikYZenKoXKVGKQmq0CyXyHHYjiKA9j2Lt4M0K1A9Nn8egHAiFGtsDzwg4ArE0ikZlwptJSXthdrl7ozaNA37P2p3UU68rvPID9vxV/GfrV/DrMjnMQURR6nQHrOTsg5zU9Z3fkTd1Hmr5+YMJ5BimfAeiAcjiC/fiQwNJO1YhhPuw82ItsWkJeAAH8RLotz+2mb6IV5DaoezIUwfWAvH/sZYf4yP1z6bAVXk6aRZaMFmSAr6JSsYnYHW5qeMYMo2H6Yw2Q7h15pX4r/BQ0OpZ+dg8SrGVgUeO5hnGdGuBYlFDaZb4qpBwf3UiWiLr/e/KN8bYKzxL7uubsGIQpKZ/9BUKNiCKfNlMlRd91GQF1pdHGSrYHEpxtBafj74O5kDM3P3Lw8op8AZJzwGudUyi45G3LwjAaQsyNF+7mue9Pb1z76KtsTTWefXL8E2LwHy02zBi wfq62BnL I70trnN9zy43kvwfbc4BVX+wQSbgRo+Jv5MFjPL/M0FBXjhwj/JEbHwKZah8Gf1QyVP0vPVwdhvhPAF7fyD40Dml8IrpgGQCMsPCbCZ39b9NOy3l8XkUHj6P+LOc4ZlNPPwGXYY0oZS1sKV64PyhIaaZgJUp2iFArBKAtIc817+lzk/1ZKJuMmMaaUFspNkn0t0yfzrMz2Hkj6D+eflzc5K97cf7Skq6y9Jb3M8pXewT2ncld0Lo0K3iybPtT7Pnyf1Q0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 08/05/2024 10:56, Baolin Wang wrote: > > > On 2024/5/8 17:02, Ryan Roberts wrote: >> On 08/05/2024 08:12, David Hildenbrand wrote: >>> On 08.05.24 09:08, David Hildenbrand wrote: >>>> On 08.05.24 06:45, Baolin Wang wrote: >>>>> >>>>> >>>>> On 2024/5/7 18:52, Ryan Roberts wrote: >>>>>> On 06/05/2024 09:46, Baolin Wang wrote: >>>>>>> To support the use of mTHP with anonymous shmem, add a new sysfs interface >>>>>>> 'shmem_enabled' in the '/sys/kernel/mm/transparent_hugepage/hugepages-kB/' >>>>>>> directory for each mTHP to control whether shmem is enabled for that mTHP, >>>>>>> with a value similar to the top level 'shmem_enabled', which can be set to: >>>>>>> "always", "inherit (to inherit the top level setting)", "within_size", >>>>>>> "advise", >>>>>>> "never", "deny", "force". These values follow the same semantics as the top >>>>>>> level, except the 'deny' is equivalent to 'never', and 'force' is equivalent >>>>>>> to 'always' to keep compatibility. >>>>>> >>>>>> We decided at [1] to not allow 'force' for non-PMD-sizes. >>>>>> >>>>>> [1] >>>>>> https://lore.kernel.org/linux-mm/533f37e9-81bf-4fa2-9b72-12cdcb1edb3f@redhat.com/ >>>>>> >>>>>> However, thinking about this a bit more, I wonder if the decision we made to >>>>>> allow all hugepages-xxkB/enabled controls to take "inherit" was the wrong >>>>>> one. >>>>>> Perhaps we should have only allowed the PMD-sized enable=inherit (this is >>>>>> just >>>>>> for legacy back compat after all, I don't think there is any use case where >>>>>> changing multiple mTHP size controls atomically is actually useful). Applying >>>>> >>>>> Agree. This is also our usage of 'inherit'. >>> >>> Missed that one: there might be use cases in the future once we would start >>> defaulting to "inherit" for all knobs (a distro might default to that) and >>> default-enable THP in the global knob. Then, it would be easy to disable any THP >>> by disabling the global knob. (I think that's the future we're heading to, where >>> we'd have an "auto" mode that can be set on the global toggle). >>> >>> But I am just making up use cases ;) I think it will be valuable and just doing >>> it consistently now might be cleaner. >> >> I agree that consistency between enabled and shmem_enabled is top priority. And >> yes, I had forgotten about the glorious "auto" future. So probably continuing >> all sizes to select "inherit" is best. >> >> But for shmem_enabled, that means we need the following error checking: >> >>   - It is an error to set "force" for any size except PMD-size >> >>   - It is an error to set "force" for the global control if any size except PMD- >>     size is set to "inherit" >> >>   - It is an error to set "inherit" for any size except PMD-size if the global >>     control is set to "force". >> >> Certainly not too difficult to code and prove to be correct, but not the nicest >> UX from the user's point of view when they start seeing errors. >> >> I think we previously said this would likely be temporary, and if/when tmpfs >> gets mTHP support, we could simplify and allow all sizes to be set to "force". >> But I wonder if tmpfs would ever need explicit mTHP control? Maybe it would be >> more suited to the approach the page cache takes to transparently ramp up the >> folio size as it faults more in. (Just saying there is a chance that this error >> checking becomes permanent). > > The strategy for tmpfs supporting mTHP will require more discussions and > evaluations in the future. However, regardless of the strategy (explicit mTHP > control or page cache control), I think it would be possible to use 'force' to > override previous strategies for some testing purposes. This appears to be > permissible according to the explanation in the current documentation: "force > the huge option on for all - very useful for testing". So it seems not permanent? Yeah ok, makes sense to me.