From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8229EC369D1 for ; Thu, 24 Apr 2025 09:50:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5646A6B008A; Thu, 24 Apr 2025 05:50:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 513936B0092; Thu, 24 Apr 2025 05:50:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 38CB66B00A1; Thu, 24 Apr 2025 05:50:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 167416B008A for ; Thu, 24 Apr 2025 05:50:37 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 588FE1CF806 for ; Thu, 24 Apr 2025 09:50:37 +0000 (UTC) X-FDA: 83368467714.18.67966D4 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf26.hostedemail.com (Postfix) with ESMTP id 9563F14000E for ; Thu, 24 Apr 2025 09:50:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mYoGdWUK; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1745488234; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Uh8kHXwfj8QuQ+9gFTMr1gfS0Q8c4U8sdk6PJBfRG3E=; b=QjhfmCudS0JsnEtIMjr6xPcH7yRCRhvnThFd4W0xDCAhokM8X0WrDvaFnX6ojLO14DJm3k Mwi/rQrMulb8DDuLDzXJmnErNFU87rqSMyKt2XelYxzHAw6UWMKLNHxbMn43M+Aor6qzvn zPA8eVtlMi2o0G7giY3pocjBWqnYYSs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mYoGdWUK; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of venkat88@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=venkat88@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1745488234; a=rsa-sha256; cv=none; b=Xe0odRq0+jIMbZ2GfpY1ftp2s4v/AmP41pg2yDUJDbk65poJ4YfuyHjPdrfYRyO4Cpmcut Dsu44CbGgj7N6W0EVPXMGsZgD9w2O4T6H0ip8kXCRomWZN7zXsm7CQlzFCAvtwtQd/GQjk fwjTKtWhAj0YJpkqU0+6QRGbIzIpDyA= Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53O8kHdI010515; Thu, 24 Apr 2025 09:50:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=Uh8kHX wfj8QuQ+9gFTMr1gfS0Q8c4U8sdk6PJBfRG3E=; b=mYoGdWUKKgSnwyQ7Q2Dbmh 1QBxrYObcf4OsQEQDx29fpvsXZMmQEvvymef/am8U47XxpuVMna9aQvc42SMRapO 0jCSRWUVgMuHS0WDf5Lh+1sAtBPE5UcnDRwJ9E9PXkDLmDvMh+LOYXR0LCpyKw95 Kg96vCCNO8NW01g34k99VpiCCYVQ0ZNz6MKevV+2/6IvbHHfgIslfa6l30njqLeE tPn3SzcOcm1PWItcO/+ZNbaOVw4FZmF0IZYXdzfCEq2Qb7a827AgjHj1ODkYyddh uo6xMwfGtrAf5UNOpk/W+zDkVOG+/nvrkvE0kuD8nEZIIpYqgvFYamvTZBucUOYw == Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4677sm2vbr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Apr 2025 09:50:19 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 53O7EJed028388; Thu, 24 Apr 2025 09:50:18 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 466jfvqj7w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 24 Apr 2025 09:50:18 +0000 Received: from smtpav05.dal12v.mail.ibm.com (smtpav05.dal12v.mail.ibm.com [10.241.53.104]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 53O9oHZP21824066 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 24 Apr 2025 09:50:17 GMT Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8417158068; Thu, 24 Apr 2025 09:50:17 +0000 (GMT) Received: from smtpav05.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7BA4358052; Thu, 24 Apr 2025 09:50:09 +0000 (GMT) Received: from [9.61.250.107] (unknown [9.61.250.107]) by smtpav05.dal12v.mail.ibm.com (Postfix) with ESMTP; Thu, 24 Apr 2025 09:50:09 +0000 (GMT) Message-ID: Date: Thu, 24 Apr 2025 15:20:07 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 0/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems Content-Language: en-GB To: Libo Chen , akpm@linux-foundation.org, rostedt@goodmis.org, peterz@infradead.org, mgorman@suse.de, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org, llong@redhat.com Cc: sraithal@amd.com, kprateek.nayak@amd.com, raghavendra.kt@amd.com, yu.c.chen@intel.com, tim.c.chen@intel.com, vineethr@linux.ibm.com, chris.hyser@oracle.com, daniel.m.jordan@oracle.com, lorenzo.stoakes@oracle.com, mkoutny@suse.com, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250424024523.2298272-1-libo.chen@oracle.com> From: Venkat Rao Bagalkote In-Reply-To: <20250424024523.2298272-1-libo.chen@oracle.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI0MDA2MyBTYWx0ZWRfX8ZNpSkKZyLTj Z+Uh4OY7lraJNkmIj/Ymz3IDHhUnNAVYWIuUR14Vh9nvJo6WJ+cKAwxYAsjHMBI+e+NeItqKSEF dOoOn8vXM92/bORUa+FklfQl2ALTdVcT4jRNSsIdb07qFoq9mq8pFf4RgFlE4rqQY3MqXil71H0 B8I27/qbVG+bvp1CvWcs0t1FGYbu7WVVztmIJQQDCYD6/x+4OpMfWQ3mLcW2hfp3N28GNccJwl1 kVfBepsOpGx+uX5A/t2Mp/QMz9Xx40qEEeS25jlF+IQg7zV7CRJ5F1BV76PmElF928pnhyxqj8h GtqCXz7ukg//H81xyZ/SY8xDYBZFd/m3YjzMqp7Zy1o6elPlScNctzEOrCfEX1A+aGCh0/dUFM8 FWSG7eWotzbhavj3ftdYMMkq1Rs6MQKzVqnKwogCN1Bef4xAVfWJESnVzPzKNZUgimeGJpEf X-Proofpoint-GUID: jJI7p_Pu69VP6hngBoJhzak20Bjjly3h X-Proofpoint-ORIG-GUID: jJI7p_Pu69VP6hngBoJhzak20Bjjly3h X-Authority-Analysis: v=2.4 cv=CcMI5Krl c=1 sm=1 tr=0 ts=680a095b cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=VnNF1IyMAAAA:8 a=2orru8iOFGd5tucj_wIA:9 a=QEXdDO2ut3YA:10 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.680,FMLib:17.12.80.40 definitions=2025-04-24_04,2025-04-22_01,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 malwarescore=0 clxscore=1015 mlxlogscore=999 adultscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 bulkscore=0 spamscore=0 lowpriorityscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504240063 X-Stat-Signature: tax5ndyk4ynajyqdncwemdxzif5irex4 X-Rspamd-Queue-Id: 9563F14000E X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1745488234-466109 X-HE-Meta: U2FsdGVkX1+Vc7nOiwsIjIUC7Hu8kHuJvkUoO2ZO7Iee6T/xBjQqRiAMBETTIiSzuhwIWrdyo7HiuCKoVCrKJzvNusjKjSn2FJUzlfE9uyZy/2IaMjqO2kl+cyda4y4vIbwDTSMbhAgY3EGQCR09aVtZ/McwgfaN9i1Mc5G/W4GmjHajamEGhnOyOL8lmBy8L4Ey2kphOQJ5RF8aLhhrzTKbYtTIQorpHDm8ZF+GrrMhtkAFTOLhxU0V/PFuLK7R8z+8ZhTwzL6Z8ULCG5u7WjtUmpAGzagBFxM7Sl5D8vxQq7+7zf1LI4KLYsaQfz0FxVr3nMkgamlwpQV/BVmS5jsoq4TrOKdORngBet0J6q2wEcOrUbFSJoxtJ6oG9ikmKA1tCC224N6VShoP1kJWI7Q/O5Gc0Ued7p7gu9PzTWYdPsSlqzL4/HkKTfyG9ox6jaLWx8nkfhGBKplC9rpCqEP/m2RUokac41XtUP+YCBkEiUs/P2sDhdJ/GbVrLsZtJ7Kas2Lv7u42XfxAb38gQ1DI3/ixk1/qCQSiHpsfLj5O/lpTUK0I7nAurqgUuZTiDgSff0/JbOz/zkxevJphDZDwGi98kCKNSOeKvTse0OD5bVkSXDQaqwrAAd1dJ9BbNheXL313QLgcUB8+2n5bMCN0nEgZN3L2swy3C/e63a1TGLftj46gcDoAvCzvF5srWZn4OAqeXvRWJDoedbmB97dY1P1rwa5B8HXtKugUJdqQsRoSqtt7Qpmz8TT/5Ccc0/7LPBtcG2O1kHiNKKpIUfj7aqM4HWNyLNbbYrwYQt1Rr7oy8NSHJitI0G8cJfAOkhua7cZ194CY5R6bbRTBoRvKyV08VU6bpSAAcHAyL6b60JuanI9MctOte0qRiiGRUmLNPkBs+llPEZLw6ZxxJ4V05GGtN8jtXHzbGiETZrE+B3/pz9xU2ya+o6PhydOXbQ0s5BUZyEytYRmVcBY wPfN0PIp fOzSUz9Ut/nands+7DWs47kfuEGjQK+FpKEnK4QZZaydcAc5UJuOZtPxMQ0S3Xzo7qQ+p6Mp1HWrSM866SLNXyE2BF2QPwvZtvGuxoyYWz7K9LpUfZUsHdT/x5vklaY4EzmbwQ2KGZknyWCsb8JnV7J47AVJulILSa7sEV0PdDrQ6PPUAF/Rshme06vSuIimGkT2Eu30udkHxEFxqMR/cBf/oWkL+VwTIn3cCTXBDDPX6sbxjnDT6jBJ+4A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 24/04/25 8:15 am, Libo Chen wrote: > v1->v2: > 1. add perf improvment numbers in commit log. Yet to find perf diff on > will-it-scale, so not included here. Plan to run more workloads. > 2. add tracepoint. > 3. To peterz's comment, this will make it impossible to attract tasks to > those memory just like other VMA skippings. This is the current > implementation, I think we can improve that in the future, but at the > moment it's probabaly better to keep it consistent. > > v2->v3: > 1. add enable_cpuset() based on Mel's suggestion but again I think it's > redundant. > 2. print out nodemask with %*p.. format in the tracepoint. > > v3->v4: > 1. fix an unsafe dereference of a pointer to content not on ring buffer, > namely mem_allowed_ptr in the tracepoint. > > v4->v5: > 1. add BUILD_BUG_ON() in TP_fast_assign() to guard against future > changes (particularly in size) in nodemask_t. > > Libo Chen (2): > sched/numa: Skip VMA scanning on memory pinned to one NUMA node via > cpuset.mems > sched/numa: Add tracepoint that tracks the skipping of numa balancing > due to cpuset memory pinning > > include/trace/events/sched.h | 33 +++++++++++++++++++++++++++++++++ > kernel/sched/fair.c | 9 +++++++++ > 2 files changed, 42 insertions(+) > Tested the above patch on top of next-20250424 and it fixes the boot warning on IBM Power server. Hence, Tested-by: Venkat Rao Bagalkote Regards, Venkat.