From: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
To: Libo Chen <libo.chen@oracle.com>,
akpm@linux-foundation.org, rostedt@goodmis.org,
peterz@infradead.org, mgorman@suse.de, mingo@redhat.com,
juri.lelli@redhat.com, vincent.guittot@linaro.org, tj@kernel.org,
llong@redhat.com
Cc: sraithal@amd.com, kprateek.nayak@amd.com, raghavendra.kt@amd.com,
yu.c.chen@intel.com, tim.c.chen@intel.com,
vineethr@linux.ibm.com, chris.hyser@oracle.com,
daniel.m.jordan@oracle.com, lorenzo.stoakes@oracle.com,
mkoutny@suse.com, linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 0/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems
Date: Thu, 24 Apr 2025 15:20:07 +0530 [thread overview]
Message-ID: <f67fd213-b39b-4f49-a839-38b9ad5565d2@linux.ibm.com> (raw)
In-Reply-To: <20250424024523.2298272-1-libo.chen@oracle.com>
On 24/04/25 8:15 am, Libo Chen wrote:
> v1->v2:
> 1. add perf improvment numbers in commit log. Yet to find perf diff on
> will-it-scale, so not included here. Plan to run more workloads.
> 2. add tracepoint.
> 3. To peterz's comment, this will make it impossible to attract tasks to
> those memory just like other VMA skippings. This is the current
> implementation, I think we can improve that in the future, but at the
> moment it's probabaly better to keep it consistent.
>
> v2->v3:
> 1. add enable_cpuset() based on Mel's suggestion but again I think it's
> redundant.
> 2. print out nodemask with %*p.. format in the tracepoint.
>
> v3->v4:
> 1. fix an unsafe dereference of a pointer to content not on ring buffer,
> namely mem_allowed_ptr in the tracepoint.
>
> v4->v5:
> 1. add BUILD_BUG_ON() in TP_fast_assign() to guard against future
> changes (particularly in size) in nodemask_t.
>
> Libo Chen (2):
> sched/numa: Skip VMA scanning on memory pinned to one NUMA node via
> cpuset.mems
> sched/numa: Add tracepoint that tracks the skipping of numa balancing
> due to cpuset memory pinning
>
> include/trace/events/sched.h | 33 +++++++++++++++++++++++++++++++++
> kernel/sched/fair.c | 9 +++++++++
> 2 files changed, 42 insertions(+)
>
Tested the above patch on top of next-20250424 and it fixes the boot
warning on IBM Power server. Hence,
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Regards,
Venkat.
prev parent reply other threads:[~2025-04-24 9:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 2:45 Libo Chen
2025-04-24 2:45 ` [PATCH v5 1/2] " Libo Chen
2025-04-24 2:45 ` [PATCH v5 2/2] sched/numa: Add tracepoint that tracks the skipping of numa balancing due to cpuset memory pinning Libo Chen
2025-04-24 4:42 ` [PATCH v5 0/2] sched/numa: Skip VMA scanning on memory pinned to one NUMA node via cpuset.mems K Prateek Nayak
2025-04-24 7:05 ` Venkat Rao Bagalkote
2025-04-24 7:46 ` Libo Chen
2025-04-24 9:47 ` Venkat Rao Bagalkote
2025-04-24 7:52 ` Aithal, Srikanth
2025-04-24 9:50 ` Venkat Rao Bagalkote [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f67fd213-b39b-4f49-a839-38b9ad5565d2@linux.ibm.com \
--to=venkat88@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris.hyser@oracle.com \
--cc=daniel.m.jordan@oracle.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=libo.chen@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llong@redhat.com \
--cc=lorenzo.stoakes@oracle.com \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@amd.com \
--cc=rostedt@goodmis.org \
--cc=sraithal@amd.com \
--cc=tim.c.chen@intel.com \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vineethr@linux.ibm.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox