From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82919C56201 for ; Wed, 18 Nov 2020 21:19:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 047A8246B8 for ; Wed, 18 Nov 2020 21:19:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="SkzschDU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 047A8246B8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 25DA16B0036; Wed, 18 Nov 2020 16:19:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E87F6B005C; Wed, 18 Nov 2020 16:19:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AEEC6B005D; Wed, 18 Nov 2020 16:19:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id CE52D6B0036 for ; Wed, 18 Nov 2020 16:19:49 -0500 (EST) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 65EC93622 for ; Wed, 18 Nov 2020 21:19:49 +0000 (UTC) X-FDA: 77498806098.14.shelf87_451561d2733d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 47B7D1822987A for ; Wed, 18 Nov 2020 21:19:49 +0000 (UTC) X-HE-Tag: shelf87_451561d2733d X-Filterd-Recvd-Size: 5594 Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 21:19:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=m1ARo/0U1ueFxD4Hp5bJ5SYHLHn7Kw0DJKg0xKcykSs=; b=SkzschDU7Vxqqsqvh8tfD7cmtf 7CaHVvsBCiJEfCTquV3FtsDy0MDliDQKgkhHarhONyjvDlATdBA+SxwkxUUoXHGVHXdLuqtEd5j5T iUQlwLL0m7A7Yc8AT4F9I9eG5WDZcaWvGDGF9GvYE30mUe6wmfxODlSd2y7K7WuPYTCh8Z7v7gXmY iuvOtfEU3JGhaIF4MY8h+LvjdxuHWoqli/OOkusZ/365RMMIcJyc9Y8pXwohFxZNZa0jya5HgeC8T PSoOJbwNNmA+P39+qLKxRAuiLRiefpBOcz+keS4dHgkVMpPWfbL24rQXjATIt4/2zgwqTjuYhsLO7 NoPI+QAA==; Received: from [2601:1c0:6280:3f0::bcc4] by merlin.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1kfUrg-0001eP-07; Wed, 18 Nov 2020 21:19:44 +0000 Subject: Re: [linux-next:master 5868/6773] arch/powerpc/mm/mem.c:91:12: warning: no previous prototype for function 'create_section_mapping' To: Nick Desaulniers , Dan Williams Cc: kernel test robot , kbuild-all@lists.01.org, clang-built-linux , Linux Memory Management List , Thomas Gleixner , Christoph Hellwig , Andrew Morton References: <202011182008.u7jsMtBl-lkp@intel.com> From: Randy Dunlap Message-ID: Date: Wed, 18 Nov 2020 13:19:38 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/18/20 11:52 AM, Nick Desaulniers wrote: > On Wed, Nov 18, 2020 at 11:22 AM Dan Williams wrote: >> >> On Wed, Nov 18, 2020 at 4:27 AM kernel test robot wrote: >>> >>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master >>> head: 2052923327794192c5d884623b5ee5fec1867bda >>> commit: d106ad47e292fde47fc09e16a2ddc13609ff2ad1 [5868/6773] mm-fix-phys_to_target_node-and-memory_add_physaddr_to_nid-exports-v4 >>> config: powerpc64-randconfig-r026-20201118 (attached as .config) > > ^ randconfig > >>> compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project b2613fb2f0f53691dd0211895afbb9413457fca7) >>> reproduce (this is a W=1 build): > > ^ W=1 > >>> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross >>> chmod +x ~/bin/make.cross >>> # install powerpc64 cross compiling tool for clang build >>> # apt-get install binutils-powerpc64-linux-gnu >>> # https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=d106ad47e292fde47fc09e16a2ddc13609ff2ad1 >>> git remote add linux-next https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git >>> git fetch --no-tags linux-next master >>> git checkout d106ad47e292fde47fc09e16a2ddc13609ff2ad1 >>> # save the attached .config to linux build tree >>> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=powerpc64 >> >> I get: >> >> Makefile:597: arch/powerpc64/Makefile: No such file or directory >> make[1]: *** No rule to make target 'arch/powerpc64/Makefile'. Stop. >> make: *** [Makefile:712: include/config/auto.conf.cmd] Error 2 >> >> ...changing it to ARCH=powerpc I get: >> >> Assembler messages: >> Fatal error: invalid listing option `3' >> clang: error: assembler command failed with exit code 1 (use -v to see >> invocation) >> make[1]: *** [scripts/Makefile.build:283: scripts/mod/empty.o] Error 1 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [Makefile:1199: prepare0] Error 2 >> >> This is on a Fedora 31 host. >> >>> >>> If you fix the issue, kindly add following tag as appropriate >>> Reported-by: kernel test robot >>> >>> All warnings (new ones prefixed by >>): >>> >>>>> arch/powerpc/mm/mem.c:91:12: warning: no previous prototype for function 'create_section_mapping' [-Wmissing-prototypes] >>> int __weak create_section_mapping(unsigned long start, unsigned long end, >>> ^ >>> arch/powerpc/mm/mem.c:91:1: note: declare 'static' if the function is not intended to be used outside of this translation unit >>> int __weak create_section_mapping(unsigned long start, unsigned long end, >>> ^ >>> static >>> 1 warning generated. >> >> I do not see these errors with gcc. >> >> I feel like clang errors should be flagged / de-emphasized when the >> same error does not appear on gcc. > > Note this is a W=1 build. For this warning, you either need to mark > functions as having static linkage, or provide a prototype in a header > so that callers know the correct function signature. Yes, so with gcc, that gave me something like 109 missing prototype warnings -- including one for 'create_section_mapping'. -- ~Randy