From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2E730C3DA4A for ; Tue, 20 Aug 2024 10:06:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9876E6B007B; Tue, 20 Aug 2024 06:06:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 937896B0082; Tue, 20 Aug 2024 06:06:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7FF126B0083; Tue, 20 Aug 2024 06:06:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 627B76B007B for ; Tue, 20 Aug 2024 06:06:47 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0E60012190B for ; Tue, 20 Aug 2024 10:06:47 +0000 (UTC) X-FDA: 82472194854.30.81B184A Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 1040D4001B for ; Tue, 20 Aug 2024 10:06:44 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LH3rBKUu; spf=pass (imf12.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724148326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dT3naxXzpX+hovDe3WRsxAFnWg41LZ8s9Rrc3hrzTd0=; b=ioW7/qG3ITgb85OjMYvviyP0pFo99choK9qETdjSvIjRDXVZ2hPVFsRBX1tDvXwtgmkga6 B+pQKj9jm3gmGxdXhIYjkhiL4m6ArwmlAFe/txOgAT16zIYiozZ4IZxIUObaOqSop5urTt L+RcVdFcBNvPvr+WyRgXzGy5pK0epZ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724148326; a=rsa-sha256; cv=none; b=FDdyCyAGzugo05JqEi2qQ1u3HK4MdXWyPUXXJ9naAqOiLN3FTsZzE795i4aF4u6SB81lVr bmXtHw3PcgDbPHaWeHLp0y24+Ncr0FhgbtjMTtBqVrVcrGUVRB1U2gQLPUjEsoX8bYrLs9 ZplrdviiamwIXpIgCZTeAfpArARokGY= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LH3rBKUu; spf=pass (imf12.hostedemail.com: domain of seakeel@gmail.com designates 209.85.210.169 as permitted sender) smtp.mailfrom=seakeel@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-714186ce2f2so85183b3a.0 for ; Tue, 20 Aug 2024 03:06:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724148403; x=1724753203; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=dT3naxXzpX+hovDe3WRsxAFnWg41LZ8s9Rrc3hrzTd0=; b=LH3rBKUuCQPSUmD4+mvEsZckomlvSOw35vFqzMF9kPci5BTpUuywU5YdF9q3VB9dEO mNHotHkO64E1tQb4IgXXKgLOKCy1hSIr2LFtc5uQ91WLITviP1IsCPTaGq9XUDaUmo8Q EdJyUzcn/RG9rAIw/8qI3eL2ZWkNdSWzjlL34AULqlFzL3OOunwHTjsH9JPIyW2Duje+ Sr5zocw8XSeeHvK6CFBpg4bvt53FymKTrCsro15LX2YLe8O41SD2Gc7RH9LNxySjhzuc DVV0RWxG2/7NYVRlSoZv9T/XK6tw/OsOVr8h7VFGK6JbLcZmbe0ydsR9++uya4AyoSiL zmpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724148403; x=1724753203; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dT3naxXzpX+hovDe3WRsxAFnWg41LZ8s9Rrc3hrzTd0=; b=I+n9w9q2wQyJRaNd6YaP7g6pSHrdifd2xd5UyXbr20G6C46kaYxMbII+mMBSA63hAC 99IXGWVm7zb3CBO0W688uJc6Kp4qwWdT8JN0c1a9DjkTibGV55LOwD/YgvvMXzTYFfvS hynfWThFqLtCcBHosIWQwThVqry6LcCAcxeJ2GjDjlcnzMeSbahx7H2bBpM+hc/jdByo WyQYei/Cstt0CveQVYOGw33FrLS8mYNu/w6/ZP8Qb5Ajo8eOh5Sl5A6nkbxCpbG9LsNc CuMwAqgtZfVTJqlOTYc0vhzBIzQp8Ga5rM6lAIXLiPUSncfPO1Oo/Zk+51+LKk0FCnUA l6Yg== X-Forwarded-Encrypted: i=1; AJvYcCXH/A4GkM8q20HWo+aHAs0AibE+G6h/l97+cxokcU5qu2bn0mrXIFM/eGfXwdklPw53eHxh5Via2A==@kvack.org X-Gm-Message-State: AOJu0Yw2BclWm3qsafLKGwsCVF3LC+RhMgVn0+hQA61BN260W047y/w8 TYxsrSIdh3R7PpEE9PNHwJBbbuEUlG/kakI2ulhYAeyqpJzIDb1h X-Google-Smtp-Source: AGHT+IGJ2TEhCeQ4T6stmHuMptTexASfuExA2FNFId6sOB+IUIEs5Twh28uzGFa3MpzDMsWieKEUpw== X-Received: by 2002:a05:6a20:e608:b0:1c6:fad1:c20f with SMTP id adf61e73a8af0-1c904f742d4mr14595485637.5.1724148403270; Tue, 20 Aug 2024 03:06:43 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d3c8839392sm10484679a91.56.2024.08.20.03.06.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 20 Aug 2024 03:06:42 -0700 (PDT) Message-ID: Date: Tue, 20 Aug 2024 18:06:39 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] mm: skip less than check for MAX_NR_ZONES To: Andrew Morton , alexs@kernel.org Cc: open list , linux-mm@kvack.org References: <20240819112628.372883-1-alexs@kernel.org> <20240819214055.978b33eae88004d35b9ce634@linux-foundation.org> Content-Language: en-US From: Alex Shi In-Reply-To: <20240819214055.978b33eae88004d35b9ce634@linux-foundation.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: jfghaqcanrux9zox35zxta1ujarnx6m3 X-Rspamd-Queue-Id: 1040D4001B X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724148404-146324 X-HE-Meta: U2FsdGVkX1+tNgjUK5AbFbj7EfpSp1fAk54qv3gnhlYazQciZ/QFnMvgpgFPtNPCaqRpr1WG3DA7Ce78xgBjuuyEk89t9CO45mgfTMc4p+UhYyYw80SZabAaVw6rVJ6X/FsgqkPOMvnAJPRYT39wLEK8SMtsq9d15J009/4kPbc5Z5Aatr/0kQIqTzaulOlCr0fPMxlvhmVPiQm3z17mLSgOe2GJ8KwYyFmJelb5+i5EBSfRptGJk+ML9jz6aiN5a+uXKaVOrP5bgI9KI83hWKBaHpZOiU7ujUZVzfz4+6l79IMUzY+dsrniMGv5SgU611d9jp0vUduj/+5sj4oDgpxn2XtZnd+9e1JjIcwr5VYig7thMca0NDuRrVyCnwulGBNCkVeNKp6ET97ToNV5mFCC8Uzsa+2QTPktOUdMccp4EoQcLfjUImsdK/nuf2lHhlXS8JrRy6QPC+e1kkeWolYbwNOpPZ4rHr4Fh/yj8G5sVbnwFkJ0J+d1u98YgemmHjakwbJb+pZM+6zqE3MRCj9BVWWDdmv0DGQKJbIi63RNWO/JtwGPSaTz1X4l7+f95lSbT5su4klcIXAnxHB3WEQan7kR8Yrug8BCwQrqUOfgkVC3LopFD92AMv+J27PLIeV4tv04dPtGaAk6WsWeget9txdK4KqRV9rLErnh3HmuN80BYqt7tWIwiLcGDmKfso9/0vEPtjTJ0taRvFusiuJgzVJVZYDlRE9liojcCehc0PCXk3wkqI15dR+K9waQkzReUwKuXst9Cmc7pWNATDE4gzdgKiRMSjYV+pDrH1dZ3fcsGaFTzIYP1xaByzcIKN2g8MnnFEGVg7NTT/dPARDTIzDm01wD6cIHaJ1+MaB/F9mHreoIrUMZ9PF61/kZXG4PRJHxpIGNaBmgd4u/veCdUfHqqb3ErmoLmjSVsxVbt6tHrgOxxoNW0GNTk4Hvh3L4C5c5q7Ok2TRizFc QEPzsjWf TShIDfCNjL4W1vXW7EOrp52ktzvhD4ozTSBfCiDxm+gOasxwbEz89PzzSQI6HkJ1pxRIVkaMv4cmYhSEtfoE0CPJ+p8JiUMBGUyECN1S2AopFd4yXTuJVKSMg7GurWR5s+/9Sp/8ECFjAyzpeSg3bJZHBhUZ3yLPJVWKWVPemwBH30HJwLFMOpA9sq+Dp3UYjn9ZDIKVxkvISJO1p9Om3MMctdPZrAxuGTCDQvlV+BgxKlfh+4sG6RXsUpHls2pNiP8ef5mIAxbAQNU6Y+Gbqr9MLORClPvh2LoO/qdoCgpghO68Wi5kzvysXa3XB9D+1iJKfv1PLfXcHKf3uDZHgDWHrDYTR/p0aAzTXNw2xyKNXcYvB6NMsWX+fq/GdcrDZ3F89/trR56J4YbW8b3cOY+bBXTUT9HXKgD2P7m4tFnffP3pkePr06sDwj0JCIwshzzQ73uvvY1kEjcldiTPklLdMEKhpaoEdovhv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 8/20/24 12:40 PM, Andrew Morton wrote: > On Mon, 19 Aug 2024 19:26:28 +0800 alexs@kernel.org wrote: > >> From: Alex Shi >> >> Remove unnecessary '<' check for ZONES_SHIFT assignment. >> >> ... >> >> --- a/include/linux/page-flags-layout.h >> +++ b/include/linux/page-flags-layout.h >> @@ -14,7 +14,7 @@ >> */ >> #if MAX_NR_ZONES < 2 >> #define ZONES_SHIFT 0 >> -#elif MAX_NR_ZONES <= 2 >> +#elif MAX_NR_ZONES == 2 >> #define ZONES_SHIFT 1 >> #elif MAX_NR_ZONES <= 4 >> #define ZONES_SHIFT 2 > > mmm, why. I think it looks more logical (and certainly more > consistent) the way things are now. > Uh, then let's keep the current code if the logical looks better. In fact, the logical is in preprocess, has nothing change in the final object file. Thanks for comments!