From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB8E1C10F1B for ; Wed, 28 Dec 2022 02:06:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00E578E0002; Tue, 27 Dec 2022 21:06:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EFFB78E0001; Tue, 27 Dec 2022 21:06:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DEFA98E0002; Tue, 27 Dec 2022 21:06:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D15C38E0001 for ; Tue, 27 Dec 2022 21:06:29 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A69651A071B for ; Wed, 28 Dec 2022 02:06:29 +0000 (UTC) X-FDA: 80290075698.22.9EEB26B Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf30.hostedemail.com (Postfix) with ESMTP id 2120280008 for ; Wed, 28 Dec 2022 02:06:25 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1672193188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KPY5rG+UYhlBDbuOunqsh+/2b0TR+PPd/gxHyuPcBHE=; b=miThOymvhEGOsdwAW/UXo2dLeOi/wMPeXYJtFMZC0DzZouPYF3OYMHH2me1+jOZxiJsrJh lNDPpVj5nqn90PogUCHkSWpV8sl3O+vEuh9PO74qrdBFw1vwhl+uuOssy9TJptioD6kgvF bC9nVYFAPKq70dcZ453nIchCeMt42N0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of wangkefeng.wang@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=wangkefeng.wang@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1672193188; a=rsa-sha256; cv=none; b=xjgK26H1PUSim3b1kiq/JqSarJbF7vFxmUAGuhaLOR2na9MfQc4bimE7MmMQaP3X4pXov2 xUxvHaxPqJDNCxXCwNA2a+Bl8Wd0WZ0ItRZbRFOObZzUId7nzE54ehVWH1tA4mfA1gQhvU K23C/16+O++MVqg8/L6VSgog3V9Bqt0= Received: from dggpemm500001.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4NhZWy1ZvNzkX25; Wed, 28 Dec 2022 10:01:50 +0800 (CST) Received: from [10.174.177.243] (10.174.177.243) by dggpemm500001.china.huawei.com (7.185.36.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 28 Dec 2022 10:06:21 +0800 Message-ID: Date: Wed, 28 Dec 2022 10:06:20 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH -next v2 2/7] mm: damon: introduce damon_get_folio() Content-Language: en-US To: SeongJae Park CC: Andrew Morton , , , , , References: <20221227194257.2744-1-sj@kernel.org> From: Kefeng Wang In-Reply-To: <20221227194257.2744-1-sj@kernel.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.177.243] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To dggpemm500001.china.huawei.com (7.185.36.107) X-CFilter-Loop: Reflected X-Stat-Signature: 5xiz3abm8qu4t3sd8ungqisxfpbiryhw X-Rspam-User: X-Rspamd-Queue-Id: 2120280008 X-Rspamd-Server: rspam06 X-HE-Tag: 1672193185-434194 X-HE-Meta: U2FsdGVkX1/VS6gJqgLSGZdCJhaA9GQhEST823IwrO7tYqYXc2X2EVWE+zivf3ndFzR1C8J6ClQwcvfLaJW0K3PivOgtOvz1Dfq2mZNtUHCm5hiGftjMULYfDaCdHdvO3DF/4iHsiyQRP8EDNA80Am+TweT26BzxwQ26HxvLqWAQtfpbL3MI6YAhayy1vpT6iI6N1LsVEHAeFRdsdnBQV3KKJYQDTdX0iAJG/+4rf4y8wWLnRdJtlLg8GXjJlv7HHjG2e3t1l9Y6TBn2d0nr9TFtCfa8jQk3v0W+72davTQtD1VgJNITViJxnKi4iPAhwC8BqlB7pR73n5ii5FMsD5vXcmUTRFsgChF6sExGoN+whr8F1dkqJh7RSaMEYc82F6V4XnDVjNx0uB6YFkOEl9Aa9MZ5UwIY7U1QSCGNpIJ/w9PMn7FydAzYvodqK/ENPv885kjYQION6miaroONp3Hjq/8DVSnw1es3H2egEDj8IFKqFHJA8eaoaBQEMXaCSJ0PNy3jqVwTGS8N09QIaCVu7SBngDssq/1KcwvyXlHeeKOi+/s9rwXe8OIJUymx+VvctSsqgfmpg+KzpRcOYnyi5mhm+KkldHLUnrnluzlb4mtZ2Lbv7rn6kFL9CmlEnU95nn3yIZ6SrX+/yo3dx+EX5eORtZylQjXETJso1ZBGHTPyGvpbmab1K2KQfLlvxR8IYPhRDavuCSTFi72NiQnq3ClFWrO4SCkTa04/iK3s4xGdrqgZQ/tEIl80RFl0BaUJHTrNvZrTtxMKUDjhaBr/3JC+tbZUrnDLhuLrIL8q6F909cME9Wyb4rm3y4PzY6yikXwFg4eG0akZYPudpDCdW4dFJQqFzBCRV2MylAWKWdzxKSD10uAGsBKek3UH0z7m7ma3nbBgp+UkWoiZTpTSgNdu9sQaCufI9atQCqLX5AaOOb8xKKYt/XRijVge X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2022/12/28 3:42, SeongJae Park wrote: > Hi Kefeng, > > Could we use 'mm/damon:' prefix instead of 'mm: damon:' for the patch subjects? Sure. > > On Tue, 27 Dec 2022 20:27:09 +0800 Kefeng Wang wrote: > >> Introduce damon_get_folio(), and the temporary wrapper function >> damon_get_page(), which help us to convert damon related function >> to use folios, and it will be droped once the conversion is completed. >> >> Signed-off-by: Kefeng Wang >> --- >> mm/damon/ops-common.c | 14 ++++++++------ >> mm/damon/ops-common.h | 8 +++++++- >> 2 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c >> index 75409601f934..ff38a19aa92e 100644 >> --- a/mm/damon/ops-common.c >> +++ b/mm/damon/ops-common.c >> @@ -16,21 +16,23 @@ >> * Get an online page for a pfn if it's in the LRU list. Otherwise, returns >> * NULL. >> * >> - * The body of this function is stolen from the 'page_idle_get_page()'. We >> + * The body of this function is stolen from the 'page_idle_get_folio()'. We >> * steal rather than reuse it because the code is quite simple. >> */ >> -struct page *damon_get_page(unsigned long pfn) >> +struct folio *damon_get_folio(unsigned long pfn) >> { >> struct page *page = pfn_to_online_page(pfn); >> + struct folio *folio; >> >> if (!page || !PageLRU(page) || !get_page_unless_zero(page)) >> return NULL; >> >> - if (unlikely(!PageLRU(page))) { >> - put_page(page); >> - page = NULL; >> + folio = page_folio(page); >> + if (unlikely(!folio_test_lru(folio))) { >> + folio_put(folio); >> + folio = NULL; >> } > > I think Matthew's comment for 'page_idle_get_folio()'[1] could applied here? > Will change too. > > [1] https://lore.kernel.org/damon/Y6s2HPjrON2Sx%2Fgr@casper.infradead.org/ > >> - return page; >> + return folio; >> } >> >> void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr) >> diff --git a/mm/damon/ops-common.h b/mm/damon/ops-common.h >> index 8d82d3722204..4ee607813981 100644 >> --- a/mm/damon/ops-common.h >> +++ b/mm/damon/ops-common.h >> @@ -7,7 +7,13 @@ >> >> #include >> >> -struct page *damon_get_page(unsigned long pfn); >> +struct folio *damon_get_folio(unsigned long pfn); >> +static inline struct page *damon_get_page(unsigned long pfn) >> +{ >> + struct folio *folio = damon_get_folio(pfn); >> + >> + return &folio->page; > > I think we should check if folio is NULL before dereferencing it? I could add comment here, thanks. > >> +} >> >> void damon_ptep_mkold(pte_t *pte, struct mm_struct *mm, unsigned long addr); >> void damon_pmdp_mkold(pmd_t *pmd, struct mm_struct *mm, unsigned long addr); >> -- >> 2.35.3 >>